Loading ...
Sorry, an error occurred while loading the content.
 

Patch 7.4.367

Expand Messages
  • Bram Moolenaar
    Patch 7.4.367 (after 7.4.357) Problem: Other solution for redrawing after completion. Solution: Schedule a window redraw instead of just clearing the
    Message 1 of 4 , Jul 16, 2014
      Patch 7.4.367 (after 7.4.357)
      Problem: Other solution for redrawing after completion.
      Solution: Schedule a window redraw instead of just clearing the command
      line. (Jacob Niehus)
      Files: src/edit.c


      *** ../vim-7.4.366/src/edit.c 2014-07-09 14:00:45.175044250 +0200
      --- src/edit.c 2014-07-16 14:36:00.679748155 +0200
      ***************
      *** 3854,3860 ****
      ins_compl_free();
      compl_started = FALSE;
      compl_matches = 0;
      ! msg_clr_cmdline(); /* necessary for "noshowmode" */
      ctrl_x_mode = 0;
      compl_enter_selects = FALSE;
      if (edit_submode != NULL)
      --- 3854,3861 ----
      ins_compl_free();
      compl_started = FALSE;
      compl_matches = 0;
      ! if (!shortmess(SHM_COMPLETIONMENU))
      ! msg_clr_cmdline(); /* necessary for "noshowmode" */
      ctrl_x_mode = 0;
      compl_enter_selects = FALSE;
      if (edit_submode != NULL)
      ***************
      *** 4591,4597 ****
      --- 4592,4601 ----
      */
      i = compl_col + (compl_cont_status & CONT_ADDING ? compl_length : 0);
      backspace_until_column(i);
      +
      + /* Not sure what is still valid, better redraw everything. */
      changed_cline_bef_curs();
      + redraw_curbuf_later(NOT_VALID);
      }

      /* Insert the new text being completed. */
      *** ../vim-7.4.366/src/version.c 2014-07-16 14:20:38.255766903 +0200
      --- src/version.c 2014-07-16 14:42:23.059740384 +0200
      ***************
      *** 736,737 ****
      --- 736,739 ----
      { /* Add new patch number below this line */
      + /**/
      + 367,
      /**/

      --
      No children may attend school with their breath smelling of "wild onions."
      [real standing law in West Virginia, United States of America]

      /// Bram Moolenaar -- Bram@... -- http://www.Moolenaar.net \\\
      /// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
      \\\ an exciting new programming language -- http://www.Zimbu.org ///
      \\\ help me help AIDS victims -- http://ICCF-Holland.org ///

      --
      --
      You received this message from the "vim_dev" maillist.
      Do not top-post! Type your reply below the text you are replying to.
      For more information, visit http://www.vim.org/maillist.php

      ---
      You received this message because you are subscribed to the Google Groups "vim_dev" group.
      To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscribe@....
      For more options, visit https://groups.google.com/d/optout.
    • h_east
      Hi Bram, ... Popup menu is very flickering in this patch. I think better to revert below line. + redraw_curbuf_later(NOT_VALID); -- Best regards, Hirohito
      Message 2 of 4 , Jul 16, 2014
        Hi Bram,

        2014/7/16(Wed) 21:44:08 UTC+9 Bram Moolenaar:
        > Patch 7.4.367 (after 7.4.357)
        >
        > Problem: Other solution for redrawing after completion.
        >
        > Solution: Schedule a window redraw instead of just clearing the command
        >
        > line. (Jacob Niehus)
        >
        > Files: src/edit.c
        >
        >
        >
        >
        >
        > *** ../vim-7.4.366/src/edit.c 2014-07-09 14:00:45.175044250 +0200
        >
        > --- src/edit.c 2014-07-16 14:36:00.679748155 +0200
        >
        > ***************
        >
        > *** 3854,3860 ****
        >
        > ins_compl_free();
        >
        > compl_started = FALSE;
        >
        > compl_matches = 0;
        >
        > ! msg_clr_cmdline(); /* necessary for "noshowmode" */
        >
        > ctrl_x_mode = 0;
        >
        > compl_enter_selects = FALSE;
        >
        > if (edit_submode != NULL)
        >
        > --- 3854,3861 ----
        >
        > ins_compl_free();
        >
        > compl_started = FALSE;
        >
        > compl_matches = 0;
        >
        > ! if (!shortmess(SHM_COMPLETIONMENU))
        >
        > ! msg_clr_cmdline(); /* necessary for "noshowmode" */
        >
        > ctrl_x_mode = 0;
        >
        > compl_enter_selects = FALSE;
        >
        > if (edit_submode != NULL)
        >
        > ***************
        >
        > *** 4591,4597 ****
        >
        > --- 4592,4601 ----
        >
        > */
        >
        > i = compl_col + (compl_cont_status & CONT_ADDING ? compl_length : 0);
        >
        > backspace_until_column(i);
        >
        > +
        >
        > + /* Not sure what is still valid, better redraw everything. */
        >
        > changed_cline_bef_curs();
        >
        > + redraw_curbuf_later(NOT_VALID);
        >
        > }
        >
        >
        >
        > /* Insert the new text being completed. */
        >
        > *** ../vim-7.4.366/src/version.c 2014-07-16 14:20:38.255766903 +0200
        >
        > --- src/version.c 2014-07-16 14:42:23.059740384 +0200
        >
        > ***************
        >
        > *** 736,737 ****
        >
        > --- 736,739 ----
        >
        > { /* Add new patch number below this line */
        >
        > + /**/
        >
        > + 367,
        >
        > /**/
        >

        Popup menu is very flickering in this patch.

        I think better to revert below line.
        + redraw_curbuf_later(NOT_VALID);

        --
        Best regards,
        Hirohito Higashi

        --
        --
        You received this message from the "vim_dev" maillist.
        Do not top-post! Type your reply below the text you are replying to.
        For more information, visit http://www.vim.org/maillist.php

        ---
        You received this message because you are subscribed to the Google Groups "vim_dev" group.
        To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscribe@....
        For more options, visit https://groups.google.com/d/optout.
      • Bram Moolenaar
        ... OK. Can you reproduce the original problem when that line is removed? -- ERIC IDLE PLAYED: THE DEAD COLLECTOR, MR BINT (A VILLAGE NE ER-DO -WELL VERY KEEN
        Message 3 of 4 , Jul 17, 2014
          Hirohito Higashi wrote:

          > 2014/7/16(Wed) 21:44:08 UTC+9 Bram Moolenaar:
          > > Patch 7.4.367 (after 7.4.357)
          > > Problem: Other solution for redrawing after completion.
          > > Solution: Schedule a window redraw instead of just clearing the command
          > > line. (Jacob Niehus)
          > > Files: src/edit.c
          >
          > Popup menu is very flickering in this patch.
          >
          > I think better to revert below line.
          > + redraw_curbuf_later(NOT_VALID);

          OK. Can you reproduce the original problem when that line is removed?

          --
          ERIC IDLE PLAYED: THE DEAD COLLECTOR, MR BINT (A VILLAGE NE'ER-DO -WELL VERY
          KEEN ON BURNING WITCHES), SIR ROBIN, THE GUARD WHO DOESN'T
          HICOUGH BUT TRIES TO GET THINGS STRAIGHT, CONCORDE (SIR
          LAUNCELOT'S TRUSTY STEED), ROGER THE SHRUBBER (A SHRUBBER),
          BROTHER MAYNARD
          "Monty Python and the Holy Grail" PYTHON (MONTY) PICTURES LTD

          /// Bram Moolenaar -- Bram@... -- http://www.Moolenaar.net \\\
          /// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
          \\\ an exciting new programming language -- http://www.Zimbu.org ///
          \\\ help me help AIDS victims -- http://ICCF-Holland.org ///

          --
          --
          You received this message from the "vim_dev" maillist.
          Do not top-post! Type your reply below the text you are replying to.
          For more information, visit http://www.vim.org/maillist.php

          ---
          You received this message because you are subscribed to the Google Groups "vim_dev" group.
          To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscribe@....
          For more options, visit https://groups.google.com/d/optout.
        • h_east
          Hi Bram, ... No. I can not reproduce the original problem. Problem does not occur even which version of Vim. My environment: - Vim 7.4.373(Huge) on fedora19
          Message 4 of 4 , Jul 17, 2014
            Hi Bram,

            2014/7/17(Thu) 20:25:00 UTC+9 Bram Moolenaar:
            > Hirohito Higashi wrote:
            >
            >
            >
            > > 2014/7/16(Wed) 21:44:08 UTC+9 Bram Moolenaar:
            >
            > > > Patch 7.4.367 (after 7.4.357)
            >
            > > > Problem: Other solution for redrawing after completion.
            >
            > > > Solution: Schedule a window redraw instead of just clearing the command
            >
            > > > line. (Jacob Niehus)
            >
            > > > Files: src/edit.c
            >
            > >
            >
            > > Popup menu is very flickering in this patch.
            >
            > >
            >
            > > I think better to revert below line.
            >
            > > + redraw_curbuf_later(NOT_VALID);
            >
            >
            >
            > OK. Can you reproduce the original problem when that line is removed?

            No. I can not reproduce the original problem.
            Problem does not occur even which version of Vim.

            My environment:
            - Vim 7.4.373(Huge) on fedora19 via PuTTY
            - GVim 7.4.364(Huge 64bit) on Windows 7 SP1 (64bit)

            --
            Best regards,
            Hirohito Higashi

            --
            --
            You received this message from the "vim_dev" maillist.
            Do not top-post! Type your reply below the text you are replying to.
            For more information, visit http://www.vim.org/maillist.php

            ---
            You received this message because you are subscribed to the Google Groups "vim_dev" group.
            To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscribe@....
            For more options, visit https://groups.google.com/d/optout.
          Your message has been successfully submitted and would be delivered to recipients shortly.