Loading ...
Sorry, an error occurred while loading the content.

Patch 7.4.217

Expand Messages
  • Bram Moolenaar
    Patch 7.4.217 Problem: When src/auto/configure was updated, make clean would run configure pointlessly. Solution: Do not run configure for make clean
    Message 1 of 5 , Mar 25, 2014
    • 0 Attachment
      Patch 7.4.217
      Problem: When src/auto/configure was updated, "make clean" would run
      configure pointlessly.
      Solution: Do not run configure for "make clean" and "make distclean" when
      the make program supports $MAKECMDGOALS. (Ken Takata)
      Files: src/Makefile


      *** ../vim-7.4.216/src/Makefile 2014-02-05 12:36:36.622026833 +0100
      --- src/Makefile 2014-03-25 15:31:10.629929307 +0100
      ***************
      *** 546,551 ****
      --- 546,552 ----
      # again.
      #CC = cc
      #CC = gcc
      + #CC = clang

      # COMPILER FLAGS - change as you please. Either before running {{{1
      # configure or afterwards. For examples see below.
      ***************
      *** 1666,1672 ****
      ! grep -x -F 'ac_cv_env_CFLAGS_value=$(CFLAGS)' auto/config.cache > /dev/null; then \
      rm auto/config.cache; \
      fi
      ! GUI_INC_LOC="$(GUI_INC_LOC)" GUI_LIB_LOC="$(GUI_LIB_LOC)" \
      CC="$(CC)" CPPFLAGS="$(CPPFLAGS)" CFLAGS="$(CFLAGS)" \
      LDFLAGS="$(LDFLAGS)" $(CONF_SHELL) srcdir="$(srcdir)" \
      ./configure $(CONF_OPT_GUI) $(CONF_OPT_X) $(CONF_OPT_XSMP) \
      --- 1667,1674 ----
      ! grep -x -F 'ac_cv_env_CFLAGS_value=$(CFLAGS)' auto/config.cache > /dev/null; then \
      rm auto/config.cache; \
      fi
      ! if test "X$(MAKECMDGOALS)" != "Xclean" -a "X$(MAKECMDGOALS)" != "Xdistclean"; then \
      ! GUI_INC_LOC="$(GUI_INC_LOC)" GUI_LIB_LOC="$(GUI_LIB_LOC)" \
      CC="$(CC)" CPPFLAGS="$(CPPFLAGS)" CFLAGS="$(CFLAGS)" \
      LDFLAGS="$(LDFLAGS)" $(CONF_SHELL) srcdir="$(srcdir)" \
      ./configure $(CONF_OPT_GUI) $(CONF_OPT_X) $(CONF_OPT_XSMP) \
      ***************
      *** 1679,1685 ****
      $(CONF_OPT_COMPBY) $(CONF_OPT_ACL) $(CONF_OPT_NETBEANS) \
      $(CONF_ARGS) $(CONF_OPT_MZSCHEME) $(CONF_OPT_PLTHOME) \
      $(CONF_OPT_LUA) $(CONF_OPT_LUA_PREFIX) \
      ! $(CONF_OPT_SYSMOUSE)

      # Use "make reconfig" to rerun configure without cached values.
      # When config.h changes, most things will be recompiled automatically.
      --- 1681,1688 ----
      $(CONF_OPT_COMPBY) $(CONF_OPT_ACL) $(CONF_OPT_NETBEANS) \
      $(CONF_ARGS) $(CONF_OPT_MZSCHEME) $(CONF_OPT_PLTHOME) \
      $(CONF_OPT_LUA) $(CONF_OPT_LUA_PREFIX) \
      ! $(CONF_OPT_SYSMOUSE); \
      ! fi

      # Use "make reconfig" to rerun configure without cached values.
      # When config.h changes, most things will be recompiled automatically.
      *** ../vim-7.4.216/src/version.c 2014-03-25 13:46:22.841832960 +0100
      --- src/version.c 2014-03-25 15:32:30.813930536 +0100
      ***************
      *** 736,737 ****
      --- 736,739 ----
      { /* Add new patch number below this line */
      + /**/
      + 217,
      /**/

      --
      CRONE: Who sent you?
      ARTHUR: The Knights Who Say GNU!
      CRONE: Aaaagh! (she looks around in rear) No! We have no licenses here.
      "Monty Python and the Holy editor wars" PYTHON (MONTY) SOFTWARE LTD

      /// Bram Moolenaar -- Bram@... -- http://www.Moolenaar.net \\\
      /// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
      \\\ an exciting new programming language -- http://www.Zimbu.org ///
      \\\ help me help AIDS victims -- http://ICCF-Holland.org ///

      --
      --
      You received this message from the "vim_dev" maillist.
      Do not top-post! Type your reply below the text you are replying to.
      For more information, visit http://www.vim.org/maillist.php

      ---
      You received this message because you are subscribed to the Google Groups "vim_dev" group.
      To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscribe@....
      For more options, visit https://groups.google.com/d/optout.
    • Ken Takata
      Hi, ... Now I think that it s better to skip running configure also for make autoconf and make reconfig . Regards, Ken Takata -- -- You received this
      Message 2 of 5 , Apr 10, 2014
      • 0 Attachment
        Hi,

        2014/3/25 Tue 23:35:23 UTC+9 Bram Moolenaar wrote:
        > Patch 7.4.217
        > Problem: When src/auto/configure was updated, "make clean" would run
        > configure pointlessly.
        > Solution: Do not run configure for "make clean" and "make distclean" when
        > the make program supports $MAKECMDGOALS. (Ken Takata)
        > Files: src/Makefile

        Now I think that it's better to skip running configure also for
        "make autoconf" and "make reconfig".

        Regards,
        Ken Takata

        --
        --
        You received this message from the "vim_dev" maillist.
        Do not top-post! Type your reply below the text you are replying to.
        For more information, visit http://www.vim.org/maillist.php

        ---
        You received this message because you are subscribed to the Google Groups "vim_dev" group.
        To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscribe@....
        For more options, visit https://groups.google.com/d/optout.
      • Ben Fritz
        ... Isn t running configure half the point of making those two targets? Or am I missing something? -- -- You received this message from the vim_dev maillist.
        Message 3 of 5 , Apr 10, 2014
        • 0 Attachment
          On Thursday, April 10, 2014 6:21:57 AM UTC-5, Ken Takata wrote:
          > Hi,
          >
          > 2014/3/25 Tue 23:35:23 UTC+9 Bram Moolenaar wrote:
          > > Patch 7.4.217
          > > Problem: When src/auto/configure was updated, "make clean" would run
          > > configure pointlessly.
          > > Solution: Do not run configure for "make clean" and "make distclean" when
          > > the make program supports $MAKECMDGOALS. (Ken Takata)
          > > Files: src/Makefile
          >
          > Now I think that it's better to skip running configure also for
          > "make autoconf" and "make reconfig".
          >

          Isn't running configure half the point of making those two targets? Or am I missing something?

          --
          --
          You received this message from the "vim_dev" maillist.
          Do not top-post! Type your reply below the text you are replying to.
          For more information, visit http://www.vim.org/maillist.php

          ---
          You received this message because you are subscribed to the Google Groups "vim_dev" group.
          To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscribe@....
          For more options, visit https://groups.google.com/d/optout.
        • Bram Moolenaar
          ... Makes sense. Have you checked that make reconfig does run configure after cleaning? -- Oh, no! NOT the Spanish Inquisition! NOBODY expects the
          Message 4 of 5 , Apr 10, 2014
          • 0 Attachment
            Ken Takata wrote:

            > 2014/3/25 Tue 23:35:23 UTC+9 Bram Moolenaar wrote:
            > > Patch 7.4.217
            > > Problem: When src/auto/configure was updated, "make clean" would run
            > > configure pointlessly.
            > > Solution: Do not run configure for "make clean" and "make distclean" when
            > > the make program supports $MAKECMDGOALS. (Ken Takata)
            > > Files: src/Makefile
            >
            > Now I think that it's better to skip running configure also for
            > "make autoconf" and "make reconfig".

            Makes sense. Have you checked that "make reconfig" does run configure
            after cleaning?


            --
            "Oh, no! NOT the Spanish Inquisition!"
            "NOBODY expects the Spanish Inquisition!!!"
            -- Monty Python sketch --
            "Oh, no! NOT another option!"
            "EVERYBODY expects another option!!!"
            -- Discussion in vim-dev mailing list --

            /// Bram Moolenaar -- Bram@... -- http://www.Moolenaar.net \\\
            /// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
            \\\ an exciting new programming language -- http://www.Zimbu.org ///
            \\\ help me help AIDS victims -- http://ICCF-Holland.org ///

            --
            --
            You received this message from the "vim_dev" maillist.
            Do not top-post! Type your reply below the text you are replying to.
            For more information, visit http://www.vim.org/maillist.php

            ---
            You received this message because you are subscribed to the Google Groups "vim_dev" group.
            To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscribe@....
            For more options, visit https://groups.google.com/d/optout.
          • Ken Takata
            Hi Bram and Ben, ... Yes, I checked that make reconfig does clean first then it runs configure. ... Please check this thread:
            Message 5 of 5 , Apr 10, 2014
            • 0 Attachment
              Hi Bram and Ben,

              2014/4/11 Fri 3:01:14 UTC+9 Bram Moolenaar wrote:
              > Ken Takata wrote:
              >
              > > 2014/3/25 Tue 23:35:23 UTC+9 Bram Moolenaar wrote:
              > > > Patch 7.4.217
              > > > Problem: When src/auto/configure was updated, "make clean" would run
              > > > configure pointlessly.
              > > > Solution: Do not run configure for "make clean" and "make distclean" when
              > > > the make program supports $MAKECMDGOALS. (Ken Takata)
              > > > Files: src/Makefile
              > >
              > > Now I think that it's better to skip running configure also for
              > > "make autoconf" and "make reconfig".
              >
              > Makes sense. Have you checked that "make reconfig" does run configure
              > after cleaning?

              Yes, I checked that "make reconfig" does clean first then it runs configure.


              To Ben:

              > Isn't running configure half the point of making those two targets? Or am I missing something?

              Please check this thread:
              https://groups.google.com/d/topic/vim_dev/AfB7WtiF9Z0/discussion

              When auto/configure is updated, "make reconfig" will run configure twice
              without my patch.
              A similar thing happens for "make autoconf". When auto/configure is updated,
              "make autoconf" will run configure. Of course "make autoconf" updates
              auto/configure after that. It means that every time running "make autoconf",
              it will run configure every time!

              Regards,
              Ken Takata

              --
              --
              You received this message from the "vim_dev" maillist.
              Do not top-post! Type your reply below the text you are replying to.
              For more information, visit http://www.vim.org/maillist.php

              ---
              You received this message because you are subscribed to the Google Groups "vim_dev" group.
              To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscribe@....
              For more options, visit https://groups.google.com/d/optout.
            Your message has been successfully submitted and would be delivered to recipients shortly.