Loading ...
Sorry, an error occurred while loading the content.

[PATCH] Issue 125: does not show up when showcmd is set.

Expand Messages
  • Brook Hong
    I d also like to use as leader key, as the issue reporter. https://code.google.com/p/vim/issues/detail?id=125 diff --git a/src/normal.c b/src/normal.c
    Message 1 of 3 , Dec 4, 2013
    • 0 Attachment
      I'd also like to use <Space> as leader key, as the issue reporter.
      https://code.google.com/p/vim/issues/detail?id=125

      diff --git a/src/normal.c b/src/normal.c
      index 013fdce..cb092a0 100644
      --- a/src/normal.c
      +++ b/src/normal.c
      @@ -4021,6 +4021,9 @@ add_to_showcmd(c)
      #endif

      p = transchar(c);
      + if(p[0] == ' ') {
      + STRCPY(p, "SPACE");
      + }
      old_len = (int)STRLEN(showcmd_buf);
      extra_len = (int)STRLEN(p);
      overflow = old_len + extra_len - SHOWCMD_COLS

      --
      --
      You received this message from the "vim_dev" maillist.
      Do not top-post! Type your reply below the text you are replying to.
      For more information, visit http://www.vim.org/maillist.php

      ---
      You received this message because you are subscribed to the Google Groups "vim_dev" group.
      To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscribe@....
      For more options, visit https://groups.google.com/groups/opt_out.
    • Bram Moolenaar
      ... Thanks. SPACE is a bit long, I think SPC will do. -- If Pacman had affected us as kids we d be running around in dark rooms, munching pills and listening
      Message 2 of 3 , Dec 6, 2013
      • 0 Attachment
        Brook Hong wrote:

        > I'd also like to use <Space> as leader key, as the issue reporter.
        > https://code.google.com/p/vim/issues/detail?id=125
        >
        > diff --git a/src/normal.c b/src/normal.c
        > index 013fdce..cb092a0 100644
        > --- a/src/normal.c
        > +++ b/src/normal.c
        > @@ -4021,6 +4021,9 @@ add_to_showcmd(c)
        > #endif
        >
        > p = transchar(c);
        > + if(p[0] == ' ') {
        > + STRCPY(p, "SPACE");
        > + }
        > old_len = (int)STRLEN(showcmd_buf);
        > extra_len = (int)STRLEN(p);
        > overflow = old_len + extra_len - SHOWCMD_COLS

        Thanks. SPACE is a bit long, I think SPC will do.

        --
        If Pacman had affected us as kids we'd be running around in dark rooms,
        munching pills and listening to repetitive music.
        -- Marcus Brigstocke

        /// Bram Moolenaar -- Bram@... -- http://www.Moolenaar.net \\\
        /// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
        \\\ an exciting new programming language -- http://www.Zimbu.org ///
        \\\ help me help AIDS victims -- http://ICCF-Holland.org ///

        --
        --
        You received this message from the "vim_dev" maillist.
        Do not top-post! Type your reply below the text you are replying to.
        For more information, visit http://www.vim.org/maillist.php

        ---
        You received this message because you are subscribed to the Google Groups "vim_dev" group.
        To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscribe@....
        For more options, visit https://groups.google.com/groups/opt_out.
      • ZyX
        ... I think you should use one of the existing notations: ` ` like for mappings (too long) or ` ` like for invalid unicode. I would prefer the latter
        Message 3 of 3 , Dec 6, 2013
        • 0 Attachment
          On Thursday, December 5, 2013 6:19:25 AM UTC+4, Brook Hong wrote:
          > I'd also like to use <Space> as leader key, as the issue reporter.
          > https://code.google.com/p/vim/issues/detail?id=125
          >
          > diff --git a/src/normal.c b/src/normal.c
          > index 013fdce..cb092a0 100644
          > --- a/src/normal.c
          > +++ b/src/normal.c
          > @@ -4021,6 +4021,9 @@ add_to_showcmd(c)
          > #endif
          >
          > p = transchar(c);
          > + if(p[0] == ' ') {
          > + STRCPY(p, "SPACE");
          > + }
          > old_len = (int)STRLEN(showcmd_buf);
          > extra_len = (int)STRLEN(p);
          > overflow = old_len + extra_len - SHOWCMD_COLS

          I think you should use one of the existing notations: `<Space>` like for mappings (too long) or `<20>` like for invalid unicode. I would prefer the latter as it is shorter.

          --
          --
          You received this message from the "vim_dev" maillist.
          Do not top-post! Type your reply below the text you are replying to.
          For more information, visit http://www.vim.org/maillist.php

          ---
          You received this message because you are subscribed to the Google Groups "vim_dev" group.
          To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscribe@....
          For more options, visit https://groups.google.com/groups/opt_out.
        Your message has been successfully submitted and would be delivered to recipients shortly.