Loading ...
Sorry, an error occurred while loading the content.

[patch] Should we use vimLoadLib() in if_tcl.c?

Expand Messages
  • Ken Takata
    Hi, I think vimLoadLib() is used because of security reason, but LoadLibraryEx() is used directly in if_tcl.c. Should we use vimLoadLib() in if_tcl.c? ... +++
    Message 1 of 2 , Jul 29, 2013
    • 0 Attachment
      Hi,

      I think vimLoadLib() is used because of security reason,
      but LoadLibraryEx() is used directly in if_tcl.c.
      Should we use vimLoadLib() in if_tcl.c?

      --- a/src/if_tcl.c
      +++ b/src/if_tcl.c
      @@ -195,7 +195,7 @@

      if (hTclLib)
      return OK;
      - if (!(hTclLib = LoadLibraryEx(libname, NULL, 0)))
      + if (!(hTclLib = vimLoadLib(libname)))
      {
      if (verbose)
      EMSG2(_(e_loadlib), libname);

      Actually I haven't tested this patch yet.

      Regards,
      Ken Takata

      --
      --
      You received this message from the "vim_dev" maillist.
      Do not top-post! Type your reply below the text you are replying to.
      For more information, visit http://www.vim.org/maillist.php

      ---
      You received this message because you are subscribed to the Google Groups "vim_dev" group.
      To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscribe@....
      For more options, visit https://groups.google.com/groups/opt_out.
    • Ken Takata
      Hi, ... I have tested this patch with ActiveTcl 8.5. It works fine. Regards, Ken Takata -- -- You received this message from the vim_dev maillist. Do not
      Message 2 of 2 , Jul 30, 2013
      • 0 Attachment
        Hi,

        2013/07/29 Mon 21:53:51 UTC+9 Ken Takata wrote:
        > I think vimLoadLib() is used because of security reason,
        > but LoadLibraryEx() is used directly in if_tcl.c.
        > Should we use vimLoadLib() in if_tcl.c?
        >
        > --- a/src/if_tcl.c
        > +++ b/src/if_tcl.c
        > @@ -195,7 +195,7 @@
        >
        > if (hTclLib)
        > return OK;
        > - if (!(hTclLib = LoadLibraryEx(libname, NULL, 0)))
        > + if (!(hTclLib = vimLoadLib(libname)))
        > {
        > if (verbose)
        > EMSG2(_(e_loadlib), libname);
        >
        > Actually I haven't tested this patch yet.

        I have tested this patch with ActiveTcl 8.5.
        It works fine.

        Regards,
        Ken Takata

        --
        --
        You received this message from the "vim_dev" maillist.
        Do not top-post! Type your reply below the text you are replying to.
        For more information, visit http://www.vim.org/maillist.php

        ---
        You received this message because you are subscribed to the Google Groups "vim_dev" group.
        To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscribe@....
        For more options, visit https://groups.google.com/groups/opt_out.
      Your message has been successfully submitted and would be delivered to recipients shortly.