Loading ...
Sorry, an error occurred while loading the content.

[patch] patch number in :intro is zero-suppressed

Expand Messages
  • Ken Takata
    Hi, Vim s patch number is normally three-digit and zero-padded. (e.g. 7.4a.009) But when I see the result of :intro, it is zero-suppressed. (e.g. version
    Message 1 of 2 , Jul 10, 2013
    • 0 Attachment
      Hi,

      Vim's patch number is normally three-digit and zero-padded. (e.g. 7.4a.009)
      But when I see the result of :intro, it is zero-suppressed.
      (e.g. version 7.4a.9 BETA) Is this intended?
      I think it's better to use same representation.

      --- a/src/version.c
      +++ b/src/version.c
      @@ -1392,11 +1392,11 @@
      if (isalpha((int)vers[3]))
      {
      int len = (isalpha((int)vers[4])) ? 5 : 4;
      - sprintf((char *)vers + len, ".%d%s", highest_patch(),
      + sprintf((char *)vers + len, ".%03d%s", highest_patch(),
      mediumVersion + len);
      }
      else
      - sprintf((char *)vers + 3, ".%d", highest_patch());
      + sprintf((char *)vers + 3, ".%03d", highest_patch());
      }
      col += (int)STRLEN(vers);
      }


      Regards,
      Ken Takata

      --
      --
      You received this message from the "vim_dev" maillist.
      Do not top-post! Type your reply below the text you are replying to.
      For more information, visit http://www.vim.org/maillist.php

      ---
      You received this message because you are subscribed to the Google Groups "vim_dev" group.
      To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscribe@....
      For more options, visit https://groups.google.com/groups/opt_out.
    • Bram Moolenaar
      ... Well, applying the shorter is better rule: let s keep it as it is. -- Wi n0t trei a h0liday in Sweden thi yer? Monty Python and the Holy Grail PYTHON
      Message 2 of 2 , Jul 10, 2013
      • 0 Attachment
        Ken Takata wrote:

        > Vim's patch number is normally three-digit and zero-padded. (e.g. 7.4a.009)
        > But when I see the result of :intro, it is zero-suppressed.
        > (e.g. version 7.4a.9 BETA) Is this intended?
        > I think it's better to use same representation.

        Well, applying the "shorter is better" rule: let's keep it as it is.

        --
        Wi n0t trei a h0liday in Sweden thi yer?
        "Monty Python and the Holy Grail" PYTHON (MONTY) PICTURES LTD

        /// Bram Moolenaar -- Bram@... -- http://www.Moolenaar.net \\\
        /// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
        \\\ an exciting new programming language -- http://www.Zimbu.org ///
        \\\ help me help AIDS victims -- http://ICCF-Holland.org ///

        --
        --
        You received this message from the "vim_dev" maillist.
        Do not top-post! Type your reply below the text you are replying to.
        For more information, visit http://www.vim.org/maillist.php

        ---
        You received this message because you are subscribed to the Google Groups "vim_dev" group.
        To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscribe@....
        For more options, visit https://groups.google.com/groups/opt_out.
      Your message has been successfully submitted and would be delivered to recipients shortly.