Loading ...
Sorry, an error occurred while loading the content.

Re: Patch 7.3.1247 valgrind errors (Was: Patch 7.3.1247)

Expand Messages
  • Simon Ruderich
    ... Ah, sorry. Forgot to mention that. It was test64. Regards Simon -- + privacy is necessary + using gnupg http://gnupg.org + public key id:
    Message 1 of 6 , Jun 30, 2013
    • 0 Attachment
      On Sun, Jun 30, 2013 at 08:19:05PM +0200, Dominique Pellé wrote:
      > I see that running "make test" with valgrind
      > detects the bug in test 64 using vim-7.3.1278:

      Ah, sorry. Forgot to mention that. It was test64.

      Regards
      Simon
      --
      + privacy is necessary
      + using gnupg http://gnupg.org
      + public key id: 0x92FEFDB7E44C32F9
    • Bram Moolenaar
      ... [...] I can reproduce it with test 64, as Dominique suggested. -- A poem: read aloud: !* # Waka waka bang splat tick tick
      Message 2 of 6 , Jun 30, 2013
      • 0 Attachment
        Simon Ruderich wrote:

        > On Wed, Jun 26, 2013 at 06:17:24PM +0200, Bram Moolenaar wrote:
        > > Patch 7.3.1247
        > > Problem: New regexp engine: '[ ]\@!\p\%([ ]\@!\p\)*:' does not always match.
        > > Solution: When there is a PIM add a duplicate state that starts at another
        > > position.
        > > Files: src/regexp_nfa.c, src/testdir/test64.in, src/testdir/test64.ok
        >
        > Since this patch, valgrind reports the following errors (compiled
        > with patch 7.3.1278):
        >
        > Invalid read of size 4
        > at 0x4EEB40: copy_sub (in src/vim)
        > by 0x4EF70E: addstate (in src/vim)
        > by 0x4EF866: addstate (in src/vim)
        > by 0x4EFC75: addstate_here (in src/vim)
        > by 0x4FC6D9: nfa_regmatch (in src/vim)
        > by 0x501402: nfa_regtry (in src/vim)

        [...]

        I can reproduce it with test 64, as Dominique suggested.

        --
        A poem: read aloud:

        <> !*''# Waka waka bang splat tick tick hash,
        ^"`$$- Caret quote back-tick dollar dollar dash,
        !*=@$_ Bang splat equal at dollar under-score,
        %*<> ~#4 Percent splat waka waka tilde number four,
        &[]../ Ampersand bracket bracket dot dot slash,
        |{,,SYSTEM HALTED Vertical-bar curly-bracket comma comma CRASH.

        Fred Bremmer and Steve Kroese (Calvin College & Seminary of Grand Rapids, MI.)

        /// Bram Moolenaar -- Bram@... -- http://www.Moolenaar.net \\\
        /// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
        \\\ an exciting new programming language -- http://www.Zimbu.org ///
        \\\ help me help AIDS victims -- http://ICCF-Holland.org ///

        --
        --
        You received this message from the "vim_dev" maillist.
        Do not top-post! Type your reply below the text you are replying to.
        For more information, visit http://www.vim.org/maillist.php

        ---
        You received this message because you are subscribed to the Google Groups "vim_dev" group.
        To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscribe@....
        For more options, visit https://groups.google.com/groups/opt_out.
      Your message has been successfully submitted and would be delivered to recipients shortly.