Loading ...
Sorry, an error occurred while loading the content.

Re: [patch] Fix crash in console Cygwin Vim, remove compilation warnings

Expand Messages
  • Lech Lorens
    On 27-Jun-2013 Lech Lorens wrote: […] Actually attaching the patch. -- Cheers, Lech -- -- You received this message from the
    Message 1 of 4 , Jun 27, 2013
    • 0 Attachment
      On 27-Jun-2013 Lech Lorens <lech.lorens@...> wrote:
      […]

      Actually attaching the patch.

      --
      Cheers,
      Lech

      --
      --
      You received this message from the "vim_dev" maillist.
      Do not top-post! Type your reply below the text you are replying to.
      For more information, visit http://www.vim.org/maillist.php

      ---
      You received this message because you are subscribed to the Google Groups "vim_dev" group.
      To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscribe@....
      For more options, visit https://groups.google.com/groups/opt_out.
    • Yegappan Lakshmanan
      Hi, ... I can still reproduce the crash with your patch. Vim crashes with the following traceback: #0 0x00219fb9 in free () from /lib/tls/libc.so.6 #1
      Message 2 of 4 , Jun 28, 2013
      • 0 Attachment
        Hi,

        On Thu, Jun 27, 2013 at 2:00 PM, Lech Lorens <lech.lorens@...> wrote:
        > I finally managed to find the source of the crashes I've been
        > experiencing in console Cygwin Vim. The attached patch fixes the problem
        > (not checking the result of XmbTextListToTextProperty() call) as well as
        > removes some compilation warnings on Cygwin.
        >
        > I wonder if this might be related to what Yegappan reported in "Vim
        > crashes when selecting more than 262040 characters" on April 12th.
        >

        I can still reproduce the crash with your patch. Vim crashes with the following
        traceback:

        #0 0x00219fb9 in free () from /lib/tls/libc.so.6
        #1 0x006d73a3 in XtFree () from /usr/X11R6/lib/libXt.so.6
        #2 0x006f8502 in XtAppGetSelectionTimeout () from /usr/X11R6/lib/libXt.so.6
        #3 0x006f2144 in _XtRemoveAllInputs () from /usr/X11R6/lib/libXt.so.6
        #4 0x006f24b2 in XtAppNextEvent () from /usr/X11R6/lib/libXt.so.6
        #5 0x0813af5c in xterm_update () at os_unix.c:6938
        #6 0x081394dd in RealWaitForChar (fd=0, msec=0, check_for_gpm=0x0) at
        os_unix.c:5299
        #7 0x081392c8 in mch_breakcheck () at os_unix.c:4946
        #8 0x080dda61 in vgetorpeek (advance=1) at getchar.c:2027
        #9 0x080dc224 in vgetc () at getchar.c:1590
        #10 0x080dc69f in safe_vgetc () at getchar.c:1795
        #11 0x08115560 in normal_cmd (oap=0xbfffa350, toplevel=1) at normal.c:666
        #12 0x081c19fe in main_loop (cmdwin=0, noexmode=0) at main.c:1329
        #13 0x081c11d0 in main (argc=0, argv=0x0) at main.c:1020


        Thanks,
        Yegappan

        >
        > I wonder if there are more places where invalid locale setting will
        > cause such problems.
        >
        > Here's how to reproduce:
        > 1. start a Cygwin X server,
        > 2. start a terminal emulator (mintty in my case; haven't checked in
        > Xterm) and set locale there to something invalid (in my case at some
        > point LC_ALL=C.utf8 started to be incorrect but I never bothered to
        > change it),
        > 3. in the terminal start Vim and make sure that it connects to the
        > X server (we will be using the clipboard),
        > 4. enter some text, enter the visual mode and more some of the text,
        > 5. open MS Notepad and press Ctrl-V (paste),
        > 6. your console Vim has just crashed.
        >
        > --
        > Lech Lorens
        >
        > --
        > --
        > You received this message from the "vim_dev" maillist.
        > Do not top-post! Type your reply below the text you are replying to.
        > For more information, visit http://www.vim.org/maillist.php
        >
        > ---
        > You received this message because you are subscribed to the Google Groups "vim_dev" group.
        > To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscribe@....
        > For more options, visit https://groups.google.com/groups/opt_out.
        >
        >

        --
        --
        You received this message from the "vim_dev" maillist.
        Do not top-post! Type your reply below the text you are replying to.
        For more information, visit http://www.vim.org/maillist.php

        ---
        You received this message because you are subscribed to the Google Groups "vim_dev" group.
        To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscribe@....
        For more options, visit https://groups.google.com/groups/opt_out.
      • Bram Moolenaar
        ... Thanks, I ll include the patch. -- ARTHUR: Will you ask your master if he wants to join my court at Camelot?! GUARD #1: But then of course African
        Message 3 of 4 , Jun 29, 2013
        • 0 Attachment
          Lech Lorens wrote:

          > I finally managed to find the source of the crashes I've been
          > experiencing in console Cygwin Vim. The attached patch fixes the problem
          > (not checking the result of XmbTextListToTextProperty() call) as well as
          > removes some compilation warnings on Cygwin.
          >
          > I wonder if this might be related to what Yegappan reported in "Vim
          > crashes when selecting more than 262040 characters" on April 12th.
          > I wonder if there are more places where invalid locale setting will
          > cause such problems.
          >
          > Here's how to reproduce:
          > 1. start a Cygwin X server,
          > 2. start a terminal emulator (mintty in my case; haven't checked in
          > Xterm) and set locale there to something invalid (in my case at some
          > point LC_ALL=C.utf8 started to be incorrect but I never bothered to
          > change it),
          > 3. in the terminal start Vim and make sure that it connects to the
          > X server (we will be using the clipboard),
          > 4. enter some text, enter the visual mode and more some of the text,
          > 5. open MS Notepad and press Ctrl-V (paste),
          > 6. your console Vim has just crashed.

          Thanks, I'll include the patch.

          --
          ARTHUR: Will you ask your master if he wants to join my court at Camelot?!
          GUARD #1: But then of course African swallows are not migratory.
          GUARD #2: Oh, yeah...
          GUARD #1: So they couldn't bring a coconut back anyway...
          The Quest for the Holy Grail (Monty Python)

          /// Bram Moolenaar -- Bram@... -- http://www.Moolenaar.net \\\
          /// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
          \\\ an exciting new programming language -- http://www.Zimbu.org ///
          \\\ help me help AIDS victims -- http://ICCF-Holland.org ///

          --
          --
          You received this message from the "vim_dev" maillist.
          Do not top-post! Type your reply below the text you are replying to.
          For more information, visit http://www.vim.org/maillist.php

          ---
          You received this message because you are subscribed to the Google Groups "vim_dev" group.
          To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscribe@....
          For more options, visit https://groups.google.com/groups/opt_out.
        Your message has been successfully submitted and would be delivered to recipients shortly.