Loading ...
Sorry, an error occurred while loading the content.

Incorrect highlighting with re=1 introduced by 7.3.1191

Expand Messages
  • Dominique Pellé
    Hi These 2 commands which only differ by using re=1 or re=2 do not highlight the same text. It s correct with re=2 and incorrect with re=1 (with re=1, the
    Message 1 of 5 , Jun 14, 2013
    • 0 Attachment
      Hi

      These 2 commands which only differ by using re=1 or re=2
      do not highlight the same text. It's correct with re=2 and
      incorrect with re=1 (with re=1, the second line is not
      entirely highlighted, but it should be):

      $ vim -u NONE --noplugin -N -c 'set hls re=1' \
      -c 'call feedkeys("aaaa\<cr>aaa\<cr>bbb\<cr>\<esc>/^.\\(.\\).\\_..\\1.\<cr>")'

      $ vim -u NONE --noplugin -N -c 'set hls re=2' \
      -c 'call feedkeys("aaaa\<cr>aaa\<cr>bbb\<cr>\<esc>/^.\\(.\\).\\_..\\1.\<cr>")'

      It was fine in vim-7.3.1190 and the regression
      started in 7.3.1191. It's also broken in the latest
      vim-7.3.1195.

      Regards
      Dominique

      --
      --
      You received this message from the "vim_dev" maillist.
      Do not top-post! Type your reply below the text you are replying to.
      For more information, visit http://www.vim.org/maillist.php

      ---
      You received this message because you are subscribed to the Google Groups "vim_dev" group.
      To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscribe@....
      For more options, visit https://groups.google.com/groups/opt_out.
    • Bram Moolenaar
      ... Thanks for reporting. It s easy to fix, but this shows multi-line patterns need more testing, also with the old engine. -- hundred-and-one symptoms of
      Message 2 of 5 , Jun 15, 2013
      • 0 Attachment
        Dominique Pelle wrote:

        > These 2 commands which only differ by using re=1 or re=2
        > do not highlight the same text. It's correct with re=2 and
        > incorrect with re=1 (with re=1, the second line is not
        > entirely highlighted, but it should be):
        >
        > $ vim -u NONE --noplugin -N -c 'set hls re=1' \
        > -c 'call feedkeys("aaaa\<cr>aaa\<cr>bbb\<cr>\<esc>/^.\\(.\\).\\_..\\1.\<cr>")'
        >
        > $ vim -u NONE --noplugin -N -c 'set hls re=2' \
        > -c 'call feedkeys("aaaa\<cr>aaa\<cr>bbb\<cr>\<esc>/^.\\(.\\).\\_..\\1.\<cr>")'
        >
        > It was fine in vim-7.3.1190 and the regression
        > started in 7.3.1191. It's also broken in the latest
        > vim-7.3.1195.

        Thanks for reporting. It's easy to fix, but this shows multi-line
        patterns need more testing, also with the old engine.

        --
        hundred-and-one symptoms of being an internet addict:
        212. Your Internet group window has more icons than your Accessories window.

        /// Bram Moolenaar -- Bram@... -- http://www.Moolenaar.net \\\
        /// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
        \\\ an exciting new programming language -- http://www.Zimbu.org ///
        \\\ help me help AIDS victims -- http://ICCF-Holland.org ///

        --
        --
        You received this message from the "vim_dev" maillist.
        Do not top-post! Type your reply below the text you are replying to.
        For more information, visit http://www.vim.org/maillist.php

        ---
        You received this message because you are subscribed to the Google Groups "vim_dev" group.
        To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscribe@....
        For more options, visit https://groups.google.com/groups/opt_out.
      • Manuel Ortega
        On Fri, Jun 14, 2013 at 5:20 PM, Dominique Pellé ... Wow, the first of those commands (with re=1) causes MacVim to segfault! (OS X 10.8.4, MacVim 7.3.1193)
        Message 3 of 5 , Jun 15, 2013
        • 0 Attachment
          On Fri, Jun 14, 2013 at 5:20 PM, Dominique Pellé <dominique.pelle@...> wrote:
          Hi

          These 2 commands which only differ by using re=1 or re=2
          do not highlight the same text.  It's correct with re=2 and
          incorrect with re=1  (with re=1, the second line is not
          entirely highlighted, but it should be):

          $ vim -u NONE --noplugin -N -c 'set hls re=1' \
            -c 'call feedkeys("aaaa\<cr>aaa\<cr>bbb\<cr>\<esc>/^.\\(.\\).\\_..\\1.\<cr>")'

          $ vim -u NONE --noplugin -N -c 'set hls re=2' \
            -c 'call feedkeys("aaaa\<cr>aaa\<cr>bbb\<cr>\<esc>/^.\\(.\\).\\_..\\1.\<cr>")'

          It was fine in vim-7.3.1190 and the regression
          started in 7.3.1191. It's also broken in the latest
          vim-7.3.1195.


          Wow, the first of those commands (with re=1) causes MacVim to segfault!  (OS X 10.8.4, MacVim 7.3.1193)

          Vim: Caught deadly signal SEGV
          Vim: preserving files...
          Vim: Finished.
          Segmentation fault: 11

          That happens whether I call MacVim in the console or with the GUI. (When I call the GUI, the terminal output only shows "Vim: Finished", and the GUI launch fails).

          The second command (re=2) works fine in MacVim.  Also, both commands work fine (i.e., don't cause a segfault) on Vim built from the repo.

          -Manny

          --
          --
          You received this message from the "vim_dev" maillist.
          Do not top-post! Type your reply below the text you are replying to.
          For more information, visit http://www.vim.org/maillist.php
           
          ---
          You received this message because you are subscribed to the Google Groups "vim_dev" group.
          To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscribe@....
          For more options, visit https://groups.google.com/groups/opt_out.
           
           
        • Manuel Ortega
          ... If it helps to diagnose things, each attempt at running the re=1 command in MacVim left its own swapfile behind, and none of them were deleted: .swi, .swj,
          Message 4 of 5 , Jun 15, 2013
          • 0 Attachment
            On Sat, Jun 15, 2013 at 10:14 AM, Manuel Ortega <mannyvimdev@...> wrote:
            On Fri, Jun 14, 2013 at 5:20 PM, Dominique Pellé <dominique.pelle@...> wrote:
            Hi

            These 2 commands which only differ by using re=1 or re=2
            do not highlight the same text.  It's correct with re=2 and
            incorrect with re=1  (with re=1, the second line is not
            entirely highlighted, but it should be):

            $ vim -u NONE --noplugin -N -c 'set hls re=1' \
              -c 'call feedkeys("aaaa\<cr>aaa\<cr>bbb\<cr>\<esc>/^.\\(.\\).\\_..\\1.\<cr>")'

            $ vim -u NONE --noplugin -N -c 'set hls re=2' \
              -c 'call feedkeys("aaaa\<cr>aaa\<cr>bbb\<cr>\<esc>/^.\\(.\\).\\_..\\1.\<cr>")'

            It was fine in vim-7.3.1190 and the regression
            started in 7.3.1191. It's also broken in the latest
            vim-7.3.1195.


            Wow, the first of those commands (with re=1) causes MacVim to segfault!  (OS X 10.8.4, MacVim 7.3.1193)

            Vim: Caught deadly signal SEGV
            Vim: preserving files...
            Vim: Finished.
            Segmentation fault: 11

            That happens whether I call MacVim in the console or with the GUI. (When I call the GUI, the terminal output only shows "Vim: Finished", and the GUI launch fails).

            The second command (re=2) works fine in MacVim.  Also, both commands work fine (i.e., don't cause a segfault) on Vim built from the repo.

            If it helps to diagnose things, each attempt at running the re=1 command in MacVim left its own swapfile behind, and none of them were deleted: .swi, .swj, .swk, etc., all the way down to .swp.

            -Manny 

            --
            --
            You received this message from the "vim_dev" maillist.
            Do not top-post! Type your reply below the text you are replying to.
            For more information, visit http://www.vim.org/maillist.php
             
            ---
            You received this message because you are subscribed to the Google Groups "vim_dev" group.
            To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscribe@....
            For more options, visit https://groups.google.com/groups/opt_out.
             
             
          • Dominique Pellé
            ... You re using and old version of Vim (7.3.1193) The crash with re=1 is already fixed in Vim-7.3.1195. Vim-7.3.1196 also fixes the extent of what should be
            Message 5 of 5 , Jun 15, 2013
            • 0 Attachment
              Manuel Ortega <mannyvimdev@...> wrote:

              > On Sat, Jun 15, 2013 at 10:14 AM, Manuel Ortega <mannyvimdev@...>
              > wrote:
              >>
              >> On Fri, Jun 14, 2013 at 5:20 PM, Dominique Pellé
              >> <dominique.pelle@...> wrote:
              >>>
              >>> Hi
              >>>
              >>> These 2 commands which only differ by using re=1 or re=2
              >>> do not highlight the same text. It's correct with re=2 and
              >>> incorrect with re=1 (with re=1, the second line is not
              >>> entirely highlighted, but it should be):
              >>>
              >>> $ vim -u NONE --noplugin -N -c 'set hls re=1' \
              >>> -c 'call
              >>> feedkeys("aaaa\<cr>aaa\<cr>bbb\<cr>\<esc>/^.\\(.\\).\\_..\\1.\<cr>")'
              >>>
              >>> $ vim -u NONE --noplugin -N -c 'set hls re=2' \
              >>> -c 'call
              >>> feedkeys("aaaa\<cr>aaa\<cr>bbb\<cr>\<esc>/^.\\(.\\).\\_..\\1.\<cr>")'
              >>>
              >>> It was fine in vim-7.3.1190 and the regression
              >>> started in 7.3.1191. It's also broken in the latest
              >>> vim-7.3.1195.
              >>>
              >>
              >> Wow, the first of those commands (with re=1) causes MacVim to segfault!
              >> (OS X 10.8.4, MacVim 7.3.1193)
              >>
              >> Vim: Caught deadly signal SEGV
              >> Vim: preserving files...
              >> Vim: Finished.
              >> Segmentation fault: 11
              >>
              >> That happens whether I call MacVim in the console or with the GUI. (When I
              >> call the GUI, the terminal output only shows "Vim: Finished", and the GUI
              >> launch fails).
              >>
              >> The second command (re=2) works fine in MacVim. Also, both commands work
              >> fine (i.e., don't cause a segfault) on Vim built from the repo.
              >
              >
              > If it helps to diagnose things, each attempt at running the re=1 command in
              > MacVim left its own swapfile behind, and none of them were deleted: .swi,
              > .swj, .swk, etc., all the way down to .swp.
              >
              > -Manny


              You're using and "old" version of Vim (7.3.1193)

              The crash with re=1 is already fixed in Vim-7.3.1195.
              Vim-7.3.1196 also fixes the extent of what should
              be highlighted with re=1.

              As far as I know, it's all fine with the latest Vim-7.3.1196.

              Dominique

              --
              --
              You received this message from the "vim_dev" maillist.
              Do not top-post! Type your reply below the text you are replying to.
              For more information, visit http://www.vim.org/maillist.php

              ---
              You received this message because you are subscribed to the Google Groups "vim_dev" group.
              To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscribe@....
              For more options, visit https://groups.google.com/groups/opt_out.
            Your message has been successfully submitted and would be delivered to recipients shortly.