Loading ...
Sorry, an error occurred while loading the content.

Re: [PATCH] (3/3) _vim_runtimepath_ special directory and some small stuff

Expand Messages
  • Jun T.
    ... (snip) ... I m getting the same error (python2.7.3 and python 3.2.3). It seems the tests are failing when they try to import module . The module module
    Message 1 of 26 , Jun 12, 2013
    • 0 Attachment
      On 2013/06/12, at 21:41, Bram Moolenaar <Bram@...> wrote:
      > Thanks for the updates. Unfortunately, now both test 86 and 87 fail for
      > me.
      (snip)
      > -2,xx
      > -before
      > -after

      I'm getting the same error (python2.7.3 and python 3.2.3).

      It seems the tests are failing when they try to 'import module'.
      The module 'module' is in testdir/python{2,3}/module.py, which
      in turn imports a module named 'before_1'.

      Where is this module 'before_1' ?

      In addition, if I configure --with-python3interp=dynamic,
      test87 core dumps.
      This core dump can be fixed by the following patch:


      diff -r 8a49630c8a5f src/if_python3.c
      --- a/src/if_python3.c Wed Jun 12 22:41:37 2013 +0200
      +++ b/src/if_python3.c Thu Jun 13 12:25:31 2013 +0900
      @@ -488,7 +488,7 @@
      {"PyEval_InitThreads", (PYTHON_PROC*)&py3_PyEval_InitThreads},
      {"PyEval_RestoreThread", (PYTHON_PROC*)&py3_PyEval_RestoreThread},
      {"PyEval_SaveThread", (PYTHON_PROC*)&py3_PyEval_SaveThread},
      - {"PyArg_Parse", (PYTHON_PROC*)&py3_PyArg_Parse},
      + {"_PyArg_Parse_SizeT", (PYTHON_PROC*)&py3_PyArg_Parse},
      {"Py_IsInitialized", (PYTHON_PROC*)&py3_Py_IsInitialized},
      {"_PyObject_NextNotImplemented", (PYTHON_PROC*)&py3__PyObject_NextNotImplemented},
      {"_Py_NoneStruct", (PYTHON_PROC*)&py3__Py_NoneStruct},



      Note:
      Since PY_SSIZE_T_CLEAN is unconditionally defined in if_python3.c
      (and I think it is correct), the following part in if_python3.c
      (line 428) may be simplified to always use ssize_t-clean version.

      # ifndef PY_SSIZE_T_CLEAN
      {"PyArg_ParseTuple", (PYTHON_PROC*)&py3_PyArg_ParseTuple},
      {"Py_BuildValue", (PYTHON_PROC*)&py3_Py_BuildValue},
      # else
      {"_PyArg_ParseTuple_SizeT", (PYTHON_PROC*)&py3_PyArg_ParseTuple},
      {"_Py_BuildValue_SizeT", (PYTHON_PROC*)&py3_Py_BuildValue},
      # endif


      --
      --
      You received this message from the "vim_dev" maillist.
      Do not top-post! Type your reply below the text you are replying to.
      For more information, visit http://www.vim.org/maillist.php

      ---
      You received this message because you are subscribed to the Google Groups "vim_dev" group.
      To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscribe@....
      For more options, visit https://groups.google.com/groups/opt_out.
    • Bram Moolenaar
      ... For test 86: Messages maintainer: Bram Moolenaar E325: ATTENTION test86.in 1124 lines, 30296 characters Xdotest [New File] 1113 lines,
      Message 2 of 26 , Jun 13, 2013
      • 0 Attachment
        ZyX wrote:

        > > > # HG changeset patch
        > > > # User ZyX <kp-pav@...>
        > > > # Date 1371036594 -14400
        > > > # Wed Jun 12 15:29:54 2013 +0400
        > > > # Branch python-path
        > > > # Node ID 27aa091d5fa525fd4ba97b4b68dc62e64e8bd3a0
        > > > # Parent 643f64bbd9386d746313a7678cfa08826b4a5122
        > > > Use the same method for python3 as for python2
        > >
        > > Thanks for the updates. Unfortunately, now both test 86 and 87 fail for
        > > me. Previously only test 86 was failing.
        > >
        > > python --version
        > > Python 2.7.3
        > >
        > > python3 --version
        > > Python 3.2.3
        > >
        > > % diff -u testdir/test86.ok testdir/test86.failed
        > > --- testdir/test86.ok 2013-06-12 14:21:28.000000000 +0200
        > > +++ testdir/test86.failed 2013-06-12 14:38:10.000000000 +0200
        > > @@ -1083,9 +1083,6 @@
        > > vim.current.window = True:TypeError:('expected vim.Window object',)
        > > vim.current.tabpage = True:TypeError:('expected vim.TabPage object',)
        > > vim.current.xxx = True:AttributeError:('xxx',)
        > > -2,xx
        > > -before
        > > -after
        > > vim.command("throw 'abc'"):error:('abc',)
        > > Exe("throw 'def'"):error:('def',)
        > > vim.eval("Exe('throw ''ghi''')"):error:('ghi',)
        > >
        > > % diff -u testdir/test87.ok testdir/test87.failed
        > > --- testdir/test87.ok 2013-06-12 14:12:13.000000000 +0200
        > > +++ testdir/test87.failed 2013-06-12 14:38:13.000000000 +0200
        > > @@ -1092,9 +1092,6 @@
        > > vim.current.window = True:(<class 'TypeError'>, TypeError('expected vim.Window object',))
        > > vim.current.tabpage = True:(<class 'TypeError'>, TypeError('expected vim.TabPage object',))
        > > vim.current.xxx = True:(<class 'AttributeError'>, AttributeError('xxx',))
        > > -3,xx
        > > -before
        > > -after
        > > vim.command("throw 'abc'"):(<class 'vim.error'>, error('abc',))
        > > Exe("throw 'def'"):(<class 'vim.error'>, error('def',))
        > > vim.eval("Exe('throw ''ghi''')"):(<class 'vim.error'>, error('ghi',))
        >
        > Could you show output of :messages right before quitting? It is obvious
        > there was an exception, but I cannot say what it was.

        For test 86:

        Messages maintainer: Bram Moolenaar <Bram@...>
        E325: ATTENTION
        "test86.in" 1124 lines, 30296 characters
        "Xdotest" [New File] 1113 lines, 30003 characters written
        "Xdotest" [New File] 1113 lines, 30003 characters written
        E484: Can't open file small.vim
        Error detected while processing function Test:
        line 159:
        Traceback (most recent call last):
        File "<string>", line 1, in <module>
        vim.error: list is locked
        8 more lines
        3 more lines
        Already only one window
        abcdef
        line 741:
        abcdef
        abc
        line 743:
        abc
        7 more lines
        line 1081:
        Traceback (most recent call last):
        File "<string>", line 4, in <module>
        ImportError: No module named module
        "test86.in" [Modified][Not edited] line 1554 of 2214 --70%-- col


        Test 87:

        Messages maintainer: Bram Moolenaar <Bram@...>
        E325: ATTENTION
        "test87.in" 1080 lines, 29342 characters
        "Xdotest" [New File] 1074 lines, 29258 characters written
        "Xdotest" [New File] 1074 lines, 29258 characters written
        E484: Can't open file small.vim
        Error detected while processing function Test:
        line 158:
        Traceback (most recent call last):
        File "<string>", line 1, in <module>
        vim.error: list is locked
        8 more lines
        3 more lines
        Already only one window
        abcdef
        line 706:
        abcdef
        abc
        line 708:
        abc
        7 more lines
        line 1043:
        Traceback (most recent call last):
        File "<string>", line 4, in <module>
        ImportError: No module named module
        "test87.in" [Modified][Not edited] line 1499 of 2179 --68%-- col 1


        --
        hundred-and-one symptoms of being an internet addict:
        177. You log off of your system because it's time to go to work.

        /// Bram Moolenaar -- Bram@... -- http://www.Moolenaar.net \\\
        /// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
        \\\ an exciting new programming language -- http://www.Zimbu.org ///
        \\\ help me help AIDS victims -- http://ICCF-Holland.org ///

        --
        --
        You received this message from the "vim_dev" maillist.
        Do not top-post! Type your reply below the text you are replying to.
        For more information, visit http://www.vim.org/maillist.php

        ---
        You received this message because you are subscribed to the Google Groups "vim_dev" group.
        To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscribe@....
        For more options, visit https://groups.google.com/groups/opt_out.
      • Nikolay Pavlov
        ... for ... vim.Window object ,)) ... vim.TabPage object ,)) ... AttributeError( xxx ,)) ... Some files are missing in the diff, but [present](
        Message 3 of 26 , Jun 13, 2013
        • 0 Attachment


          On Jun 13, 2013 2:40 PM, "Bram Moolenaar" <Bram@...> wrote:
          >
          >
          > ZyX wrote:
          >
          > > > > # HG changeset patch
          > > > > # User ZyX <kp-pav@...>
          > > > > # Date 1371036594 -14400
          > > > > #      Wed Jun 12 15:29:54 2013 +0400
          > > > > # Branch python-path
          > > > > # Node ID 27aa091d5fa525fd4ba97b4b68dc62e64e8bd3a0
          > > > > # Parent  643f64bbd9386d746313a7678cfa08826b4a5122
          > > > > Use the same method for python3 as for python2
          > > >
          > > > Thanks for the updates.  Unfortunately, now both test 86 and 87 fail for
          > > > me.  Previously only test 86 was failing.
          > > >
          > > > python --version
          > > > Python 2.7.3
          > > >
          > > > python3 --version
          > > > Python 3.2.3
          > > >
          > > > % diff -u testdir/test86.ok testdir/test86.failed
          > > > --- testdir/test86.ok   2013-06-12 14:21:28.000000000 +0200
          > > > +++ testdir/test86.failed       2013-06-12 14:38:10.000000000 +0200
          > > > @@ -1083,9 +1083,6 @@
          > > >  vim.current.window = True:TypeError:('expected vim.Window object',)
          > > >  vim.current.tabpage = True:TypeError:('expected vim.TabPage object',)
          > > >  vim.current.xxx = True:AttributeError:('xxx',)
          > > > -2,xx
          > > > -before
          > > > -after
          > > >  vim.command("throw 'abc'"):error:('abc',)
          > > >  Exe("throw 'def'"):error:('def',)
          > > >  vim.eval("Exe('throw ''ghi''')"):error:('ghi',)
          > > >
          > > > % diff -u testdir/test87.ok testdir/test87.failed
          > > > --- testdir/test87.ok   2013-06-12 14:12:13.000000000 +0200
          > > > +++ testdir/test87.failed       2013-06-12 14:38:13.000000000 +0200
          > > > @@ -1092,9 +1092,6 @@
          > > >  vim.current.window = True:(<class 'TypeError'>, TypeError('expected vim.Window object',))
          > > >  vim.current.tabpage = True:(<class 'TypeError'>, TypeError('expected vim.TabPage object',))
          > > >  vim.current.xxx = True:(<class 'AttributeError'>, AttributeError('xxx',))
          > > > -3,xx
          > > > -before
          > > > -after
          > > >  vim.command("throw 'abc'"):(<class 'vim.error'>, error('abc',))
          > > >  Exe("throw 'def'"):(<class 'vim.error'>, error('def',))
          > > >  vim.eval("Exe('throw ''ghi''')"):(<class 'vim.error'>, error('ghi',))
          > >
          > > Could you show output of :messages right before quitting? It is obvious
          > > there was an exception, but I cannot say what it was.
          >
          > For test 86:
          >
          > Messages maintainer: Bram Moolenaar <Bram@...>
          > E325: ATTENTION
          > "test86.in" 1124 lines, 30296 characters
          > "Xdotest" [New File] 1113 lines, 30003 characters written
          > "Xdotest" [New File] 1113 lines, 30003 characters written
          > E484: Can't open file small.vim
          > Error detected while processing function Test:
          > line  159:
          > Traceback (most recent call last):
          >   File "<string>", line 1, in <module>
          > vim.error: list is locked
          > 8 more lines
          > 3 more lines
          > Already only one window
          > abcdef
          > line  741:
          > abcdef
          > abc
          > line  743:
          > abc
          > 7 more lines
          > line 1081:
          > Traceback (most recent call last):
          >   File "<string>", line 4, in <module>
          > ImportError: No module named module
          > "test86.in" [Modified][Not edited] line 1554 of 2214 --70%-- col
          >
          >
          > Test 87:
          >
          > Messages maintainer: Bram Moolenaar <Bram@...>
          > E325: ATTENTION
          > "test87.in" 1080 lines, 29342 characters
          > "Xdotest" [New File] 1074 lines, 29258 characters written
          > "Xdotest" [New File] 1074 lines, 29258 characters written
          > E484: Can't open file small.vim
          > Error detected while processing function Test:
          > line  158:
          > Traceback (most recent call last):
          >   File "<string>", line 1, in <module>
          > vim.error: list is locked
          > 8 more lines
          > 3 more lines
          > Already only one window
          > abcdef
          > line  706:
          > abcdef
          > abc
          > line  708:
          > abc
          > 7 more lines
          > line 1043:
          > Traceback (most recent call last):
          >   File "<string>", line 4, in <module>
          > ImportError: No module named module
          > "test87.in" [Modified][Not edited] line 1499 of 2179 --68%-- col 1

          Some files are missing in the diff, but [present](https://bitbucket.org/ZyX_I/vim/commits/a1b8a5ddecec70085e7e62f8ea9bc6c46ecea530#chg-src/testdir/python_before/before_1.py) in the commit. diff -c should be missing them: with -N flag used they are considered not changed (-N treats missing files as empty ... and added files are also empty). But hg export ... I did not expect such failure.

          > --
          > hundred-and-one symptoms of being an internet addict:
          > 177. You log off of your system because it's time to go to work.
          >
          >  /// Bram Moolenaar -- Bram@... -- http://www.Moolenaar.net   \\\
          > ///        sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
          > \\\  an exciting new programming language -- http://www.Zimbu.org        ///
          >  \\\            help me help AIDS victims -- http://ICCF-Holland.org    ///

          --
          --
          You received this message from the "vim_dev" maillist.
          Do not top-post! Type your reply below the text you are replying to.
          For more information, visit http://www.vim.org/maillist.php
           
          ---
          You received this message because you are subscribed to the Google Groups "vim_dev" group.
          To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscribe@....
          For more options, visit https://groups.google.com/groups/opt_out.
           
           
        • Elimar Riesebieter
          * Jun T. [2013-06-13 13:42 +0900]: [...] ... Confirmed ;-) Elimar -- Numeric stability is probably not all that important when
          Message 4 of 26 , Jun 13, 2013
          • 0 Attachment
            * Jun T. <takimoto-j@...> [2013-06-13 13:42 +0900]:

            [...]
            > In addition, if I configure --with-python3interp=dynamic,
            > test87 core dumps.
            > This core dump can be fixed by the following patch:
            >
            >
            > diff -r 8a49630c8a5f src/if_python3.c
            > --- a/src/if_python3.c Wed Jun 12 22:41:37 2013 +0200
            > +++ b/src/if_python3.c Thu Jun 13 12:25:31 2013 +0900
            > @@ -488,7 +488,7 @@
            > {"PyEval_InitThreads", (PYTHON_PROC*)&py3_PyEval_InitThreads},
            > {"PyEval_RestoreThread", (PYTHON_PROC*)&py3_PyEval_RestoreThread},
            > {"PyEval_SaveThread", (PYTHON_PROC*)&py3_PyEval_SaveThread},
            > - {"PyArg_Parse", (PYTHON_PROC*)&py3_PyArg_Parse},
            > + {"_PyArg_Parse_SizeT", (PYTHON_PROC*)&py3_PyArg_Parse},
            > {"Py_IsInitialized", (PYTHON_PROC*)&py3_Py_IsInitialized},
            > {"_PyObject_NextNotImplemented", (PYTHON_PROC*)&py3__PyObject_NextNotImplemented},
            > {"_Py_NoneStruct", (PYTHON_PROC*)&py3__Py_NoneStruct},

            Confirmed ;-)

            Elimar
            --
            Numeric stability is probably not all that
            important when you're guessing;-)

            --
            --
            You received this message from the "vim_dev" maillist.
            Do not top-post! Type your reply below the text you are replying to.
            For more information, visit http://www.vim.org/maillist.php

            ---
            You received this message because you are subscribed to the Google Groups "vim_dev" group.
            To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscribe@....
            For more options, visit https://groups.google.com/groups/opt_out.
          • Bram Moolenaar
            ... OK, adding the missing empty files make the tests pass. I added a comment, empty files may indeed be ignored by some tools. Don t you have some way to
            Message 5 of 26 , Jun 13, 2013
            • 0 Attachment
              ZyX wrote:

              > > > Thanks for the updates. Unfortunately, now both test 86 and 87
              > > > fail for me. Previously only test 86 was failing.

              > Some files are missing in the diff, but [present](
              > https://bitbucket.org/ZyX_I/vim/commits/a1b8a5ddecec70085e7e62f8ea9bc6c46ecea530#chg-src/testdir/python_before/before_1.py)
              > in the commit. diff -c should be missing them: with -N flag used they are
              > considered not changed (-N treats missing files as empty ... and added
              > files are also empty). But hg export ... I did not expect such failure.

              OK, adding the missing "empty" files make the tests pass.
              I added a comment, empty files may indeed be ignored by some tools.

              Don't you have some way to diff your version with the released
              version in Mercurial?

              --
              hundred-and-one symptoms of being an internet addict:
              181. You make up words that go with the "happy tune" your modem makes
              while dialing your ISP.

              /// Bram Moolenaar -- Bram@... -- http://www.Moolenaar.net \\\
              /// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
              \\\ an exciting new programming language -- http://www.Zimbu.org ///
              \\\ help me help AIDS victims -- http://ICCF-Holland.org ///

              --
              --
              You received this message from the "vim_dev" maillist.
              Do not top-post! Type your reply below the text you are replying to.
              For more information, visit http://www.vim.org/maillist.php

              ---
              You received this message because you are subscribed to the Google Groups "vim_dev" group.
              To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscribe@....
              For more options, visit https://groups.google.com/groups/opt_out.
            • Bram Moolenaar
              ... Solved in patch 7.3.1183. ... Thanks, I ll include that. ... Yes, for Python 3 PY_SSIZE_T_CLEAN should always be defined. -- hundred-and-one symptoms of
              Message 6 of 26 , Jun 13, 2013
              • 0 Attachment
                Jun Takimoto wrote:

                > On 2013/06/12, at 21:41, Bram Moolenaar <Bram@...> wrote:
                > > Thanks for the updates. Unfortunately, now both test 86 and 87 fail for
                > > me.
                > (snip)
                > > -2,xx
                > > -before
                > > -after
                >
                > I'm getting the same error (python2.7.3 and python 3.2.3).
                >
                > It seems the tests are failing when they try to 'import module'.
                > The module 'module' is in testdir/python{2,3}/module.py, which
                > in turn imports a module named 'before_1'.
                >
                > Where is this module 'before_1' ?

                Solved in patch 7.3.1183.

                > In addition, if I configure --with-python3interp=dynamic,
                > test87 core dumps.
                > This core dump can be fixed by the following patch:
                >
                >
                > diff -r 8a49630c8a5f src/if_python3.c
                > --- a/src/if_python3.c Wed Jun 12 22:41:37 2013 +0200
                > +++ b/src/if_python3.c Thu Jun 13 12:25:31 2013 +0900
                > @@ -488,7 +488,7 @@
                > {"PyEval_InitThreads", (PYTHON_PROC*)&py3_PyEval_InitThreads},
                > {"PyEval_RestoreThread", (PYTHON_PROC*)&py3_PyEval_RestoreThread},
                > {"PyEval_SaveThread", (PYTHON_PROC*)&py3_PyEval_SaveThread},
                > - {"PyArg_Parse", (PYTHON_PROC*)&py3_PyArg_Parse},
                > + {"_PyArg_Parse_SizeT", (PYTHON_PROC*)&py3_PyArg_Parse},
                > {"Py_IsInitialized", (PYTHON_PROC*)&py3_Py_IsInitialized},
                > {"_PyObject_NextNotImplemented", (PYTHON_PROC*)&py3__PyObject_NextNotImplemented},
                > {"_Py_NoneStruct", (PYTHON_PROC*)&py3__Py_NoneStruct},

                Thanks, I'll include that.

                > Note:
                > Since PY_SSIZE_T_CLEAN is unconditionally defined in if_python3.c
                > (and I think it is correct), the following part in if_python3.c
                > (line 428) may be simplified to always use ssize_t-clean version.
                >
                > # ifndef PY_SSIZE_T_CLEAN
                > {"PyArg_ParseTuple", (PYTHON_PROC*)&py3_PyArg_ParseTuple},
                > {"Py_BuildValue", (PYTHON_PROC*)&py3_Py_BuildValue},
                > # else
                > {"_PyArg_ParseTuple_SizeT", (PYTHON_PROC*)&py3_PyArg_ParseTuple},
                > {"_Py_BuildValue_SizeT", (PYTHON_PROC*)&py3_Py_BuildValue},
                > # endif

                Yes, for Python 3 PY_SSIZE_T_CLEAN should always be defined.

                --
                hundred-and-one symptoms of being an internet addict:
                187. You promise yourself that you'll only stay online for another
                15 minutes...at least once every hour.

                /// Bram Moolenaar -- Bram@... -- http://www.Moolenaar.net \\\
                /// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
                \\\ an exciting new programming language -- http://www.Zimbu.org ///
                \\\ help me help AIDS victims -- http://ICCF-Holland.org ///

                --
                --
                You received this message from the "vim_dev" maillist.
                Do not top-post! Type your reply below the text you are replying to.
                For more information, visit http://www.vim.org/maillist.php

                ---
                You received this message because you are subscribed to the Google Groups "vim_dev" group.
                To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscribe@....
                For more options, visit https://groups.google.com/groups/opt_out.
              • Justin Charette
                ... I have a related problem with the vdebug plugin[1] on vim 7.6.1163 with python 2.7.3. I just want to confirm that 7.3.1183 is expected to fix this issue.
                Message 7 of 26 , Jun 16, 2013
                • 0 Attachment
                  On Thursday, June 13, 2013 11:58:16 AM UTC-7, Bram Moolenaar wrote:
                  > Jun Takimoto wrote:
                  >
                  >
                  >
                  > > On 2013/06/12, at 21:41, Bram Moolenaar wrote:
                  >
                  > > > Thanks for the updates. Unfortunately, now both test 86 and 87 fail for
                  >
                  > > > me.
                  >
                  > > (snip)
                  >
                  > > > -2,xx
                  >
                  > > > -before
                  >
                  > > > -after
                  >
                  > >
                  >
                  > > I'm getting the same error (python2.7.3 and python 3.2.3).
                  >
                  > >
                  >
                  > > It seems the tests are failing when they try to 'import module'.
                  >
                  > > The module 'module' is in testdir/python{2,3}/module.py, which
                  >
                  > > in turn imports a module named 'before_1'.
                  >
                  > >
                  >
                  > > Where is this module 'before_1' ?
                  >
                  >
                  >
                  > Solved in patch 7.3.1183.

                  I have a related problem with the vdebug plugin[1] on vim 7.6.1163 with python 2.7.3. I just want to confirm that 7.3.1183 is expected to fix this issue.

                  [1] https://github.com/joonty/vdebug/issues/93

                  --
                  --
                  You received this message from the "vim_dev" maillist.
                  Do not top-post! Type your reply below the text you are replying to.
                  For more information, visit http://www.vim.org/maillist.php

                  ---
                  You received this message because you are subscribed to the Google Groups "vim_dev" group.
                  To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscribe@....
                  For more options, visit https://groups.google.com/groups/opt_out.
                Your message has been successfully submitted and would be delivered to recipients shortly.