Loading ...
Sorry, an error occurred while loading the content.

Re: Patch 7.3.970

Expand Messages
  • Ron Aaron
    Don t know if it makes a difference, but I compile big version, for GTK2 with CFLAGS of -O3 -s -march=native -msse4.2 Only patch 970 causes the crash. -- --
    Message 1 of 25 , May 19 1:01 PM
    • 0 Attachment
      Don't know if it makes a difference, but I compile "big" version, for GTK2 with CFLAGS of

      -O3 -s -march=native -msse4.2

      Only patch 970 causes the crash.

      --
      --
      You received this message from the "vim_dev" maillist.
      Do not top-post! Type your reply below the text you are replying to.
      For more information, visit http://www.vim.org/maillist.php

      ---
      You received this message because you are subscribed to the Google Groups "vim_dev" group.
      To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscribe@....
      For more options, visit https://groups.google.com/groups/opt_out.
    • Tony Mechelynck
      ... Yes, it crashes for me too, see my 2nd post in this thread. I get the crash even with the following in the .vimrc: if exists( +regexpengine ) set
      Message 2 of 25 , May 19 1:07 PM
      • 0 Attachment
        On 19/05/13 21:52, Ron Aaron wrote:
        > Crashes for me:
        >
        > (gdb) bt
        > #0 0xb7fdd424 in __kernel_vsyscall ()
        > #1 0xb75391df in __GI_raise (sig=6) at ../nptl/sysdeps/unix/sysv/linux/raise.c:64
        > #2 0xb753c825 in __GI_abort () at abort.c:91
        > #3 0xb757639a in __libc_message (do_abort=2, fmt=0xb766e6c7 "*** %s ***: %s terminated\n") at ../sysdeps/unix/sysv/linux/libc_fatal.c:201
        > #4 0xb760f105 in __GI___fortify_fail (msg=0xb766e648 "buffer overflow detected") at fortify_fail.c:38
        > #5 0xb760deba in __GI___chk_fail () at chk_fail.c:29
        > #6 0x08191a77 in nfa_regatom ()
        > #7 0x08193a74 in nfa_regconcat ()
        > #8 0x08194000 in nfa_regbranch ()
        > #9 0x081940e8 in nfa_reg ()
        > #10 0x08194ee1 in nfa_regcomp ()
        > #11 0x081a3fc9 in vim_regcomp ()
        > #12 0x080e10f9 in do_autocmd_event ()
        > #13 0x080e1403 in do_autocmd ()
        > #14 0x080b9c4d in ex_autocmd ()
        > #15 0x080c128c in do_one_cmd ()
        > #16 0x080c424b in do_cmdline ()
        > #17 0x080b4f7f in do_source ()
        > #18 0x080b58c9 in do_in_runtimepath.constprop.8 ()
        > #19 0x080b8bf6 in ex_filetype ()
        > #20 0x080c128c in do_one_cmd ()
        > #21 0x080c424b in do_cmdline ()
        > #22 0x080b4f7f in do_source ()
        > #23 0x080558ac in main ()
        >

        Yes, it crashes for me too, see my 2nd post in this thread. I get the
        crash even with the following in the .vimrc:

        if exists('+regexpengine')
        set regexpengine=1
        endif


        Best regards,
        Tony.
        --
        Has everyone noticed that all the letters of the word "database" are
        typed with the left hand? Now the layout of the QWERTYUIOP typewriter
        keyboard was designed, among other things, to facilitate the even use
        of both hands. It follows, therefore, that writing about databases is
        not only unnatural, but a lot harder than it appears.

        --
        --
        You received this message from the "vim_dev" maillist.
        Do not top-post! Type your reply below the text you are replying to.
        For more information, visit http://www.vim.org/maillist.php

        ---
        You received this message because you are subscribed to the Google Groups "vim_dev" group.
        To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscribe@....
        For more options, visit https://groups.google.com/groups/opt_out.
      • Bram Moolenaar
        ... Can you try changing EMSG2() to EMSGN()? ... Yep, buffer should be 10 characters. ... -- The Law, in its majestic equality, forbids the rich, as well as
        Message 3 of 25 , May 19 1:08 PM
        • 0 Attachment
          Tony Mechelynck wtote:

          > On 19/05/13 19:44, Bram Moolenaar wrote:
          > >
          > > I wrote:
          > >
          > >> Patch 7.3.970
          > >
          > > All the tests I could do with the new engine pass. However, it is
          > > noticeable slower than the old engine. If this bothers you, set the
          > > 'regexpengine' option to one.
          > >
          > > If you spot a mistake in regexp pattern matching, please send a
          > > reproducible example, so that we can add it to the tests.
          > >
          >
          > Compiling on linux_x86_64:
          >
          > gcc -c -I. -Iproto -DHAVE_CONFIG_H -I/usr/local/include -O2
          > -fno-strength-reduce -Wall -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=1
          > -o objects/regexp.o regexp.c
          > In file included from regexp.c:7749:0:
          > regexp_nfa.c: In function ‘nfa_regatom’:
          > regexp_nfa.c:762:6: warning: cast to pointer from integer of different
          > size [-Wint-to-pointer-cast]
          > regexp_nfa.c:773:6: warning: cast to pointer from integer of different
          > size [-Wint-to-pointer-cast]
          > regexp_nfa.c:819:7: warning: cast to pointer from integer of different
          > size [-Wint-to-pointer-cast]
          > regexp_nfa.c: In function ‘nfa_regpiece’:
          > regexp_nfa.c:1366:7: warning: cast to pointer from integer of different
          > size [-Wint-to-pointer-cast]

          Can you try changing EMSG2() to EMSGN()?

          > In file included from /usr/include/string.h:642:0,
          > from os_unix.h:522,
          > from vim.h:268,
          > from regexp.c:47:
          > In function ‘strcpy’,
          > inlined from ‘nfa_recognize_char_class.constprop.24’ at
          > regexp_nfa.c:379:5:
          > /usr/include/bits/string3.h:105:3: warning: call to
          > __builtin___strcpy_chk will always overflow destination buffer [enabled
          > by default]

          Yep, buffer should be 10 characters.

          > The above is with "tiny" features but "huge" features give me the same
          > (with a much longer gcc command line).

          --
          The Law, in its majestic equality, forbids the rich, as well as the
          poor, to sleep under the bridges, to beg in the streets, and to steal
          bread. -- Anatole France

          /// Bram Moolenaar -- Bram@... -- http://www.Moolenaar.net \\\
          /// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
          \\\ an exciting new programming language -- http://www.Zimbu.org ///
          \\\ help me help AIDS victims -- http://ICCF-Holland.org ///

          --
          --
          You received this message from the "vim_dev" maillist.
          Do not top-post! Type your reply below the text you are replying to.
          For more information, visit http://www.vim.org/maillist.php

          ---
          You received this message because you are subscribed to the Google Groups "vim_dev" group.
          To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscribe@....
          For more options, visit https://groups.google.com/groups/opt_out.
        • Tony Mechelynck
          ... I get the crash in both huge (GTK2/Gnome) and tiny (no GUI) builds, at patchlevels 7.3.920 and later. (I haven t yet tried backing out patch 920 in a new
          Message 4 of 25 , May 19 1:11 PM
          • 0 Attachment
            On 19/05/13 22:01, Ron Aaron wrote:
            > Don't know if it makes a difference, but I compile "big" version, for GTK2 with CFLAGS of
            >
            > -O3 -s -march=native -msse4.2
            >
            > Only patch 970 causes the crash.
            >

            I get the crash in both huge (GTK2/Gnome) and tiny (no GUI) builds, at
            patchlevels 7.3.920 and later. (I haven't yet tried backing out patch
            920 in a new unnamed branch of my Mercurial clone.)


            Best regards,
            Tony.
            --
            First Law of Bicycling:
            No matter which way you ride, it's uphill and against the
            wind.

            --
            --
            You received this message from the "vim_dev" maillist.
            Do not top-post! Type your reply below the text you are replying to.
            For more information, visit http://www.vim.org/maillist.php

            ---
            You received this message because you are subscribed to the Google Groups "vim_dev" group.
            To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscribe@....
            For more options, visit https://groups.google.com/groups/opt_out.
          • Bram Moolenaar
            ... I cannot reproduce it. Can you find out where in nfa_regatom() this happens? Hmm, maybe it inlines nfa_recognize_char_class(). The myconfig buffer there
            Message 5 of 25 , May 19 1:31 PM
            • 0 Attachment
              Ron Aaron wrote:

              > Crashes for me:
              >
              > (gdb) bt
              > #0 0xb7fdd424 in __kernel_vsyscall ()
              > #1 0xb75391df in __GI_raise (sig=6) at ../nptl/sysdeps/unix/sysv/linux/raise.c:64
              > #2 0xb753c825 in __GI_abort () at abort.c:91
              > #3 0xb757639a in __libc_message (do_abort=2, fmt=0xb766e6c7 "*** %s ***: %s terminated\n") at ../sysdeps/unix/sysv/linux/libc_fatal.c:201
              > #4 0xb760f105 in __GI___fortify_fail (msg=0xb766e648 "buffer overflow detected") at fortify_fail.c:38
              > #5 0xb760deba in __GI___chk_fail () at chk_fail.c:29
              > #6 0x08191a77 in nfa_regatom ()
              > #7 0x08193a74 in nfa_regconcat ()
              > #8 0x08194000 in nfa_regbranch ()
              > #9 0x081940e8 in nfa_reg ()
              > #10 0x08194ee1 in nfa_regcomp ()
              > #11 0x081a3fc9 in vim_regcomp ()
              > #12 0x080e10f9 in do_autocmd_event ()
              > #13 0x080e1403 in do_autocmd ()
              > #14 0x080b9c4d in ex_autocmd ()
              > #15 0x080c128c in do_one_cmd ()
              > #16 0x080c424b in do_cmdline ()
              > #17 0x080b4f7f in do_source ()
              > #18 0x080b58c9 in do_in_runtimepath.constprop.8 ()
              > #19 0x080b8bf6 in ex_filetype ()
              > #20 0x080c128c in do_one_cmd ()
              > #21 0x080c424b in do_cmdline ()
              > #22 0x080b4f7f in do_source ()
              > #23 0x080558ac in main ()

              I cannot reproduce it.

              Can you find out where in nfa_regatom() this happens?

              Hmm, maybe it inlines nfa_recognize_char_class(). The myconfig buffer
              there needs to be 10 chars instead of 9.

              --
              It is illegal for anyone to give lighted cigars to dogs, cats, and other
              domesticated animal kept as pets.
              [real standing law in Illinois, United States of America]

              /// Bram Moolenaar -- Bram@... -- http://www.Moolenaar.net \\\
              /// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
              \\\ an exciting new programming language -- http://www.Zimbu.org ///
              \\\ help me help AIDS victims -- http://ICCF-Holland.org ///

              --
              --
              You received this message from the "vim_dev" maillist.
              Do not top-post! Type your reply below the text you are replying to.
              For more information, visit http://www.vim.org/maillist.php

              ---
              You received this message because you are subscribed to the Google Groups "vim_dev" group.
              To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscribe@....
              For more options, visit https://groups.google.com/groups/opt_out.
            • Tony Mechelynck
              ... [...] ... No messages and no crash with the attached patch. -- Thanks Bram. Best regards, Tony. -- Computers will not be perfected until they can compute
              Message 6 of 25 , May 19 1:38 PM
              • 0 Attachment
                On 19/05/13 22:08, Bram Moolenaar wrote:
                >
                > Tony Mechelynck wtote:
                >
                >> On 19/05/13 19:44, Bram Moolenaar wrote:
                >>>
                >>> I wrote:
                >>>
                >>>> Patch 7.3.970
                >>>
                >>> All the tests I could do with the new engine pass. However, it is
                >>> noticeable slower than the old engine. If this bothers you, set the
                >>> 'regexpengine' option to one.
                >>>
                >>> If you spot a mistake in regexp pattern matching, please send a
                >>> reproducible example, so that we can add it to the tests.
                >>>
                >>
                >> Compiling on linux_x86_64:
                [...]
                > Can you try changing EMSG2() to EMSGN()?
                >
                >> In file included from /usr/include/string.h:642:0,
                >> from os_unix.h:522,
                >> from vim.h:268,
                >> from regexp.c:47:
                >> In function ‘strcpy’,
                >> inlined from ‘nfa_recognize_char_class.constprop.24’ at
                >> regexp_nfa.c:379:5:
                >> /usr/include/bits/string3.h:105:3: warning: call to
                >> __builtin___strcpy_chk will always overflow destination buffer [enabled
                >> by default]
                >
                > Yep, buffer should be 10 characters.
                >
                >> The above is with "tiny" features but "huge" features give me the same
                >> (with a much longer gcc command line).
                >


                No messages and no crash with the attached patch. -- Thanks Bram.

                Best regards,
                Tony.
                --
                Computers will not be perfected until they can compute how much more
                than the estimate the job will cost.

                --
                --
                You received this message from the "vim_dev" maillist.
                Do not top-post! Type your reply below the text you are replying to.
                For more information, visit http://www.vim.org/maillist.php

                ---
                You received this message because you are subscribed to the Google Groups "vim_dev" group.
                To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscribe@....
                For more options, visit https://groups.google.com/groups/opt_out.
              • Taro MURAOKA
                This makes vim (debug build) slow to startup. New NFA engine seems to write huge log files in debug build. And it causes this terrible slow down. Added files
                Message 7 of 25 , May 19 5:40 PM
                • 0 Attachment
                  This makes vim (debug build) slow to startup.
                  New NFA engine seems to write huge log files in debug build.
                  And it causes this terrible slow down.

                  Added files are generated like this:

                  gvim -u NONE -U NONE --noplugin --startuptime startuptime-7.3.XXX.txt

                  I'll look into source codes later, but reported at first.

                  --
                  --
                  You received this message from the "vim_dev" maillist.
                  Do not top-post! Type your reply below the text you are replying to.
                  For more information, visit http://www.vim.org/maillist.php

                  ---
                  You received this message because you are subscribed to the Google Groups "vim_dev" group.
                  To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscribe@....
                  For more options, visit https://groups.google.com/groups/opt_out.
                • Ben Fritz
                  ... Wasn t the main purpose of the new engine to speed things up? Or are we sacrificing average speed for better worst-case speed? -- -- You received this
                  Message 8 of 25 , May 19 7:12 PM
                  • 0 Attachment
                    On Sunday, May 19, 2013 12:44:49 PM UTC-5, Bram Moolenaar wrote:
                    > I wrote:
                    >
                    >
                    >
                    > > Patch 7.3.970
                    >
                    >
                    >
                    > All the tests I could do with the new engine pass. However, it is
                    >
                    > noticeable slower than the old engine. If this bothers you, set the
                    >
                    > 'regexpengine' option to one.
                    >

                    Wasn't the main purpose of the new engine to speed things up? Or are we sacrificing average speed for better worst-case speed?

                    --
                    --
                    You received this message from the "vim_dev" maillist.
                    Do not top-post! Type your reply below the text you are replying to.
                    For more information, visit http://www.vim.org/maillist.php

                    ---
                    You received this message because you are subscribed to the Google Groups "vim_dev" group.
                    To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscribe@....
                    For more options, visit https://groups.google.com/groups/opt_out.
                  • Taro MURAOKA
                    ... # reported at here in Japanese - https://github.com/vim-jp/issues/issues/386 Yasuhiro Matsumoto try to write a patch to fix this, but it seems that there
                    Message 9 of 25 , May 19 7:44 PM
                    • 0 Attachment
                      I got a report that 970 causes crash when do this:

                      :echo search("[^A-z]")

                      # reported at here in Japanese -> https://github.com/vim-jp/issues/issues/386

                      Yasuhiro Matsumoto try to write a patch to fix this,
                      but it seems that there are some other similar problems.

                      --
                      --
                      You received this message from the "vim_dev" maillist.
                      Do not top-post! Type your reply below the text you are replying to.
                      For more information, visit http://www.vim.org/maillist.php

                      ---
                      You received this message because you are subscribed to the Google Groups "vim_dev" group.
                      To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscribe@....
                      For more options, visit https://groups.google.com/groups/opt_out.
                    • Charles
                      ... Here s my benchmark result Benchmark: newengine vs oldengine Trial #1 newengine : 0.746297 oldengine : 2.197819 Trial #2 newengine : 0.742969 oldengine :
                      Message 10 of 25 , May 20 2:18 AM
                      • 0 Attachment
                        On Mon, May 20, 2013 at 9:12 AM, Ben Fritz <fritzophrenic@...> wrote:
                        >
                        > On Sunday, May 19, 2013 12:44:49 PM UTC-5, Bram Moolenaar wrote:
                        > > I wrote:
                        > >
                        > >
                        > >
                        > > > Patch 7.3.970
                        > >
                        > >
                        > >
                        > > All the tests I could do with the new engine pass. However, it is
                        > >
                        > > noticeable slower than the old engine. If this bothers you, set the
                        > >
                        > > 'regexpengine' option to one.
                        > >
                        >
                        > Wasn't the main purpose of the new engine to speed things up? Or are we sacrificing average speed for better worst-case speed?
                        >

                        Here's my benchmark result

                        Benchmark: newengine vs oldengine

                        Trial #1
                        newengine : 0.746297
                        oldengine : 2.197819

                        Trial #2
                        newengine : 0.742969
                        oldengine : 2.195868

                        Trial #3
                        newengine : 0.746451
                        oldengine : 2.199959

                        --
                        --
                        You received this message from the "vim_dev" maillist.
                        Do not top-post! Type your reply below the text you are replying to.
                        For more information, visit http://www.vim.org/maillist.php

                        ---
                        You received this message because you are subscribed to the Google Groups "vim_dev" group.
                        To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscribe@....
                        For more options, visit https://groups.google.com/groups/opt_out.
                      • John Marriott
                        Hi All, Attempting to compile on HP-UX fails after this patch with this message: cc -c -I. -Iproto -DHAVE_CONFIG_H -O2 -o objects/regexp.o regexp.c cc:
                        Message 11 of 25 , May 20 3:35 AM
                        • 0 Attachment
                          Hi All,

                          Attempting to compile on HP-UX fails after this patch with this message:
                              cc -c -I. -Iproto -DHAVE_CONFIG_H     -O2       -o objects/regexp.o regexp.c

                          cc: "regexp_nfa.c", line 1966: error 1521: Incorrect initialization.

                          It seems that HP's cc doesn't like this initialisation:
                          /*
                           * Initialize Frag_T struct.
                           */
                              static Frag_T
                          frag(start, out)
                              nfa_state_T    *start;
                              Ptrlist    *out;
                          {
                              Frag_T n = { start, out };
                              return n;
                          }

                          After changing it to:
                          /*
                           * Initialize Frag_T struct.
                           */
                              static Frag_T
                          frag(start, out)
                              nfa_state_T    *start;
                              Ptrlist    *out;
                          {
                              Frag_T n;

                              n.start = start;
                              n.out = out;

                              return n;
                          }


                          It's happy again.

                          Cheers
                          John

                          On 20-May-2013 3:44 AM, Bram Moolenaar wrote:
                          I wrote:
                          
                          
                          Patch 7.3.970
                          
                          All the tests I could do with the new engine pass.  However, it is
                          noticeable slower than the old engine.  If this bothers you, set the
                          'regexpengine' option to one.
                          
                          If you spot a mistake in regexp pattern matching, please send a
                          reproducible example, so that we can add it to the tests.
                          
                          

                          --
                          --
                          You received this message from the "vim_dev" maillist.
                          Do not top-post! Type your reply below the text you are replying to.
                          For more information, visit http://www.vim.org/maillist.php
                           
                          ---
                          You received this message because you are subscribed to the Google Groups "vim_dev" group.
                          To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscribe@....
                          For more options, visit https://groups.google.com/groups/opt_out.
                           
                           
                        • Bram Moolenaar
                          ... So the new engine is faster? Or what do the numbers mean? My experience is that the new engine is slower. Thus we have work to do to make it faster. --
                          Message 12 of 25 , May 20 4:34 AM
                          • 0 Attachment
                            Charles Peacech wrote:

                            > On Mon, May 20, 2013 at 9:12 AM, Ben Fritz <fritzophrenic@...> wrote:
                            > >
                            > > On Sunday, May 19, 2013 12:44:49 PM UTC-5, Bram Moolenaar wrote:
                            > > > I wrote:
                            > > >
                            > > >
                            > > >
                            > > > > Patch 7.3.970
                            > > >
                            > > >
                            > > >
                            > > > All the tests I could do with the new engine pass. However, it is
                            > > >
                            > > > noticeable slower than the old engine. If this bothers you, set the
                            > > >
                            > > > 'regexpengine' option to one.
                            > > >
                            > >
                            > > Wasn't the main purpose of the new engine to speed things up? Or are we sacrificing average speed for better worst-case speed?
                            > >
                            >
                            > Here's my benchmark result
                            >
                            > Benchmark: newengine vs oldengine
                            >
                            > Trial #1
                            > newengine : 0.746297
                            > oldengine : 2.197819
                            >
                            > Trial #2
                            > newengine : 0.742969
                            > oldengine : 2.195868
                            >
                            > Trial #3
                            > newengine : 0.746451
                            > oldengine : 2.199959

                            So the new engine is faster? Or what do the numbers mean?

                            My experience is that the new engine is slower. Thus we have work to do
                            to make it faster.

                            --
                            Close your shells, or I'll kill -9 you
                            Tomorrow I'll quota you
                            Remember the disks'll always be full
                            And then while I'm away
                            I'll write ~ everyday
                            And I'll send-pr all my buggings to you.
                            [ CVS log "Beatles style" for FreeBSD ports/INDEX, Satoshi Asami ]

                            /// Bram Moolenaar -- Bram@... -- http://www.Moolenaar.net \\\
                            /// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
                            \\\ an exciting new programming language -- http://www.Zimbu.org ///
                            \\\ help me help AIDS victims -- http://ICCF-Holland.org ///

                            --
                            --
                            You received this message from the "vim_dev" maillist.
                            Do not top-post! Type your reply below the text you are replying to.
                            For more information, visit http://www.vim.org/maillist.php

                            ---
                            You received this message because you are subscribed to the Google Groups "vim_dev" group.
                            To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscribe@....
                            For more options, visit https://groups.google.com/groups/opt_out.
                          • Bram Moolenaar
                            ... Thanks, I can reproduce that. It s very helpful to get a good reproducible example. -- Snoring is prohibited unless all bedroom windows are closed and
                            Message 13 of 25 , May 20 4:34 AM
                            • 0 Attachment
                              Taro Muraoka wrote:

                              > I got a report that 970 causes crash when do this:
                              >
                              > :echo search("[^A-z]")
                              >
                              > # reported at here in Japanese -> https://github.com/vim-jp/issues/issues/386
                              >
                              > Yasuhiro Matsumoto try to write a patch to fix this,
                              > but it seems that there are some other similar problems.

                              Thanks, I can reproduce that. It's very helpful to get a good
                              reproducible example.

                              --
                              Snoring is prohibited unless all bedroom windows are closed and securely
                              locked.
                              [real standing law in Massachusetts, United States of America]

                              /// Bram Moolenaar -- Bram@... -- http://www.Moolenaar.net \\\
                              /// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
                              \\\ an exciting new programming language -- http://www.Zimbu.org ///
                              \\\ help me help AIDS victims -- http://ICCF-Holland.org ///

                              --
                              --
                              You received this message from the "vim_dev" maillist.
                              Do not top-post! Type your reply below the text you are replying to.
                              For more information, visit http://www.vim.org/maillist.php

                              ---
                              You received this message because you are subscribed to the Google Groups "vim_dev" group.
                              To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscribe@....
                              For more options, visit https://groups.google.com/groups/opt_out.
                            • Bram Moolenaar
                              ... You can uncomment this line in regexp.c: /* #undef DEBUG */ -- Zen Microsystems: we re the om in .commmmmmmmm /// Bram Moolenaar -- Bram@Moolenaar.net --
                              Message 14 of 25 , May 20 4:34 AM
                              • 0 Attachment
                                Taro Muraoka wrote:

                                > This makes vim (debug build) slow to startup.
                                > New NFA engine seems to write huge log files in debug build.
                                > And it causes this terrible slow down.
                                >
                                > Added files are generated like this:
                                >
                                > gvim -u NONE -U NONE --noplugin --startuptime startuptime-7.3.XXX.txt
                                >
                                > I'll look into source codes later, but reported at first.

                                You can uncomment this line in regexp.c:

                                /* #undef DEBUG */


                                --
                                Zen Microsystems: we're the om in .commmmmmmmm

                                /// Bram Moolenaar -- Bram@... -- http://www.Moolenaar.net \\\
                                /// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
                                \\\ an exciting new programming language -- http://www.Zimbu.org ///
                                \\\ help me help AIDS victims -- http://ICCF-Holland.org ///

                                --
                                --
                                You received this message from the "vim_dev" maillist.
                                Do not top-post! Type your reply below the text you are replying to.
                                For more information, visit http://www.vim.org/maillist.php

                                ---
                                You received this message because you are subscribed to the Google Groups "vim_dev" group.
                                To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscribe@....
                                For more options, visit https://groups.google.com/groups/opt_out.
                              • Bram Moolenaar
                                ... The new engine is supposed to be faster. But we are not there yet. It might be that the new engine is only faster for repeating. It has more overhead
                                Message 15 of 25 , May 20 4:34 AM
                                • 0 Attachment
                                  Ben Fritz wrote:

                                  > On Sunday, May 19, 2013 12:44:49 PM UTC-5, Bram Moolenaar wrote:
                                  > > I wrote:
                                  > >
                                  > > > Patch 7.3.970
                                  > >
                                  > > All the tests I could do with the new engine pass. However, it is
                                  > >
                                  > > noticeable slower than the old engine. If this bothers you, set the
                                  > >
                                  > > 'regexpengine' option to one.
                                  > >
                                  >
                                  > Wasn't the main purpose of the new engine to speed things up? Or are
                                  > we sacrificing average speed for better worst-case speed?

                                  The new engine is supposed to be faster. But we are not there yet.

                                  It might be that the new engine is only faster for repeating. It has
                                  more overhead setting up the regexp. If we can't reduce the overhead we
                                  might have to select the engine when compiling the regexp.

                                  --
                                  So when I saw the post to comp.editors, I rushed over to the FTP site to
                                  grab it. So I yank apart the tarball, light x candles, where x= the
                                  vim version multiplied by the md5sum of the source divided by the MAC of
                                  my NIC (8A3FA78155A8A1D346C3C4A), put on black robes, dim the lights,
                                  wave a dead chicken over the hard drive, and summon the power of GNU GCC
                                  with the magic words "make config ; make!".
                                  [Jason Spence, compiling Vim 5.0]

                                  /// Bram Moolenaar -- Bram@... -- http://www.Moolenaar.net \\\
                                  /// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
                                  \\\ an exciting new programming language -- http://www.Zimbu.org ///
                                  \\\ help me help AIDS victims -- http://ICCF-Holland.org ///

                                  --
                                  --
                                  You received this message from the "vim_dev" maillist.
                                  Do not top-post! Type your reply below the text you are replying to.
                                  For more information, visit http://www.vim.org/maillist.php

                                  ---
                                  You received this message because you are subscribed to the Google Groups "vim_dev" group.
                                  To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscribe@....
                                  For more options, visit https://groups.google.com/groups/opt_out.
                                • Ron Aaron
                                  ... Just doing gvim --startuptime a.txt with regexpengine=0 and ... b.txt with it =1, shows about a second less time (e.g. faster) with =1 over =0 on my
                                  Message 16 of 25 , May 20 4:42 AM
                                  • 0 Attachment
                                    On Monday, May 20, 2013 2:34:14 PM UTC+3, Bram Moolenaar wrote:

                                    >
                                    > So the new engine is faster? Or what do the numbers mean?
                                    >
                                    >
                                    >
                                    > My experience is that the new engine is slower. Thus we have work to do
                                    >
                                    > to make it faster.

                                    Just doing "gvim --startuptime a.txt" with regexpengine=0 and "... b.txt" with it =1, shows about a second less time (e.g. faster) with =1 over =0 on my work box (64bit linux)

                                    --
                                    --
                                    You received this message from the "vim_dev" maillist.
                                    Do not top-post! Type your reply below the text you are replying to.
                                    For more information, visit http://www.vim.org/maillist.php

                                    ---
                                    You received this message because you are subscribed to the Google Groups "vim_dev" group.
                                    To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscribe@....
                                    For more options, visit https://groups.google.com/groups/opt_out.
                                  • Bram Moolenaar
                                    John Marriott wrote: [html removed] ... Thanks. That is a modern initialization construct, not supported by older compilers. -- Violators can be fined,
                                    Message 17 of 25 , May 20 4:55 AM
                                    • 0 Attachment
                                      John Marriott wrote:

                                      [html removed]

                                      > Attempting to compile on HP-UX fails after this patch with this
                                      > message:
                                      >
                                      > cc -c -I. -Iproto
                                      > -DHAVE_CONFIG_H -O2 -o objects/regexp.o regexp.c
                                      >
                                      > cc: "regexp_nfa.c",
                                      > line 1966: error 1521: Incorrect initialization.
                                      >
                                      >
                                      > It
                                      > seems that HP's cc doesn't like this initialisation:
                                      >
                                      > /*
                                      > * Initialize Frag_T struct.
                                      > */
                                      > static Frag_T
                                      > frag(start, out)
                                      > nfa_state_T *start;
                                      > Ptrlist *out;
                                      > {
                                      > Frag_T n = { start, out };
                                      > return n;
                                      > }
                                      >
                                      > After
                                      > changing it to:
                                      >
                                      > /*
                                      > * Initialize Frag_T struct.
                                      > */
                                      >
                                      > static Frag_T
                                      > frag(start, out)
                                      > nfa_state_T *start;
                                      > Ptrlist *out;
                                      > {
                                      > Frag_T n;
                                      >
                                      > n.start = start;
                                      > n.out = out;
                                      > return n;
                                      >
                                      > }
                                      >
                                      > It's happy again.

                                      Thanks. That is a modern initialization construct, not supported
                                      by older compilers.

                                      --
                                      Violators can be fined, arrested or jailed for making ugly faces at a dog.
                                      [real standing law in Oklahoma, United States of America]

                                      /// Bram Moolenaar -- Bram@... -- http://www.Moolenaar.net \\\
                                      /// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
                                      \\\ an exciting new programming language -- http://www.Zimbu.org ///
                                      \\\ help me help AIDS victims -- http://ICCF-Holland.org ///

                                      --
                                      --
                                      You received this message from the "vim_dev" maillist.
                                      Do not top-post! Type your reply below the text you are replying to.
                                      For more information, visit http://www.vim.org/maillist.php

                                      ---
                                      You received this message because you are subscribed to the Google Groups "vim_dev" group.
                                      To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscribe@....
                                      For more options, visit https://groups.google.com/groups/opt_out.
                                    • Karsten Hopp
                                      ... The patch in this mail and the one on the ftp site is broken. It contains the patch for src/testdir/Makefile twice. The mercurial patch 4444:ccecb03e5e8b
                                      Message 18 of 25 , May 21 5:17 AM
                                      • 0 Attachment
                                        Am 19.05.2013 19:15, schrieb Bram Moolenaar:
                                        > Patch 7.3.970
                                        > Problem: Syntax highlighting can be slow.
                                        > Solution: Include the NFA regexp engine. Add the 'regexpengine' option to
                                        > select which one is used. (various authors, including Ken Takata,
                                        > Andrei Aiordachioaie, Russ Cox, Xiaozhou Liua, Ian Young)
                                        > Files: src/Make_cyg.mak, src/Make_ming.mak, src/Make_mvc.mak,
                                        > src/Makefile, src/regexp.c, src/regexp.h, src/regexp_nfa.c,
                                        > src/structs.h, src/testdir/Makefile, src/testdir/test64.in,
                                        > src/testdir/test64.ok, Filelist, runtime/doc/pattern.txt,
                                        > runtime/doc/option.txt, src/option.c, src/option.h,
                                        > src/testdir/test95.in, src/testdir/test95.ok,
                                        > src/testdir/Make_amiga.mak, src/testdir/Make_dos.mak,
                                        > src/testdir/Make_ming.mak, src/testdir/Make_os2.mak,
                                        > src/testdir/Make_vms.mms, src/testdir/Makefile
                                        >
                                        >

                                        The patch in this mail and the one on the ftp site is broken. It contains the patch for src/testdir/Makefile twice.
                                        The mercurial patch 4444:ccecb03e5e8b (7.3.970) is ok.

                                        Karsten

                                        --
                                        --
                                        You received this message from the "vim_dev" maillist.
                                        Do not top-post! Type your reply below the text you are replying to.
                                        For more information, visit http://www.vim.org/maillist.php

                                        ---
                                        You received this message because you are subscribed to the Google Groups "vim_dev" group.
                                        To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscribe@....
                                        For more options, visit https://groups.google.com/groups/opt_out.
                                      • Bram Moolenaar
                                        ... Oops. I corrected the ftp site. Can t correct the email.. Obviously using Mercurial is the way to go these days. -- A fool must search for a greater fool
                                        Message 19 of 25 , May 21 6:55 AM
                                        • 0 Attachment
                                          Karsten Hopp wrote:

                                          > Am 19.05.2013 19:15, schrieb Bram Moolenaar:
                                          > > Patch 7.3.970
                                          > > Problem: Syntax highlighting can be slow.
                                          > > Solution: Include the NFA regexp engine. Add the 'regexpengine' option to
                                          > > select which one is used. (various authors, including Ken Takata,
                                          > > Andrei Aiordachioaie, Russ Cox, Xiaozhou Liua, Ian Young)
                                          > > Files: src/Make_cyg.mak, src/Make_ming.mak, src/Make_mvc.mak,
                                          > > src/Makefile, src/regexp.c, src/regexp.h, src/regexp_nfa.c,
                                          > > src/structs.h, src/testdir/Makefile, src/testdir/test64.in,
                                          > > src/testdir/test64.ok, Filelist, runtime/doc/pattern.txt,
                                          > > runtime/doc/option.txt, src/option.c, src/option.h,
                                          > > src/testdir/test95.in, src/testdir/test95.ok,
                                          > > src/testdir/Make_amiga.mak, src/testdir/Make_dos.mak,
                                          > > src/testdir/Make_ming.mak, src/testdir/Make_os2.mak,
                                          > > src/testdir/Make_vms.mms, src/testdir/Makefile
                                          > >
                                          > >
                                          >
                                          > The patch in this mail and the one on the ftp site is broken. It
                                          > contains the patch for src/testdir/Makefile twice.
                                          > The mercurial patch 4444:ccecb03e5e8b (7.3.970) is ok.

                                          Oops. I corrected the ftp site. Can't correct the email..

                                          Obviously using Mercurial is the way to go these days.

                                          --
                                          A fool must search for a greater fool to find admiration.

                                          /// Bram Moolenaar -- Bram@... -- http://www.Moolenaar.net \\\
                                          /// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
                                          \\\ an exciting new programming language -- http://www.Zimbu.org ///
                                          \\\ help me help AIDS victims -- http://ICCF-Holland.org ///

                                          --
                                          --
                                          You received this message from the "vim_dev" maillist.
                                          Do not top-post! Type your reply below the text you are replying to.
                                          For more information, visit http://www.vim.org/maillist.php

                                          ---
                                          You received this message because you are subscribed to the Google Groups "vim_dev" group.
                                          To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscribe@....
                                          For more options, visit https://groups.google.com/groups/opt_out.
                                        Your message has been successfully submitted and would be delivered to recipients shortly.