Loading ...
Sorry, an error occurred while loading the content.
 

Re: [PATCH] (15/?) Python interface improvements: transform BufList into BufMap

Expand Messages
  • ZyX
    ... I am talking only about python exceptions. Except for possible Unicode*† errors there is not much difference between translated and not translated
    Message 1 of 49 , Apr 29, 2013
      > The messages starting with "E123: " should be translated.
      > Internal messages, for developers only, do not need to be translated.
      > For others: Generally it's good to translate messages.

      I am talking only about python exceptions. Except for possible Unicode*† errors there is not much difference between translated and not translated messages: exceptions are caught by class object‡, not by message. If somebody has to parse exception message it only means that there is a problem with API design. I can’t say whether python exceptions should be considered internal or not internal messages.

      † Like [“Logging messages cause UnicodeDecodeError in Windows non-latin version”](https://github.com/Lokaltog/powerline/issues/421) (this is about translated errno messages, not about vim exceptions; would be the same for vim if there was a case when such exceptions are thrown). You can use ASCII message and be sure it will work with any logger and is convertable to any used encoding, but you can’t say the same for, e.g., Russian text.

      ‡ Which is another reason to drop old pythons: string exceptions are long since deprecated: Exception base class appeared in far 1.5 version.

      --
      --
      You received this message from the "vim_dev" maillist.
      Do not top-post! Type your reply below the text you are replying to.
      For more information, visit http://www.vim.org/maillist.php

      ---
      You received this message because you are subscribed to the Google Groups "vim_dev" group.
      To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscribe@....
      For more options, visit https://groups.google.com/groups/opt_out.
    • ZyX
      ... Because you have problems with encoding somewhere: there were no question marks in the patch, but Russian text. I just was not aware of the strange choice:
      Message 49 of 49 , May 15, 2013
        > After including this patch the tests were failing. The .ok files had
        > "????" where the test results in "window". I assume those question
        > marks were wrong, so I fixed the .ok files for that. But I wonder why
        > this happened.

        Because you have problems with encoding somewhere: there were no question marks in the patch, but Russian text. I just was not aware of the strange choice: using translated strings in `repr()`. I think translated messages here are just as “good” as translated exceptions; needless to say I have never seen them translated in other projects.

        --
        --
        You received this message from the "vim_dev" maillist.
        Do not top-post! Type your reply below the text you are replying to.
        For more information, visit http://www.vim.org/maillist.php

        ---
        You received this message because you are subscribed to the Google Groups "vim_dev" group.
        To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscribe@....
        For more options, visit https://groups.google.com/groups/opt_out.
      Your message has been successfully submitted and would be delivered to recipients shortly.