Loading ...
Sorry, an error occurred while loading the content.

[PATCH] Syntax: dts: highlight nodes with addresses

Expand Messages
  • Markus Pargmann
    Small improvement to highlight nodes with addresses in devicetree files. Signed-off-by: Markus Pargmann ... runtime/syntax/dts.vim | 2
    Message 1 of 13 , Mar 8 2:10 PM
    • 0 Attachment
      Small improvement to highlight nodes with addresses in devicetree files.

      Signed-off-by: Markus Pargmann <mpargmann@...>
      ---
      runtime/syntax/dts.vim | 2 ++
      1 file changed, 2 insertions(+)

      diff --git a/runtime/syntax/dts.vim b/runtime/syntax/dts.vim
      index 84e37ae..838e13e 100644
      --- a/runtime/syntax/dts.vim
      +++ b/runtime/syntax/dts.vim
      @@ -13,6 +13,7 @@ syntax region dtsBinaryProperty start="\[" end="\]"
      syntax match dtsStringProperty "\".*\""
      syntax match dtsKeyword "/.*/"
      syntax match dtsLabel "^[[:space:]]*[[:alpha:][:digit:]_]\+:"
      +syntax match dtsNode "[[:alpha:][:digit:]-_]\+@[0-9a-eA-E]\+"
      syntax region dtsCellProperty start="<" end=">" contains=dtsReference,dtsBinaryProperty,dtsStringProperty,dtsComment
      syntax region dtsCommentInner start="/\*" end="\*/"

      @@ -21,6 +22,7 @@ hi def link dtsBinaryProperty Number
      hi def link dtsStringProperty String
      hi def link dtsKeyword Include
      hi def link dtsLabel Label
      +hi def link dtsNode Structure
      hi def link dtsReference Macro
      hi def link dtsComment Comment
      hi def link dtsCommentInner Comment
      --
      1.8.1.4

      --
      --
      You received this message from the "vim_dev" maillist.
      Do not top-post! Type your reply below the text you are replying to.
      For more information, visit http://www.vim.org/maillist.php

      ---
      You received this message because you are subscribed to the Google Groups "vim_dev" group.
      To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscribe@....
      For more options, visit https://groups.google.com/groups/opt_out.
    • Bram Moolenaar
      ... Copied to the maintainer. ... -- To define recursion, we must first define recursion. /// Bram Moolenaar -- Bram@Moolenaar.net -- http://www.Moolenaar.net
      Message 2 of 13 , Mar 9 4:41 AM
      • 0 Attachment
        Markus Pargmann wrote:

        > Small improvement to highlight nodes with addresses in devicetree files.

        Copied to the maintainer.

        > Signed-off-by: Markus Pargmann <mpargmann@...>
        > ---
        > runtime/syntax/dts.vim | 2 ++
        > 1 file changed, 2 insertions(+)
        >
        > diff --git a/runtime/syntax/dts.vim b/runtime/syntax/dts.vim
        > index 84e37ae..838e13e 100644
        > --- a/runtime/syntax/dts.vim
        > +++ b/runtime/syntax/dts.vim
        > @@ -13,6 +13,7 @@ syntax region dtsBinaryProperty start="\[" end="\]"
        > syntax match dtsStringProperty "\".*\""
        > syntax match dtsKeyword "/.*/"
        > syntax match dtsLabel "^[[:space:]]*[[:alpha:][:digit:]_]\+:"
        > +syntax match dtsNode "[[:alpha:][:digit:]-_]\+@[0-9a-eA-E]\+"
        > syntax region dtsCellProperty start="<" end=">" contains=dtsReference,dtsBinaryProperty,dtsStringProperty,dtsComment
        > syntax region dtsCommentInner start="/\*" end="\*/"
        >
        > @@ -21,6 +22,7 @@ hi def link dtsBinaryProperty Number
        > hi def link dtsStringProperty String
        > hi def link dtsKeyword Include
        > hi def link dtsLabel Label
        > +hi def link dtsNode Structure
        > hi def link dtsReference Macro
        > hi def link dtsComment Comment
        > hi def link dtsCommentInner Comment
        > --
        > 1.8.1.4

        --
        To define recursion, we must first define recursion.

        /// Bram Moolenaar -- Bram@... -- http://www.Moolenaar.net \\\
        /// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
        \\\ an exciting new programming language -- http://www.Zimbu.org ///
        \\\ help me help AIDS victims -- http://ICCF-Holland.org ///

        --
        --
        You received this message from the "vim_dev" maillist.
        Do not top-post! Type your reply below the text you are replying to.
        For more information, visit http://www.vim.org/maillist.php

        ---
        You received this message because you are subscribed to the Google Groups "vim_dev" group.
        To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscribe@....
        For more options, visit https://groups.google.com/groups/opt_out.
      • Daniel Mack
        Hi Markus, ... Can you give me an example of such a node, so I can reproduce this here and test you patch? Thanks, Daniel ... -- -- You received this message
        Message 3 of 13 , Mar 9 6:07 AM
        • 0 Attachment
          Hi Markus,

          On 09.03.2013 13:41, Bram Moolenaar wrote:
          >
          > Markus Pargmann wrote:
          >
          >> Small improvement to highlight nodes with addresses in devicetree files.

          Can you give me an example of such a node, so I can reproduce this here
          and test you patch?


          Thanks,
          Daniel


          >
          > Copied to the maintainer.
          >
          >> Signed-off-by: Markus Pargmann <mpargmann@...>
          >> ---
          >> runtime/syntax/dts.vim | 2 ++
          >> 1 file changed, 2 insertions(+)
          >>
          >> diff --git a/runtime/syntax/dts.vim b/runtime/syntax/dts.vim
          >> index 84e37ae..838e13e 100644
          >> --- a/runtime/syntax/dts.vim
          >> +++ b/runtime/syntax/dts.vim
          >> @@ -13,6 +13,7 @@ syntax region dtsBinaryProperty start="\[" end="\]"
          >> syntax match dtsStringProperty "\".*\""
          >> syntax match dtsKeyword "/.*/"
          >> syntax match dtsLabel "^[[:space:]]*[[:alpha:][:digit:]_]\+:"
          >> +syntax match dtsNode "[[:alpha:][:digit:]-_]\+@[0-9a-eA-E]\+"
          >> syntax region dtsCellProperty start="<" end=">" contains=dtsReference,dtsBinaryProperty,dtsStringProperty,dtsComment
          >> syntax region dtsCommentInner start="/\*" end="\*/"
          >>
          >> @@ -21,6 +22,7 @@ hi def link dtsBinaryProperty Number
          >> hi def link dtsStringProperty String
          >> hi def link dtsKeyword Include
          >> hi def link dtsLabel Label
          >> +hi def link dtsNode Structure
          >> hi def link dtsReference Macro
          >> hi def link dtsComment Comment
          >> hi def link dtsCommentInner Comment
          >> --
          >> 1.8.1.4
          >

          --
          --
          You received this message from the "vim_dev" maillist.
          Do not top-post! Type your reply below the text you are replying to.
          For more information, visit http://www.vim.org/maillist.php

          ---
          You received this message because you are subscribed to the Google Groups "vim_dev" group.
          To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscribe@....
          For more options, visit https://groups.google.com/groups/opt_out.
        • Markus Pargmann
          Hi Daniel, ... The first one is an example for nodes without addresses, so not highlighted. The second one has an address in its name ( @10001000 ). clocks {
          Message 4 of 13 , Mar 9 6:26 AM
          • 0 Attachment
            Hi Daniel,

            On Sat, Mar 09, 2013 at 03:07:35PM +0100, Daniel Mack wrote:
            > Hi Markus,
            >
            > On 09.03.2013 13:41, Bram Moolenaar wrote:
            > >
            > > Markus Pargmann wrote:
            > >
            > >> Small improvement to highlight nodes with addresses in devicetree files.
            >
            > Can you give me an example of such a node, so I can reproduce this here
            > and test you patch?

            The first one is an example for nodes without addresses, so not
            highlighted. The second one has an address in its name ('@10001000').

            clocks {
            #address-cells = <1>;
            #size-cells = <0>;

            osc26m {
            compatible = "fsl,imx-osc26m", "fixed-clock";
            clock-frequency = <26000000>;
            };
            };

            dma: dma@10001000 {
            compatible = "fsl,imx27-dma";
            reg = <0x10001000 0x1000>;
            interrupts = <32 33>;
            clocks = <&clks 50>, <&clks 70>;
            clock-names = "ipg", "ahb";
            #dma-cells = <1>;
            dma-channels = <16>;
            };

            Regards,

            Markus

            >
            >
            > Thanks,
            > Daniel
            >
            >
            > >
            > > Copied to the maintainer.
            > >
            > >> Signed-off-by: Markus Pargmann <mpargmann@...>
            > >> ---
            > >> runtime/syntax/dts.vim | 2 ++
            > >> 1 file changed, 2 insertions(+)
            > >>
            > >> diff --git a/runtime/syntax/dts.vim b/runtime/syntax/dts.vim
            > >> index 84e37ae..838e13e 100644
            > >> --- a/runtime/syntax/dts.vim
            > >> +++ b/runtime/syntax/dts.vim
            > >> @@ -13,6 +13,7 @@ syntax region dtsBinaryProperty start="\[" end="\]"
            > >> syntax match dtsStringProperty "\".*\""
            > >> syntax match dtsKeyword "/.*/"
            > >> syntax match dtsLabel "^[[:space:]]*[[:alpha:][:digit:]_]\+:"
            > >> +syntax match dtsNode "[[:alpha:][:digit:]-_]\+@[0-9a-eA-E]\+"
            > >> syntax region dtsCellProperty start="<" end=">" contains=dtsReference,dtsBinaryProperty,dtsStringProperty,dtsComment
            > >> syntax region dtsCommentInner start="/\*" end="\*/"
            > >>
            > >> @@ -21,6 +22,7 @@ hi def link dtsBinaryProperty Number
            > >> hi def link dtsStringProperty String
            > >> hi def link dtsKeyword Include
            > >> hi def link dtsLabel Label
            > >> +hi def link dtsNode Structure
            > >> hi def link dtsReference Macro
            > >> hi def link dtsComment Comment
            > >> hi def link dtsCommentInner Comment
            > >> --
            > >> 1.8.1.4
            > >
            >

            --
            --
            You received this message from the "vim_dev" maillist.
            Do not top-post! Type your reply below the text you are replying to.
            For more information, visit http://www.vim.org/maillist.php

            ---
            You received this message because you are subscribed to the Google Groups "vim_dev" group.
            To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscribe@....
            For more options, visit https://groups.google.com/groups/opt_out.
          • Daniel Mack
            Hi Markus, ... Hmm, why wouldn t you want them *all* highlighted? Wouldn t that be even nicer? IOW, why not treat all symbols that are followed by a { as a
            Message 5 of 13 , Mar 9 6:32 AM
            • 0 Attachment
              Hi Markus,

              On 09.03.2013 15:26, Markus Pargmann wrote:
              > On Sat, Mar 09, 2013 at 03:07:35PM +0100, Daniel Mack wrote:
              >> Hi Markus,
              >>
              >> On 09.03.2013 13:41, Bram Moolenaar wrote:
              >>>
              >>> Markus Pargmann wrote:
              >>>
              >>>> Small improvement to highlight nodes with addresses in devicetree files.
              >>
              >> Can you give me an example of such a node, so I can reproduce this here
              >> and test you patch?
              >
              > The first one is an example for nodes without addresses, so not
              > highlighted. The second one has an address in its name ('@10001000').

              Hmm, why wouldn't you want them *all* highlighted? Wouldn't that be even
              nicer? IOW, why not treat all symbols that are followed by a "{" as a node?


              Thanks,
              Daniel

              --
              --
              You received this message from the "vim_dev" maillist.
              Do not top-post! Type your reply below the text you are replying to.
              For more information, visit http://www.vim.org/maillist.php

              ---
              You received this message because you are subscribed to the Google Groups "vim_dev" group.
              To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscribe@....
              For more options, visit https://groups.google.com/groups/opt_out.
            • Daniel Mack
              ... Nice :) Acked-by: Daniel Mack Thanks, Daniel ... -- -- You received this message from the vim_dev maillist. Do not top-post! Type
              Message 6 of 13 , Mar 11 11:36 AM
              • 0 Attachment
                On 11.03.2013 20:29, Markus Pargmann wrote:
                > Small improvement to highlight nodes with addresses in devicetree files.
                >
                > Signed-off-by: Markus Pargmann <mpargmann@...>

                Nice :)

                Acked-by: Daniel Mack <daniel@...>


                Thanks,
                Daniel


                > ---
                >
                > Changes in v2:
                > - Highlight all nodes, not only those with an address
                >
                > runtime/syntax/dts.vim | 2 ++
                > 1 file changed, 2 insertions(+)
                >
                > diff --git a/runtime/syntax/dts.vim b/runtime/syntax/dts.vim
                > index 84e37ae..a941707 100644
                > --- a/runtime/syntax/dts.vim
                > +++ b/runtime/syntax/dts.vim
                > @@ -13,6 +13,7 @@ syntax region dtsBinaryProperty start="\[" end="\]"
                > syntax match dtsStringProperty "\".*\""
                > syntax match dtsKeyword "/.*/"
                > syntax match dtsLabel "^[[:space:]]*[[:alpha:][:digit:]_]\+:"
                > +syntax match dtsNode /[[:alpha:][:digit:]-_]\+\(@[0-9a-eA-E]\+\|\)[[:space:]]*{/he=e-1
                > syntax region dtsCellProperty start="<" end=">" contains=dtsReference,dtsBinaryProperty,dtsStringProperty,dtsComment
                > syntax region dtsCommentInner start="/\*" end="\*/"
                >
                > @@ -21,6 +22,7 @@ hi def link dtsBinaryProperty Number
                > hi def link dtsStringProperty String
                > hi def link dtsKeyword Include
                > hi def link dtsLabel Label
                > +hi def link dtsNode Structure
                > hi def link dtsReference Macro
                > hi def link dtsComment Comment
                > hi def link dtsCommentInner Comment
                >

                --
                --
                You received this message from the "vim_dev" maillist.
                Do not top-post! Type your reply below the text you are replying to.
                For more information, visit http://www.vim.org/maillist.php

                ---
                You received this message because you are subscribed to the Google Groups "vim_dev" group.
                To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscribe@....
                For more options, visit https://groups.google.com/groups/opt_out.
              • Markus Pargmann
                Hi Daniel, ... Yes you are right, matching all of them is probably nicer. But I don t think we should treat all names inside a block as nodes. Most of the
                Message 7 of 13 , Mar 11 12:27 PM
                • 0 Attachment
                  Hi Daniel,

                  On Sat, Mar 09, 2013 at 03:32:39PM +0100, Daniel Mack wrote:
                  > Hi Markus,
                  >
                  > On 09.03.2013 15:26, Markus Pargmann wrote:
                  > > On Sat, Mar 09, 2013 at 03:07:35PM +0100, Daniel Mack wrote:
                  > >> Hi Markus,
                  > >>
                  > >> On 09.03.2013 13:41, Bram Moolenaar wrote:
                  > >>>
                  > >>> Markus Pargmann wrote:
                  > >>>
                  > >>>> Small improvement to highlight nodes with addresses in devicetree files.
                  > >>
                  > >> Can you give me an example of such a node, so I can reproduce this here
                  > >> and test you patch?
                  > >
                  > > The first one is an example for nodes without addresses, so not
                  > > highlighted. The second one has an address in its name ('@10001000').
                  >
                  > Hmm, why wouldn't you want them *all* highlighted? Wouldn't that be even
                  > nicer? IOW, why not treat all symbols that are followed by a "{" as a node?

                  Yes you are right, matching all of them is probably nicer. But I don't
                  think we should treat all names inside a block as nodes. Most of the
                  items are properties.

                  Regards,

                  Markus

                  --
                  --
                  You received this message from the "vim_dev" maillist.
                  Do not top-post! Type your reply below the text you are replying to.
                  For more information, visit http://www.vim.org/maillist.php

                  ---
                  You received this message because you are subscribed to the Google Groups "vim_dev" group.
                  To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscribe@....
                  For more options, visit https://groups.google.com/groups/opt_out.
                • Markus Pargmann
                  Small improvement to highlight nodes with addresses in devicetree files. Signed-off-by: Markus Pargmann ... Changes in v2: - Highlight
                  Message 8 of 13 , Mar 11 12:29 PM
                  • 0 Attachment
                    Small improvement to highlight nodes with addresses in devicetree files.

                    Signed-off-by: Markus Pargmann <mpargmann@...>
                    ---

                    Changes in v2:
                    - Highlight all nodes, not only those with an address

                    runtime/syntax/dts.vim | 2 ++
                    1 file changed, 2 insertions(+)

                    diff --git a/runtime/syntax/dts.vim b/runtime/syntax/dts.vim
                    index 84e37ae..a941707 100644
                    --- a/runtime/syntax/dts.vim
                    +++ b/runtime/syntax/dts.vim
                    @@ -13,6 +13,7 @@ syntax region dtsBinaryProperty start="\[" end="\]"
                    syntax match dtsStringProperty "\".*\""
                    syntax match dtsKeyword "/.*/"
                    syntax match dtsLabel "^[[:space:]]*[[:alpha:][:digit:]_]\+:"
                    +syntax match dtsNode /[[:alpha:][:digit:]-_]\+\(@[0-9a-eA-E]\+\|\)[[:space:]]*{/he=e-1
                    syntax region dtsCellProperty start="<" end=">" contains=dtsReference,dtsBinaryProperty,dtsStringProperty,dtsComment
                    syntax region dtsCommentInner start="/\*" end="\*/"

                    @@ -21,6 +22,7 @@ hi def link dtsBinaryProperty Number
                    hi def link dtsStringProperty String
                    hi def link dtsKeyword Include
                    hi def link dtsLabel Label
                    +hi def link dtsNode Structure
                    hi def link dtsReference Macro
                    hi def link dtsComment Comment
                    hi def link dtsCommentInner Comment
                    --
                    1.8.1.5

                    --
                    --
                    You received this message from the "vim_dev" maillist.
                    Do not top-post! Type your reply below the text you are replying to.
                    For more information, visit http://www.vim.org/maillist.php

                    ---
                    You received this message because you are subscribed to the Google Groups "vim_dev" group.
                    To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscribe@....
                    For more options, visit https://groups.google.com/groups/opt_out.
                  • Daniel Mack
                    ... That sounds about right. Acked-by: Daniel Mack ... Sorry for not seeing it either :) Daniel ... -- -- You received this message from the
                    Message 9 of 13 , Mar 25 2:39 PM
                    • 0 Attachment
                      On 25.03.2013 22:51, Markus Pargmann wrote:
                      > Hexadecimal numbers are actually going from a-f not a-e.
                      >
                      > Signed-off-by: Markus Pargmann <mpargmann@...>

                      That sounds about right.

                      Acked-by: Daniel Mack <zonque@...>

                      > ---
                      >
                      > Sorry for this. I should have noticed this bug before.

                      Sorry for not seeing it either :)


                      Daniel


                      >
                      > runtime/syntax/dts.vim | 2 +-
                      > 1 file changed, 1 insertion(+), 1 deletion(-)
                      >
                      > diff --git a/runtime/syntax/dts.vim b/runtime/syntax/dts.vim
                      > index 62764ca..42cb822 100644
                      > --- a/runtime/syntax/dts.vim
                      > +++ b/runtime/syntax/dts.vim
                      > @@ -13,7 +13,7 @@ syntax region dtsBinaryProperty start="\[" end="\]"
                      > syntax match dtsStringProperty "\".*\""
                      > syntax match dtsKeyword "/.*/"
                      > syntax match dtsLabel "^[[:space:]]*[[:alpha:][:digit:]_]\+:"
                      > -syntax match dtsNode /[[:alpha:][:digit:]-_]\+\(@[0-9a-eA-E]\+\|\)[[:space:]]*{/he=e-1
                      > +syntax match dtsNode /[[:alpha:][:digit:]-_]\+\(@[0-9a-fA-F]\+\|\)[[:space:]]*{/he=e-1
                      > syntax region dtsCellProperty start="<" end=">" contains=dtsReference,dtsBinaryProperty,dtsStringProperty,dtsComment
                      > syntax region dtsCommentInner start="/\*" end="\*/"
                      >
                      >

                      --
                      --
                      You received this message from the "vim_dev" maillist.
                      Do not top-post! Type your reply below the text you are replying to.
                      For more information, visit http://www.vim.org/maillist.php

                      ---
                      You received this message because you are subscribed to the Google Groups "vim_dev" group.
                      To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscribe@....
                      For more options, visit https://groups.google.com/groups/opt_out.
                    • Markus Pargmann
                      Hexadecimal numbers are actually going from a-f not a-e. Signed-off-by: Markus Pargmann ... Sorry for this. I should have noticed this
                      Message 10 of 13 , Mar 25 2:51 PM
                      • 0 Attachment
                        Hexadecimal numbers are actually going from a-f not a-e.

                        Signed-off-by: Markus Pargmann <mpargmann@...>
                        ---

                        Sorry for this. I should have noticed this bug before.

                        Regards

                        Markus


                        runtime/syntax/dts.vim | 2 +-
                        1 file changed, 1 insertion(+), 1 deletion(-)

                        diff --git a/runtime/syntax/dts.vim b/runtime/syntax/dts.vim
                        index 62764ca..42cb822 100644
                        --- a/runtime/syntax/dts.vim
                        +++ b/runtime/syntax/dts.vim
                        @@ -13,7 +13,7 @@ syntax region dtsBinaryProperty start="\[" end="\]"
                        syntax match dtsStringProperty "\".*\""
                        syntax match dtsKeyword "/.*/"
                        syntax match dtsLabel "^[[:space:]]*[[:alpha:][:digit:]_]\+:"
                        -syntax match dtsNode /[[:alpha:][:digit:]-_]\+\(@[0-9a-eA-E]\+\|\)[[:space:]]*{/he=e-1
                        +syntax match dtsNode /[[:alpha:][:digit:]-_]\+\(@[0-9a-fA-F]\+\|\)[[:space:]]*{/he=e-1
                        syntax region dtsCellProperty start="<" end=">" contains=dtsReference,dtsBinaryProperty,dtsStringProperty,dtsComment
                        syntax region dtsCommentInner start="/\*" end="\*/"

                        --
                        1.8.1.5

                        --
                        --
                        You received this message from the "vim_dev" maillist.
                        Do not top-post! Type your reply below the text you are replying to.
                        For more information, visit http://www.vim.org/maillist.php

                        ---
                        You received this message because you are subscribed to the Google Groups "vim_dev" group.
                        To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscribe@....
                        For more options, visit https://groups.google.com/groups/opt_out.
                      • Bram Moolenaar
                        ... If you make improvements to a runtime file, please send me the new version. I don t like hunting around for the right patches, I prefer the maintainer to
                        Message 11 of 13 , Mar 26 4:30 AM
                        • 0 Attachment
                          Daniel Mack wrote:

                          > On 25.03.2013 22:51, Markus Pargmann wrote:
                          > > Hexadecimal numbers are actually going from a-f not a-e.
                          > >
                          > > Signed-off-by: Markus Pargmann <mpargmann@...>
                          >
                          > That sounds about right.
                          >
                          > Acked-by: Daniel Mack <zonque@...>
                          >
                          > > ---
                          > >
                          > > Sorry for this. I should have noticed this bug before.
                          >
                          > Sorry for not seeing it either :)

                          If you make improvements to a runtime file, please send me the new
                          version. I don't like hunting around for the right patches, I prefer
                          the maintainer to send me the right version.

                          --
                          Bare feet magnetize sharp metal objects so they point upward from the
                          floor -- especially in the dark.

                          /// Bram Moolenaar -- Bram@... -- http://www.Moolenaar.net \\\
                          /// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
                          \\\ an exciting new programming language -- http://www.Zimbu.org ///
                          \\\ help me help AIDS victims -- http://ICCF-Holland.org ///

                          --
                          --
                          You received this message from the "vim_dev" maillist.
                          Do not top-post! Type your reply below the text you are replying to.
                          For more information, visit http://www.vim.org/maillist.php

                          ---
                          You received this message because you are subscribed to the Google Groups "vim_dev" group.
                          To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscribe@....
                          For more options, visit https://groups.google.com/groups/opt_out.
                        • Daniel Mack
                          Hi Bram, ... Ok. I thought it was much easier for you to just take the patch, given that you also get the commit log and authorship for free. But anyway, the
                          Message 12 of 13 , Mar 26 4:42 AM
                          • 0 Attachment
                            Hi Bram,

                            On 26.03.2013 12:30, Bram Moolenaar wrote:
                            > Daniel Mack wrote:
                            >
                            >> On 25.03.2013 22:51, Markus Pargmann wrote:
                            >>> Hexadecimal numbers are actually going from a-f not a-e.
                            >>>
                            >>> Signed-off-by: Markus Pargmann <mpargmann@...>
                            >>
                            >> That sounds about right.
                            >>
                            >> Acked-by: Daniel Mack <zonque@...>
                            >>
                            >>> ---
                            >>>
                            >>> Sorry for this. I should have noticed this bug before.
                            >>
                            >> Sorry for not seeing it either :)
                            >
                            > If you make improvements to a runtime file, please send me the new
                            > version. I don't like hunting around for the right patches, I prefer
                            > the maintainer to send me the right version.

                            Ok. I thought it was much easier for you to just take the patch, given
                            that you also get the commit log and authorship for free. But anyway,
                            the file is attached.


                            Thanks,
                            Daniel


                            --
                            --
                            You received this message from the "vim_dev" maillist.
                            Do not top-post! Type your reply below the text you are replying to.
                            For more information, visit http://www.vim.org/maillist.php

                            ---
                            You received this message because you are subscribed to the Google Groups "vim_dev" group.
                            To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscribe@....
                            For more options, visit https://groups.google.com/groups/opt_out.
                          • Bram Moolenaar
                            ... Thanks! I ll include it next week. -- I AM THANKFUL... ...for all the complaining I hear about the government because it means we have freedom of speech.
                            Message 13 of 13 , Mar 26 3:20 PM
                            • 0 Attachment
                              Daniel Mack wrote:

                              > On 26.03.2013 12:30, Bram Moolenaar wrote:
                              > > Daniel Mack wrote:
                              > >
                              > >> On 25.03.2013 22:51, Markus Pargmann wrote:
                              > >>> Hexadecimal numbers are actually going from a-f not a-e.
                              > >>>
                              > >>> Signed-off-by: Markus Pargmann <mpargmann@...>
                              > >>
                              > >> That sounds about right.
                              > >>
                              > >> Acked-by: Daniel Mack <zonque@...>
                              > >>
                              > >>> ---
                              > >>>
                              > >>> Sorry for this. I should have noticed this bug before.
                              > >>
                              > >> Sorry for not seeing it either :)
                              > >
                              > > If you make improvements to a runtime file, please send me the new
                              > > version. I don't like hunting around for the right patches, I prefer
                              > > the maintainer to send me the right version.
                              >
                              > Ok. I thought it was much easier for you to just take the patch, given
                              > that you also get the commit log and authorship for free. But anyway,
                              > the file is attached.

                              Thanks! I'll include it next week.

                              --
                              I AM THANKFUL...
                              ...for all the complaining I hear about the government
                              because it means we have freedom of speech.

                              /// Bram Moolenaar -- Bram@... -- http://www.Moolenaar.net \\\
                              /// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
                              \\\ an exciting new programming language -- http://www.Zimbu.org ///
                              \\\ help me help AIDS victims -- http://ICCF-Holland.org ///

                              --
                              --
                              You received this message from the "vim_dev" maillist.
                              Do not top-post! Type your reply below the text you are replying to.
                              For more information, visit http://www.vim.org/maillist.php

                              ---
                              You received this message because you are subscribed to the Google Groups "vim_dev" group.
                              To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscribe@....
                              For more options, visit https://groups.google.com/groups/opt_out.
                            Your message has been successfully submitted and would be delivered to recipients shortly.