Loading ...
Sorry, an error occurred while loading the content.

Re: Patch: :sort // doesn't handle the case where there is no last pattern

Expand Messages
  • Bram Moolenaar
    ... Thanks, I ll look into it soon. -- I have a drinking problem -- I don t have a drink! /// Bram Moolenaar -- Bram@Moolenaar.net -- http://www.Moolenaar.net
    Message 1 of 2 , Mar 4, 2013
      David B├╝rgin wrote:

      > Like :s//string/ and :g//, :sort // uses the last search pattern when no
      > pattern is given. Unlike :s and :g it doesn't handle well the case where
      > there is no last search pattern.
      > The attached patch fixes this.
      > Details
      > -------
      > When there is no last search pattern (e.g. on a new installation or when
      > no viminfo file is present), :s//string/ and :g// both abort with
      > E35: No previous regular expression
      > E476: Invalid command
      > In :sort, this situation isn't handled carefully enough: "//" is
      > actually compiled to an empty regular expression. Output of regdump():
      > regcomp():
      > 1:BRANCH(7)
      > 4:NOTHING(7)
      > 7:END(0)
      > This is not part of the advertised behaviour: "If {pattern} is empty
      > (e.g. // is specified), the last search pattern is used." The patch
      > makes :sort // follow the example of :s and :g and bail out with E35
      > when necessary.

      Thanks, I'll look into it soon.

      I have a drinking problem -- I don't have a drink!

      /// Bram Moolenaar -- Bram@... -- http://www.Moolenaar.net \\\
      /// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
      \\\ an exciting new programming language -- http://www.Zimbu.org ///
      \\\ help me help AIDS victims -- http://ICCF-Holland.org ///

      You received this message from the "vim_dev" maillist.
      Do not top-post! Type your reply below the text you are replying to.
      For more information, visit http://www.vim.org/maillist.php

      You received this message because you are subscribed to the Google Groups "vim_dev" group.
      To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscribe@....
      For more options, visit https://groups.google.com/groups/opt_out.
    Your message has been successfully submitted and would be delivered to recipients shortly.