Loading ...
Sorry, an error occurred while loading the content.

Re: Patch 7.3.841

Expand Messages
  • Bram Moolenaar
    ... Ah, missed the warning. Thanks. -- A consultant is a person who takes your money and annoys your employees while tirelessly searching for the best way to
    Message 1 of 5 , Feb 26, 2013
    • 0 Attachment
      Christian Brabandt wrote:

      > On Di, 26 Feb 2013, Bram Moolenaar wrote:
      >
      > > + rettv->vval.v_string = vim_strsave("");
      >
      > I just got a warning from this line. I think, this should be
      >
      > diff --git a/src/eval.c b/src/eval.c
      > --- a/src/eval.c
      > +++ b/src/eval.c
      > @@ -5170,7 +5170,7 @@
      > * what follows. So set it here. */
      > if (rettv->v_type == VAR_UNKNOWN && !evaluate && **arg == '(')
      > {
      > - rettv->vval.v_string = vim_strsave("");
      > + rettv->vval.v_string = vim_strsave((char_u *)"");
      > rettv->v_type = VAR_FUNC;
      > }
      >

      Ah, missed the warning. Thanks.

      --
      A consultant is a person who takes your money and annoys your employees while
      tirelessly searching for the best way to extend the consulting contract.
      (Scott Adams - The Dilbert principle)

      /// Bram Moolenaar -- Bram@... -- http://www.Moolenaar.net \\\
      /// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
      \\\ an exciting new programming language -- http://www.Zimbu.org ///
      \\\ help me help AIDS victims -- http://ICCF-Holland.org ///

      --
      --
      You received this message from the "vim_dev" maillist.
      Do not top-post! Type your reply below the text you are replying to.
      For more information, visit http://www.vim.org/maillist.php

      ---
      You received this message because you are subscribed to the Google Groups "vim_dev" group.
      To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscribe@....
      For more options, visit https://groups.google.com/groups/opt_out.
    • Bram Moolenaar
      ... Missing /testdir . Didn t notice diff omitted those two files. Will make another patch then. ... Fixed in 7.3.842. -- The average life of an organization
      Message 2 of 5 , Feb 26, 2013
      • 0 Attachment
        Tony Mechelynck wrote:

        > On 26/02/13 19:36, Bram Moolenaar wrote:
        > >
        > > Patch 7.3.841
        > > Problem: When a "cond ? one : two" expression has a subscript it is not
        > > parsed correctly. (Andy Wokula)
        > > Solution: Handle a subscript also when the type is unknown. (Christian
        > > Brabandt)
        > > Files: src/eval.c, src/test49.vim, src/test49.ok
        > --------------------------------^
        > src/version.c is also changed (by adding the patch number) but
        > src/test49.* aren't changed by the patch. :-?

        Missing "/testdir". Didn't notice diff omitted those two files.
        Will make another patch then.

        > "hg -incoming" correctly mentioned only src/eval.c src/version.c
        >
        > [...]
        >
        > I get the following in the compile for "Huge" vim but no message for
        > "Tiny" vim (which is not compiled with +eval):
        >
        > eval.c: In function ‘eval7’:
        > eval.c:5173:7: warning: pointer targets in passing argument 1 of
        > ‘vim_strsave’ differ in signedness [-Wpointer-sign]
        >
        >
        > The message refers to the first nonblank in the following (new) line:
        > rettv->vval.v_string = vim_strsave("");
        >
        > However, I suppose that a string of zero characters followed by one null
        > byte is the same regardless of the assumed sign of the characters, so
        > this message should be innocuous.

        Fixed in 7.3.842.

        --
        The average life of an organization chart is six months. You can safely
        ignore any order from your boss that would take six months to complete.
        (Scott Adams - The Dilbert principle)

        /// Bram Moolenaar -- Bram@... -- http://www.Moolenaar.net \\\
        /// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
        \\\ an exciting new programming language -- http://www.Zimbu.org ///
        \\\ help me help AIDS victims -- http://ICCF-Holland.org ///

        --
        --
        You received this message from the "vim_dev" maillist.
        Do not top-post! Type your reply below the text you are replying to.
        For more information, visit http://www.vim.org/maillist.php

        ---
        You received this message because you are subscribed to the Google Groups "vim_dev" group.
        To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscribe@....
        For more options, visit https://groups.google.com/groups/opt_out.
      Your message has been successfully submitted and would be delivered to recipients shortly.