Loading ...
Sorry, an error occurred while loading the content.

Re: Issue 97 in vim: Fix --enable-pythoninterp on systems where python is a symlink to python3. [code]

Expand Messages
  • Bram Moolenaar
    Moved the discussion to the vim-dev list, a bit easier than using the web interface on the issue. ... OK, just to make it easier for others to see what the
    Message 1 of 7 , Dec 9, 2012
    • 0 Attachment
      Moved the discussion to the vim-dev list, a bit easier than using the
      web interface on the issue.

      > Comment #2 on issue 97 by l...@...: Fix --enable-pythoninterp on
      > systems where python is a symlink to python3. [code]
      > http://code.google.com/p/vim/issues/detail?id=97
      >
      > Sorry, I'm not all that familar with mercurial and wasn't sure what's
      > preferred.
      >
      > Next time. :)
      >
      > Attachments:
      > configure-systems-with-python2.diff 405 KB

      OK, just to make it easier for others to see what the change is:

      diff -r 52bfa939fc07 -r c63013ace2f7 src/configure.in
      --- a/src/configure.in Thu Dec 06 21:30:29 2012 +0100
      +++ b/src/configure.in Sun Dec 09 11:43:54 2012 +0100
      @@ -838,7 +838,7 @@
      AC_MSG_RESULT($enable_pythoninterp)
      if test "$enable_pythoninterp" = "yes" -o "$enable_pythoninterp" = "dynamic"; then
      dnl -- find the python executable
      - AC_PATH_PROG(vi_cv_path_python, python)
      + AC_PATH_PROGS(vi_cv_path_python, python2 python)
      if test "X$vi_cv_path_python" != "X"; then

      dnl -- get its version number

      The bulky part of the diff is because you ran autoconf manually instead
      of "make autoconf", it has overwritten src/configure instead of
      src/auto/configure.

      Don't you want to use this diff, so that for Python 3 we search for the
      "python" binary if "python3" is not available:

      *** ../vim-7.3.754/src/configure.in 2012-11-23 21:54:43.000000000 +0100
      --- src/configure.in 2012-12-09 15:41:59.000000000 +0100
      ***************
      *** 838,844 ****
      AC_MSG_RESULT($enable_pythoninterp)
      if test "$enable_pythoninterp" = "yes" -o "$enable_pythoninterp" = "dynamic"; then
      dnl -- find the python executable
      ! AC_PATH_PROG(vi_cv_path_python, python)
      if test "X$vi_cv_path_python" != "X"; then

      dnl -- get its version number
      --- 838,844 ----
      AC_MSG_RESULT($enable_pythoninterp)
      if test "$enable_pythoninterp" = "yes" -o "$enable_pythoninterp" = "dynamic"; then
      dnl -- find the python executable
      ! AC_PATH_PROGS(vi_cv_path_python, python2 python)
      if test "X$vi_cv_path_python" != "X"; then

      dnl -- get its version number
      ***************
      *** 1028,1034 ****
      AC_MSG_RESULT($enable_python3interp)
      if test "$enable_python3interp" = "yes" -o "$enable_python3interp" = "dynamic"; then
      dnl -- find the python3 executable
      ! AC_PATH_PROG(vi_cv_path_python3, python3)
      if test "X$vi_cv_path_python3" != "X"; then

      dnl -- get its version number
      --- 1028,1034 ----
      AC_MSG_RESULT($enable_python3interp)
      if test "$enable_python3interp" = "yes" -o "$enable_python3interp" = "dynamic"; then
      dnl -- find the python3 executable
      ! AC_PATH_PROGS(vi_cv_path_python3, python3 python)
      if test "X$vi_cv_path_python3" != "X"; then

      dnl -- get its version number


      --
      You cannot have a baby in one month by getting nine women pregnant.

      /// Bram Moolenaar -- Bram@... -- http://www.Moolenaar.net \\\
      /// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
      \\\ an exciting new programming language -- http://www.Zimbu.org ///
      \\\ help me help AIDS victims -- http://ICCF-Holland.org ///

      --
      You received this message from the "vim_dev" maillist.
      Do not top-post! Type your reply below the text you are replying to.
      For more information, visit http://www.vim.org/maillist.php
    • vim@googlecode.com
      Comment #3 on issue 97 by brammool...@gmail.com: Fix --enable-pythoninterp on systems where python is a symlink to python3. [code]
      Message 2 of 7 , Dec 9, 2012
      • 0 Attachment
        Comment #3 on issue 97 by brammool...@...: Fix --enable-pythoninterp
        on systems where python is a symlink to python3. [code]
        http://code.google.com/p/vim/issues/detail?id=97

        Thanks. See my alternate patch on the vim-dev maillist.

        --
        You received this message from the "vim_dev" maillist.
        Do not top-post! Type your reply below the text you are replying to.
        For more information, visit http://www.vim.org/maillist.php
      • Lucas Stadler
        ... Yes, I think that version is better. -- You received this message from the vim_dev maillist. Do not top-post! Type your reply below the text you are
        Message 3 of 7 , Dec 9, 2012
        • 0 Attachment
          > Don't you want to use this diff, so that for Python 3 we search for the
          >
          > "python" binary if "python3" is not available:
          >
          >
          >
          > *** ../vim-7.3.754/src/configure.in 2012-11-23 21:54:43.000000000 +0100
          >
          > --- src/configure.in 2012-12-09 15:41:59.000000000 +0100
          >
          > ***************
          >
          > *** 838,844 ****
          >
          > AC_MSG_RESULT($enable_pythoninterp)
          >
          > if test "$enable_pythoninterp" = "yes" -o "$enable_pythoninterp" = "dynamic"; then
          >
          > dnl -- find the python executable
          >
          > ! AC_PATH_PROG(vi_cv_path_python, python)
          >
          > if test "X$vi_cv_path_python" != "X"; then
          >
          >
          >
          > dnl -- get its version number
          >
          > --- 838,844 ----
          >
          > AC_MSG_RESULT($enable_pythoninterp)
          >
          > if test "$enable_pythoninterp" = "yes" -o "$enable_pythoninterp" = "dynamic"; then
          >
          > dnl -- find the python executable
          >
          > ! AC_PATH_PROGS(vi_cv_path_python, python2 python)
          >
          > if test "X$vi_cv_path_python" != "X"; then
          >
          >
          >
          > dnl -- get its version number
          >
          > ***************
          >
          > *** 1028,1034 ****
          >
          > AC_MSG_RESULT($enable_python3interp)
          >
          > if test "$enable_python3interp" = "yes" -o "$enable_python3interp" = "dynamic"; then
          >
          > dnl -- find the python3 executable
          >
          > ! AC_PATH_PROG(vi_cv_path_python3, python3)
          >
          > if test "X$vi_cv_path_python3" != "X"; then
          >
          >
          >
          > dnl -- get its version number
          >
          > --- 1028,1034 ----
          >
          > AC_MSG_RESULT($enable_python3interp)
          >
          > if test "$enable_python3interp" = "yes" -o "$enable_python3interp" = "dynamic"; then
          >
          > dnl -- find the python3 executable
          >
          > ! AC_PATH_PROGS(vi_cv_path_python3, python3 python)
          >
          > if test "X$vi_cv_path_python3" != "X"; then
          >
          >
          >
          > dnl -- get its version number

          Yes, I think that version is better.

          --
          You received this message from the "vim_dev" maillist.
          Do not top-post! Type your reply below the text you are replying to.
          For more information, visit http://www.vim.org/maillist.php
        • vim@...
          Updates: Status: Fixed Comment #4 on issue 97 by chrisbr...@googlemail.com: Fix --enable-pythoninterp on systems where python is a symlink to python3. [code]
          Message 4 of 7 , Sep 30 11:54 AM
          • 0 Attachment
            Updates:
            Status: Fixed

            Comment #4 on issue 97 by chrisbr...@...: Fix
            --enable-pythoninterp on systems where python is a symlink to python3.
            [code]
            https://code.google.com/p/vim/issues/detail?id=97

            Should be fixed by 7.3.755. Closing

            --
            You received this message because this project is configured to send all
            issue notifications to this address.
            You may adjust your notification preferences at:
            https://code.google.com/hosting/settings

            --
            --
            You received this message from the "vim_dev" maillist.
            Do not top-post! Type your reply below the text you are replying to.
            For more information, visit http://www.vim.org/maillist.php

            ---
            You received this message because you are subscribed to the Google Groups "vim_dev" group.
            To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscribe@....
            For more options, visit https://groups.google.com/d/optout.
          Your message has been successfully submitted and would be delivered to recipients shortly.