Loading ...
Sorry, an error occurred while loading the content.

Re: [PATCH] src/if_cscope.c: Add new search type no.9 "find assignments

Expand Messages
  • ulim
    ... Thanks! It seemed to apply when I downloaded the current version of the if_cscope.c file from mercurial but maybe I got the revision wrong. By the way, I
    Message 1 of 11 , Sep 1, 2012
    • 0 Attachment
      On Saturday, September 1, 2012 11:14:05 PM UTC+2, Sean Estabrooks wrote:
      > Uli,
      >
      >
      >
      > This is a nice feature. It seems your patch wasn't against the current
      >
      > development branch though. Here is a unified-diff respin that should
      >
      > apply.

      Thanks! It seemed to apply when I downloaded the current version of the if_cscope.c file from mercurial but maybe I got the revision wrong.

      By the way, I made it a "diff -c" and not a unified diff because a vim-tip(618) titled "How to submit a patch" or similar said so. I just realized it's from 2003 so I guess that's outdated.

      Uli

      P.S.: sry for the double post, I thought my first mail got blocked since it didn't appear after several hours.

      --
      You received this message from the "vim_dev" maillist.
      Do not top-post! Type your reply below the text you are replying to.
      For more information, visit http://www.vim.org/maillist.php
    • Gary Johnson
      ... It s not outdated. :help development still says, For sending patches a context diff diff -c is preferred. Thanks for the cscope patch. I m looking
      Message 2 of 11 , Sep 1, 2012
      • 0 Attachment
        On 2012-09-01, ulim wrote:

        > By the way, I made it a "diff -c" and not a unified diff because a
        > vim-tip(618) titled "How to submit a patch" or similar said so. I
        > just realized it's from 2003 so I guess that's outdated.

        It's not outdated. ":help development" still says, 'For sending
        patches a context diff "diff -c" is preferred.'

        Thanks for the cscope patch. I'm looking forward to trying it out.

        Regards,
        Gary

        --
        You received this message from the "vim_dev" maillist.
        Do not top-post! Type your reply below the text you are replying to.
        For more information, visit http://www.vim.org/maillist.php
      • ZyX
        ... The fact that this is help does not mean it is not outdated: “hg annotate” says it was last modified in revision 7 (14 June 2004, tag v7-0001). If you
        Message 3 of 11 , Sep 2, 2012
        • 0 Attachment
          > It's not outdated. ":help development" still says, 'For sending
          > patches a context diff "diff -c" is preferred.'

          The fact that this is help does not mean it is not outdated: “hg annotate” says it was last modified in revision 7 (14 June 2004, tag v7-0001). If you check the list you will see that on first place there is “hg diff” output, on the second is “hg diff --git”; I prefer “hg export” or “hg diff”. “hg diff --git” is the only option if someone needs to add binary files.

          --
          You received this message from the "vim_dev" maillist.
          Do not top-post! Type your reply below the text you are replying to.
          For more information, visit http://www.vim.org/maillist.php
        • Gary Johnson
          ... I meant only that the statement of preference for context diffs was not outdated. I assumed that if Bram had changed his preference, he would have updated
          Message 4 of 11 , Sep 2, 2012
          • 0 Attachment
            On 2012-09-02, ZyX wrote:
            > > It's not outdated. ":help development" still says, 'For sending
            > > patches a context diff "diff -c" is preferred.'
            >
            > The fact that this is help does not mean it is not outdated: “hg
            > annotate” says it was last modified in revision 7 (14 June 2004,
            > tag v7-0001). If you check the list you will see that on first
            > place there is “hg diff” output, on the second is “hg diff --git”;
            > I prefer “hg export” or “hg diff”. “hg diff --git” is the only
            > option if someone needs to add binary files.

            I meant only that the statement of preference for context diffs was
            not outdated. I assumed that if Bram had changed his preference, he
            would have updated the help entry.

            Using Mercurial does not preclude the use of context diffs. I have
            the following in my ~/.hgrc,

            [extdiff]
            cmd.cdiff = diff
            opts.cdiff = -c

            and use 'hg cdiff' when generating patches for Vim.

            Regards,
            Gary

            --
            You received this message from the "vim_dev" maillist.
            Do not top-post! Type your reply below the text you are replying to.
            For more information, visit http://www.vim.org/maillist.php
          • ZyX
            ... I know. Can’t say anything for Bram, but for me context diffs are harder to read. And, besides, you need some configuration (should not it be “-cr”
            Message 5 of 11 , Sep 2, 2012
            • 0 Attachment
              > I meant only that the statement of preference for context diffs was
              > not outdated. I assumed that if Bram had changed his preference, he
              > would have updated the help entry.
              >
              > Using Mercurial does not preclude the use of context diffs. I have
              >
              > the following in my ~/.hgrc,
              >
              > [extdiff]
              > cmd.cdiff = diff
              > opts.cdiff = -c
              >
              > and use 'hg cdiff' when generating patches for Vim.

              I know. Can’t say anything for Bram, but for me context diffs are harder to read.

              And, besides, you need some configuration (should not it be “-cr” in place of “-c”?). Why bothering if unified diffs are normally accepted, easier to read, faster created, and do not require configuration?

              --
              You received this message from the "vim_dev" maillist.
              Do not top-post! Type your reply below the text you are replying to.
              For more information, visit http://www.vim.org/maillist.php
            • Bram Moolenaar
              ... It s fine to send me any kind of context diff. But in general, not every Vim user can handel unified diffs. Some HP and Sun systems require additional
              Message 6 of 11 , Sep 2, 2012
              • 0 Attachment
                Gary Johnson wrote:

                > On 2012-09-02, ZyX wrote:
                > > > It's not outdated. ":help development" still says, 'For sending
                > > > patches a context diff "diff -c" is preferred.'
                > >
                > > The fact that this is help does not mean it is not outdated: “hg
                > > annotate” says it was last modified in revision 7 (14 June 2004,
                > > tag v7-0001). If you check the list you will see that on first
                > > place there is “hg diff” output, on the second is “hg diff --git”;
                > > I prefer “hg export” or “hg diff”. “hg diff --git” is the only
                > > option if someone needs to add binary files.
                >
                > I meant only that the statement of preference for context diffs was
                > not outdated. I assumed that if Bram had changed his preference, he
                > would have updated the help entry.
                >
                > Using Mercurial does not preclude the use of context diffs. I have
                > the following in my ~/.hgrc,
                >
                > [extdiff]
                > cmd.cdiff = diff
                > opts.cdiff = -c
                >
                > and use 'hg cdiff' when generating patches for Vim.

                It's fine to send me any kind of context diff. But in general, not
                every Vim user can handel unified diffs. Some HP and Sun systems
                require additional tools. Thus if you want it to work for everybody,
                send old style context diffs.

                --
                Not too long ago, compress was something you did to garbage...

                /// Bram Moolenaar -- Bram@... -- http://www.Moolenaar.net \\\
                /// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
                \\\ an exciting new programming language -- http://www.Zimbu.org ///
                \\\ help me help AIDS victims -- http://ICCF-Holland.org ///

                --
                You received this message from the "vim_dev" maillist.
                Do not top-post! Type your reply below the text you are replying to.
                For more information, visit http://www.vim.org/maillist.php
              • Gary Johnson
                ... I doesn t really matter what is easier for you or me; what matters is what is preferred by the person receiving the diffs and doing the work to check and
                Message 7 of 11 , Sep 2, 2012
                • 0 Attachment
                  On 2012-09-02, ZyX wrote:
                  > > I meant only that the statement of preference for context diffs was
                  > > not outdated. I assumed that if Bram had changed his preference, he
                  > > would have updated the help entry.
                  > >
                  > > Using Mercurial does not preclude the use of context diffs. I have
                  > >
                  > > the following in my ~/.hgrc,
                  > >
                  > > [extdiff]
                  > > cmd.cdiff = diff
                  > > opts.cdiff = -c
                  > >
                  > > and use 'hg cdiff' when generating patches for Vim.
                  >
                  > I know. Can’t say anything for Bram, but for me context diffs are harder to read.
                  >
                  > And, besides, you need some configuration (should not it be “-cr”
                  > in place of “-c”?). Why bothering if unified diffs are normally
                  > accepted, easier to read, faster created, and do not require
                  > configuration?

                  I doesn't really matter what is easier for you or me; what matters
                  is what is preferred by the person receiving the diffs and doing the
                  work to check and integrate the changes, but Bram has already
                  replied to that issue.

                  As for "-cr", no, I don't think you want to add the -r. Mercurial
                  takes care of selecting the files to diff and just needs to be told
                  the tool to use to diff each one.

                  Regards,
                  Gary

                  --
                  You received this message from the "vim_dev" maillist.
                  Do not top-post! Type your reply below the text you are replying to.
                  For more information, visit http://www.vim.org/maillist.php
                • ZyX
                  ... It does not work for me: hg cdiff -r v7-3-646 -r tip produces diff -c vim.e70485d3f81d/.hgtags vim.c12dca9e7d9a/.hgtags ... *************** ...
                  Message 8 of 11 , Sep 2, 2012
                  • 0 Attachment
                    > I doesn't really matter what is easier for you or me; what matters
                    > is what is preferred by the person receiving the diffs and doing the
                    > work to check and integrate the changes, but Bram has already
                    > replied to that issue.
                    >
                    > As for "-cr", no, I don't think you want to add the -r. Mercurial
                    > takes care of selecting the files to diff and just needs to be told
                    > the tool to use to diff each one.
                    >
                    > Regards,
                    >
                    > Gary

                    It does not work for me: "hg cdiff -r v7-3-646 -r tip" produces

                    diff -c vim.e70485d3f81d/.hgtags vim.c12dca9e7d9a/.hgtags
                    *** vim.e70485d3f81d/.hgtags 2012-09-03 09:00:12.000000000 +0400
                    --- vim.c12dca9e7d9a/.hgtags 2012-09-03 09:00:12.000000000 +0400
                    ***************
                    *** 1982,1984 ****
                    --- 1982,1985 ----
                    fdac34e3afa5f0dea26dba5e96932e3b9a0be50a v7-3-643
                    fb7c028dcac7555fee78096813e3846d157cc91b v7-3-644
                    1810ee914648ef3e16a8cf866299a32c4a9a00cb v7-3-645
                    + e70485d3f81df4d72cb40d6fa4ad4218cf1e8392 v7-3-646
                    Общие подкаталоги: vim.e70485d3f81d/runtime и vim.c12dca9e7d9a/runtime
                    Общие подкаталоги: vim.e70485d3f81d/src и vim.c12dca9e7d9a/src

                    , while with "-r" everything is fine.

                    --
                    You received this message from the "vim_dev" maillist.
                    Do not top-post! Type your reply below the text you are replying to.
                    For more information, visit http://www.vim.org/maillist.php
                  • Gary Johnson
                    ... You are right. Up to now I had used hg cdiff with only a single file argument. After trying your example, I read the ExtdiffExtension page
                    Message 9 of 11 , Sep 3, 2012
                    • 0 Attachment
                      On 2012-09-02, ZyX wrote:
                      > > I doesn't really matter what is easier for you or me; what matters
                      > > is what is preferred by the person receiving the diffs and doing the
                      > > work to check and integrate the changes, but Bram has already
                      > > replied to that issue.
                      > >
                      > > As for "-cr", no, I don't think you want to add the -r. Mercurial
                      > > takes care of selecting the files to diff and just needs to be told
                      > > the tool to use to diff each one.
                      > >
                      > > Regards,
                      > >
                      > > Gary
                      >
                      > It does not work for me: "hg cdiff -r v7-3-646 -r tip" produces
                      >
                      > diff -c vim.e70485d3f81d/.hgtags vim.c12dca9e7d9a/.hgtags
                      > *** vim.e70485d3f81d/.hgtags 2012-09-03 09:00:12.000000000 +0400
                      > --- vim.c12dca9e7d9a/.hgtags 2012-09-03 09:00:12.000000000 +0400
                      > ***************
                      > *** 1982,1984 ****
                      > --- 1982,1985 ----
                      > fdac34e3afa5f0dea26dba5e96932e3b9a0be50a v7-3-643
                      > fb7c028dcac7555fee78096813e3846d157cc91b v7-3-644
                      > 1810ee914648ef3e16a8cf866299a32c4a9a00cb v7-3-645
                      > + e70485d3f81df4d72cb40d6fa4ad4218cf1e8392 v7-3-646
                      > Общие подкаталоги: vim.e70485d3f81d/runtime и vim.c12dca9e7d9a/runtime
                      > Общие подкаталоги: vim.e70485d3f81d/src и vim.c12dca9e7d9a/src
                      >
                      > , while with "-r" everything is fine.

                      You are right. Up to now I had used 'hg cdiff' with only a single file
                      argument. After trying your example, I read the ExtdiffExtension page
                      (http://mercurial.selenic.com/wiki/ExtdiffExtension) again and saw that
                      the default and example arguments include -r.

                      Thanks for the correction and the example.

                      Regards,
                      Gary

                      --
                      You received this message from the "vim_dev" maillist.
                      Do not top-post! Type your reply below the text you are replying to.
                      For more information, visit http://www.vim.org/maillist.php
                    Your message has been successfully submitted and would be delivered to recipients shortly.