Loading ...
Sorry, an error occurred while loading the content.

Issue 55 in vim: b:undo_ftplugin is not defined in some files under ftplugins (patch attached)

Expand Messages
  • vim@googlecode.com
    Status: New Owner: ---- Labels: Type-Defect Priority-Medium New issue 55 by carlobal...@gmail.com: b:undo_ftplugin is not defined in some files under ftplugins
    Message 1 of 4 , Mar 4, 2012
    • 0 Attachment
      Status: New
      Owner: ----
      Labels: Type-Defect Priority-Medium

      New issue 55 by carlobal...@...: b:undo_ftplugin is not defined in
      some files under ftplugins (patch attached)
      http://code.google.com/p/vim/issues/detail?id=55

      I found some problems related to custom filetype recognition, related to
      the fact that some ftplugins do not define the b:undo_ftplugin variable.

      Steps to reproduce:
      1) Create a custom filetype "julia" with extension *.jl (which is already
      taken by lisp):
      1) a) Put an autoload line under ~/.vim/ftdetect/julia.vim calling "set
      filetype=julia"
      1) b) Create a standard ftplugin under ~/.vim/ftplugin/julia.vim, with the
      usual check for b:did_ftplugin
      1) c) Optionally, add a custom syntax file as well
      2. Edit a file with extension .jl

      Expected result:
      Lisp filetype should be overridden by julia.

      Actual result:
      The filetype is set to "julia", but when ~/.vim/ftplugin/julia.vim is
      sourced the variable b:did_ftplugin is already set and the file is
      therefore skipped, while the options set by $VIMRUNTIME/ftplugins/lisp.vim
      are retained.
      Also, the julia syntax file gets loaded, but (because of the wrong
      settings) there may be problems with that as well.

      My system:
      Ubuntu Linux 11.10, Vim 7.3. Tested with a bare minimum vimrc file which
      only uses "set rtp=~/.vim,$VIMRUNTIME", "plugin on" and "set nocompatible".

      I verified that by defining b:undo_ftplugin in the lisp.vim ftplugin the
      issue goes away.

      I'm submitting a patch (against the latest repository code) which adds the
      definition of this variable to all ftplugin files which miss it.

      Attachments:
      fix_undo_ftplugin.patch 11.0 KB

      --
      You received this message from the "vim_dev" maillist.
      Do not top-post! Type your reply below the text you are replying to.
      For more information, visit http://www.vim.org/maillist.php
    • vim@googlecode.com
      Comment #1 on issue 55 by sergey.k...@gmail.com: b:undo_ftplugin is not defined in some files under ftplugins (patch attached)
      Message 2 of 4 , Mar 5, 2012
      • 0 Attachment
        Comment #1 on issue 55 by sergey.k...@...: b:undo_ftplugin is not
        defined in some files under ftplugins (patch attached)
        http://code.google.com/p/vim/issues/detail?id=55

        Many runtime files are managed by maintainers. The maintainers send new
        versions to Bram when they want to update something.
        Last time a large scale update was needed, the initiator contacted all
        maintainers personally.

        --
        You received this message from the "vim_dev" maillist.
        Do not top-post! Type your reply below the text you are replying to.
        For more information, visit http://www.vim.org/maillist.php
      • vim@googlecode.com
        Comment #2 on issue 55 by oliver.steven: b:undo_ftplugin is not defined in some files under ftplugins (patch attached)
        Message 3 of 4 , Mar 20, 2012
        • 0 Attachment
          Comment #2 on issue 55 by oliver.steven: b:undo_ftplugin is not defined in
          some files under ftplugins (patch attached)
          http://code.google.com/p/vim/issues/detail?id=55

          An updated by version of falcon.vim has been submitted by me (the
          maintainer).

          --
          You received this message from the "vim_dev" maillist.
          Do not top-post! Type your reply below the text you are replying to.
          For more information, visit http://www.vim.org/maillist.php
        • vim@...
          Updates: Status: Invalid Comment #3 on issue 55 by chrisbr...@googlemail.com: b:undo_ftplugin is not defined in some files under ftplugins (patch attached)
          Message 4 of 4 , Sep 30, 2014
          • 0 Attachment
            Updates:
            Status: Invalid

            Comment #3 on issue 55 by chrisbr...@...: b:undo_ftplugin is not
            defined in some files under ftplugins (patch attached)
            https://code.google.com/p/vim/issues/detail?id=55

            Runtime file updates should be taken to the maintainer of the files.
            Closing this issue.

            --
            You received this message because this project is configured to send all
            issue notifications to this address.
            You may adjust your notification preferences at:
            https://code.google.com/hosting/settings

            --
            --
            You received this message from the "vim_dev" maillist.
            Do not top-post! Type your reply below the text you are replying to.
            For more information, visit http://www.vim.org/maillist.php

            ---
            You received this message because you are subscribed to the Google Groups "vim_dev" group.
            To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscribe@....
            For more options, visit https://groups.google.com/d/optout.
          Your message has been successfully submitted and would be delivered to recipients shortly.