Loading ...
Sorry, an error occurred while loading the content.

Re: [patch] fixed valgrind error in eval.c (Conditional jump or move depends on uninitialised value)

Expand Messages
  • Bram Moolenaar
    ... [...] ... Thanks, I ll include it soon. -- Marriage is the process of finding out what kind of man your wife would have preferred /// Bram Moolenaar --
    Message 1 of 2 , Jul 3, 2011
    • 0 Attachment
      Dominique Pelle wrote:

      > I see a valgrind error with Vim-7.3.237 on Linux
      > sometimes (not all the time) when I enter the Ex
      > command :FufBuffer (command from the fuzzy-finder
      > plugin: http://www.vim.org/scripts/script.php?script_id=1984)
      [...]

      >
      > Code around eval.c:14321
      >
      > 14314 while (cnt < maxline || maxline < 0)
      > 14315 {
      > 14316 readlen = (int)fread(buf + filtd, 1, FREAD_SIZE - filtd, fd);
      > 14317 buflen = filtd + readlen;
      > 14318 tolist = 0;
      > 14319 for ( ; filtd < buflen || readlen <= 0; ++filtd)
      > 14320 {
      > !14321 if (buf[filtd] == '\n' || readlen <= 0)
      > 14322 {
      >
      > Adding debug printf, I can see that when error happens
      > readlen is 0 and filtd is 0. So buf[0] is read uninitialized
      > since nothing was read in buf[]. I think that the error is
      > harmless in practice, but attached patch fixes it.

      Thanks, I'll include it soon.

      --
      "Marriage is the process of finding out what kind of man your wife
      would have preferred"

      /// Bram Moolenaar -- Bram@... -- http://www.Moolenaar.net \\\
      /// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
      \\\ an exciting new programming language -- http://www.Zimbu.org ///
      \\\ help me help AIDS victims -- http://ICCF-Holland.org ///

      --
      You received this message from the "vim_dev" maillist.
      Do not top-post! Type your reply below the text you are replying to.
      For more information, visit http://www.vim.org/maillist.php
    Your message has been successfully submitted and would be delivered to recipients shortly.