Loading ...
Sorry, an error occurred while loading the content.

[Patch] Fix drawing of cursorline on line with concealed chars and 'list' set

Expand Messages
  • Christian Brabandt
    Hi Bram, here is a patch, that fixes this item from the todo list: ,---- ... `---- BTW: Is it supposed to be that concealed lines, wrap earlier than other
    Message 1 of 2 , Feb 3, 2011
    • 0 Attachment
      Hi Bram,
      here is a patch, that fixes this item from the todo list:

      ,----
      | 'cursorline' is displayed too short when there are concealed characters
      | and 'list' is set, 'listchars' at default value. (Dennis Preiser, 2010
      | Aug 15)
      `----

      BTW: Is it supposed to be that concealed lines, wrap earlier than other
      lines? (e.g. make a window 72 chars wide and do :h E704 and look how the
      last 'E' is still drawn but the rest of the line is wrapped, while other
      lines are drawn until the end of the window) I can understand why this
      happens, but it looks strange.

      diff --git a/src/screen.c b/src/screen.c
      --- a/src/screen.c
      +++ b/src/screen.c
      @@ -5099,7 +5099,11 @@
      #ifdef FEAT_DIFF
      || filler_todo > 0
      #endif
      - || (wp->w_p_list && lcs_eol != NUL && p_extra != at_end_str)
      + || (wp->w_p_list && lcs_eol != NUL && p_extra != at_end_str
      +#ifdef FEAT_SYN_HL
      + && !wp->w_p_cul
      +#endif
      + )
      || (n_extra != 0 && (c_extra != NUL || *p_extra != NUL)))
      )
      {


      regards,
      Christian

      --
      You received this message from the "vim_dev" maillist.
      Do not top-post! Type your reply below the text you are replying to.
      For more information, visit http://www.vim.org/maillist.php
    • Bram Moolenaar
      ... Thanks! ... Yeah, it s not so easy to make this work better. -- I m in shape. Round IS a shape. /// Bram Moolenaar -- Bram@Moolenaar.net --
      Message 2 of 2 , Feb 3, 2011
      • 0 Attachment
        Christian Brabandt wrote:

        > here is a patch, that fixes this item from the todo list:
        >
        > ,----
        > | 'cursorline' is displayed too short when there are concealed characters
        > | and 'list' is set, 'listchars' at default value. (Dennis Preiser, 2010
        > | Aug 15)
        > `----

        Thanks!

        > BTW: Is it supposed to be that concealed lines, wrap earlier than other
        > lines? (e.g. make a window 72 chars wide and do :h E704 and look how the
        > last 'E' is still drawn but the rest of the line is wrapped, while other
        > lines are drawn until the end of the window) I can understand why this
        > happens, but it looks strange.

        Yeah, it's not so easy to make this work better.

        --
        I'm in shape. Round IS a shape.

        /// Bram Moolenaar -- Bram@... -- http://www.Moolenaar.net \\\
        /// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
        \\\ an exciting new programming language -- http://www.Zimbu.org ///
        \\\ help me help AIDS victims -- http://ICCF-Holland.org ///

        --
        You received this message from the "vim_dev" maillist.
        Do not top-post! Type your reply below the text you are replying to.
        For more information, visit http://www.vim.org/maillist.php
      Your message has been successfully submitted and would be delivered to recipients shortly.