Loading ...
Sorry, an error occurred while loading the content.

Re: [patch] src/testdir/test72.vim uses 'set cm=0' and 'set cm=1' instead of 'set cm=zip' and 'set cm=blowfish'

Expand Messages
  • Bram Moolenaar
    ... Thanks. I think that the test was testing encryption, but only the default type. Try changing some of the text and you ll see the test fail. --
    Message 1 of 2 , Jul 30, 2010
    • 0 Attachment
      Dominique Pelle wrote:

      > Looking at vim/src/testdir/test72.vim (2436:aaa953373c91), I see this:
      >
      > :" And now with encryption, cryptmethod=0
      > :e! Xtestfile
      > :set undofile cm=0
      >
      > ...snip...
      >
      > :" With encryption, cryptmethod=1
      > :e! Xtestfile
      > :set undofile cm=1
      >
      > cm=0 and cm=1 are obsolete and should be replaced with
      > cm=zip and cm=blowfish.
      >
      > Attached patch fixes it. However, I'm surprised that the test
      > did not fail when the wrong option was given since 'set cm=0'
      > raises E474. It means that the test did not test undo with
      > encryption as it was supposed to. This calls for additional
      > changes to make test more robust (not done in attached patch).

      Thanks. I think that the test was testing encryption, but only the
      default type. Try changing some of the text and you'll see the test
      fail.

      --
      Westheimer's Discovery:
      A couple of months in the laboratory can
      frequently save a couple of hours in the library.

      /// Bram Moolenaar -- Bram@... -- http://www.Moolenaar.net \\\
      /// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
      \\\ download, build and distribute -- http://www.A-A-P.org ///
      \\\ help me help AIDS victims -- http://ICCF-Holland.org ///

      --
      You received this message from the "vim_dev" maillist.
      Do not top-post! Type your reply below the text you are replying to.
      For more information, visit http://www.vim.org/maillist.php
    Your message has been successfully submitted and would be delivered to recipients shortly.