Re: Patch 7.2.442
- James Vega wrote:
> >> On Sun, Jun 6, 2010 at 4:26 PM, Bram Moolenaar <Bram@...> wrote:Yes, mbyte.c is confusing. Context is a long way away, it appears I
> >> > James Vega wrote:
> >> >> Personally, I'd prefer to remove all the GTK 1 code from Vim since GTK 1
> >> >> isn't supported by its upstream anymore and has been deprecated for
> >> >> years. As it is, parts of Vim will need to be changed for compatibility
> >> >> with GTK 3 when that comes out, and supporting three different GTK
> >> >> versions just seems like overkill, in my opinion.
> >> >
> >> > What do others think about removing support for GTK 1? It makes sense,
> >> > any system where you would try to build Vim 7.3 should be able to
> >> > install GTK 2 libraries.
> >> Attached is a patch to remove GTK 1 support. The patch changes
> >> configure.in, so anyone that tests it will need to run "make autoconf"
> >> from the src directory before building.
> >> Things seem fine from my initial testing, but some extra testing,
> >> especially from people that use an input method with Vim (even if you
> >> are using a non-GTK build of gvim), would be useful. The IM portion of the
> >> code was a particularly hairy mess of feature ifdefs.
> >> > It will clean up the Vim source code.
> >> Indeed it did. This ends up removing about 1% of the total lines of
> >> code.
> > It appears you have removed too much. In some places the code inside
> > #ifdef FEAT_GUI_GTK was removed, but that is also used for GTK2.
> > FEAT_GUI_GTK is defined both for GTK 1 and 2.
> The places where I removed FEAT_GUI_GTK checks were wherever they were
> paired with or inside a !HAVE_GTK2 check, since FEAT_GUI_GTK will only
> be defined if HAVE_GTK2 is.
> It just happens that a large part of mbyte.c is part of an "#else ...
> #endif" corresponding to HAVE_GTK2 not being defined.
missed an #ifdef around code that duplicates a lot of functions.
I'll look again.
hundred-and-one symptoms of being an internet addict:
228. You spend Saturday night making the counter on your home page
pass that 2000 mark.
/// Bram Moolenaar -- Bram@... -- http://www.Moolenaar.net \\\
/// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\ download, build and distribute -- http://www.A-A-P.org ///
\\\ help me help AIDS victims -- http://ICCF-Holland.org ///
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php