Loading ...
Sorry, an error occurred while loading the content.

[patch] Wrong visual and 'cuc' highlighting in diff mode

Expand Messages
  • Lech Lorens
    The attached patch fixes the incorrect highlighting of the current column (with cuc set) and the visual blocks in changed/added lines in diff mode. Such bad
    Message 1 of 2 , Oct 31, 2009
    • 0 Attachment
      The attached patch fixes the incorrect highlighting of the current column
      (with 'cuc' set) and the visual blocks in changed/added lines in diff
      mode. Such bad behaviour can be observed if the view of the diffed
      buffer gets shifted to the right (e.g. with zl) so that the
      changed/added line is shorter than the shift offset.

      Examples of the described behaviour are depicted in the following screen
      shots:
      - visual block:
      http://llorens.visualserver.org/wrong-cuc-highlight/visual-wrong.png
      - current column:
      http://llorens.visualserver.org/wrong-cuc-highlight/cuc-wrong.png

      While the screen shots should show:
      - visual block:
      http://llorens.visualserver.org/wrong-cuc-highlight/visual-ok.png
      - current column:
      http://llorens.visualserver.org/wrong-cuc-highlight/cuc-ok.png

      To reproduce the problem invoke vim with the following command line
      arguments:
      - visual block:
      $ vim -u NONE -c 'normal iabcdefghijklmnopqrstuvwxyz' \
      -c 'normal yyp' \
      -c 'belowright vert new | normal 2pggddp' \
      -c 'windo diffthis | normal gg9|5zl 2j2l'

      - current column:
      $ vim -u NONE -c 'normal iabcdefghijklmnopqrstuvwxyz' \
      -c 'normal yyp' \
      -c 'belowright vert new | normal 2pggddp' \
      -c 'windo diffthis | normal gg9|5zl' \
      -c 'set cuc'

      --
      Cheers,
      Lech

      --~--~---------~--~----~------------~-------~--~----~
      You received this message from the "vim_dev" maillist.
      For more information, visit http://www.vim.org/maillist.php
      -~----------~----~----~----~------~----~------~--~---
    • Bram Moolenaar
      ... Thanks! -- An indication you must be a manager: You believe you never have any problems in your life, just issues and improvement opportunities . ///
      Message 2 of 2 , Nov 1, 2009
      • 0 Attachment
        Lech Lorens wrote:

        > The attached patch fixes the incorrect highlighting of the current column
        > (with 'cuc' set) and the visual blocks in changed/added lines in diff
        > mode. Such bad behaviour can be observed if the view of the diffed
        > buffer gets shifted to the right (e.g. with zl) so that the
        > changed/added line is shorter than the shift offset.
        >
        > Examples of the described behaviour are depicted in the following screen
        > shots:
        > - visual block:
        > http://llorens.visualserver.org/wrong-cuc-highlight/visual-wrong.png
        > - current column:
        > http://llorens.visualserver.org/wrong-cuc-highlight/cuc-wrong.png
        >
        > While the screen shots should show:
        > - visual block:
        > http://llorens.visualserver.org/wrong-cuc-highlight/visual-ok.png
        > - current column:
        > http://llorens.visualserver.org/wrong-cuc-highlight/cuc-ok.png
        >
        > To reproduce the problem invoke vim with the following command line
        > arguments:
        > - visual block:
        > $ vim -u NONE -c 'normal iabcdefghijklmnopqrstuvwxyz' \
        > -c 'normal yyp' \
        > -c 'belowright vert new | normal 2pggddp' \
        > -c 'windo diffthis | normal gg9|5zl 2j2l'
        >
        > - current column:
        > $ vim -u NONE -c 'normal iabcdefghijklmnopqrstuvwxyz' \
        > -c 'normal yyp' \
        > -c 'belowright vert new | normal 2pggddp' \
        > -c 'windo diffthis | normal gg9|5zl' \
        > -c 'set cuc'

        Thanks!

        --
        An indication you must be a manager:
        You believe you never have any problems in your life, just
        "issues" and "improvement opportunities".

        /// Bram Moolenaar -- Bram@... -- http://www.Moolenaar.net \\\
        /// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
        \\\ download, build and distribute -- http://www.A-A-P.org ///
        \\\ help me help AIDS victims -- http://ICCF-Holland.org ///

        --~--~---------~--~----~------------~-------~--~----~
        You received this message from the "vim_dev" maillist.
        For more information, visit http://www.vim.org/maillist.php
        -~----------~----~----~----~------~----~------~--~---
      Your message has been successfully submitted and would be delivered to recipients shortly.