Loading ...
Sorry, an error occurred while loading the content.

Re: Patch 7.2.094

Expand Messages
  • Tony Mechelynck
    ... Looks like patch 7.2.092 introduced another signedness mismatch, near line 19915 of eval.c -- here s the context as I see it, with the culprit line set
    Message 1 of 2 , Feb 4, 2009
    • 0 Attachment
      On 04/02/09 11:20, Bram Moolenaar wrote:
      >
      > Patch 7.2.094
      > Problem: Compiler warning for signed/unsigned compare.
      > Solution: Add type cast. Also fix a few typos.
      > Files: src/edit.c

      Looks like patch 7.2.092 introduced another signedness mismatch, near
      line 19915 of eval.c -- here's the context as I see it, with the
      "culprit line" set out (the compiler complains about "argument 1 of
      emsg_funcname"). I'm giving that much context because I have one
      unofficial patch earlier in that file.

      if (!eap->skip)
      {
      /* Check the name of the function. Unless it's a dictionary function
      * (that we are overwriting). */
      if (name != NULL)
      arg = name;
      else
      arg = fudi.fd_newkey;
      if (arg != NULL && (fudi.fd_di == NULL
      || fudi.fd_di->di_tv.v_type != VAR_FUNC))
      {
      if (*arg == K_SPECIAL)
      j = 3;
      else
      j = 0;
      while (arg[j] != NUL && (j == 0 ? eval_isnamec1(arg[j])
      : eval_isnamec(arg[j])))
      ++j;
      if (arg[j] != NUL)
      -------------------------------------------------------------------
      emsg_funcname(e_invarg2, arg);
      -------------------------------------------------------------------
      }
      }

      /*
      * Isolate the arguments: "arg1, arg2, ...)"
      */
      while (*p != ')')
      {
      if (p[0] == '.' && p[1] == '.' && p[2] == '.')
      {
      varargs = TRUE;
      p += 3;
      mustend = TRUE;
      }
      else
      {
      arg = p;
      while (ASCII_ISALNUM(*p) || *p == '_')
      ++p;
      if (arg == p || isdigit(*arg)
      || (p - arg == 9 && STRNCMP(arg, "firstline", 9) == 0)
      || (p - arg == 8 && STRNCMP(arg, "lastline", 8) == 0))





      Best regards,
      Tony.
      --
      Arthur pulls Pin out. The MONK blesses the grenade as ...
      ARTHUR: (quietly) One, two, five ...
      GALAHAD: Three, sir!
      ARTHUR: Three.
      "Monty Python and the Holy Grail" PYTHON (MONTY)
      PICTURES LTD

      --~--~---------~--~----~------------~-------~--~----~
      You received this message from the "vim_dev" maillist.
      For more information, visit http://www.vim.org/maillist.php
      -~----------~----~----~----~------~----~------~--~---
    Your message has been successfully submitted and would be delivered to recipients shortly.