Loading ...
Sorry, an error occurred while loading the content.

Re: Gvim blinking on processing netbeans commands

Expand Messages
  • Bram Moolenaar
    ... Did you try removing this redraw_later() call completely? The code doesn t seem to do something by itself, and the :sign commands invoked should take
    Message 1 of 3 , Apr 20, 2007
    • 0 Attachment
      Xavier de Gaye wrote:

      > The gvim screen is blinking when receiving netbeans command. This
      > happens even when the signs that are being moved around are not visible
      > in the displayed windows. The following patch fixes this problem.
      >
      > Patch based on stable vim 7.0
      > Problem: gvim blinking on processing the addAnno command
      > Solution: redraw only what has changed
      > Files: src/netbeans.c
      >
      >
      > diff -Naur vim70_old/src/netbeans.c vim70/src/netbeans.c
      > --- vim70_old/src/netbeans.c 2006-04-22 20:00:05.000000000 +0200
      > +++ vim70/src/netbeans.c 2007-04-20 10:36:24.320362472 +0200
      > @@ -2119,7 +2119,7 @@
      > buf->bufp->b_fnum);
      > }
      > /* XXX only redraw what changed. */
      > - redraw_later(CLEAR);
      > + redraw_later(NOT_VALID);
      > #endif
      > /* =====================================================================*/
      > }

      Did you try removing this redraw_later() call completely? The code
      doesn't seem to do something by itself, and the ":sign" commands invoked
      should take care of redrawing.

      --
      At some point in the project somebody will start whining about the need to
      determine the project "requirements". This involves interviewing people who
      don't know what they want but, curiously, know exactly when they need it.
      (Scott Adams - The Dilbert principle)

      /// Bram Moolenaar -- Bram@... -- http://www.Moolenaar.net \\\
      /// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
      \\\ download, build and distribute -- http://www.A-A-P.org ///
      \\\ help me help AIDS victims -- http://ICCF-Holland.org ///
    • Xavier de Gaye
      ... You are right. All the tests I have run with clewn after removing this redraw_later() call completely are Ok: the screen does not blink anymore and the
      Message 2 of 3 , Apr 21, 2007
      • 0 Attachment
        --- Bram Moolenaar wrote:
        >
        > Xavier de Gaye wrote:
        >
        > > The gvim screen is blinking when receiving netbeans command. This
        > > happens even when the signs that are being moved around are not visible
        > > in the displayed windows. The following patch fixes this problem.
        > >
        > > [snip] ...
        > >
        > Did you try removing this redraw_later() call completely? The code
        > doesn't seem to do something by itself, and the ":sign" commands invoked
        > should take care of redrawing.
        >

        You are right. All the tests I have run with clewn after removing this
        redraw_later() call completely are Ok: the screen does not blink anymore
        and the screen content is updated correctly.


        Xavier


        --
        http://clewn.sourceforge.net gdb support in Vim
      Your message has been successfully submitted and would be delivered to recipients shortly.