Loading ...
Sorry, an error occurred while loading the content.

Re: [PATCH] russian vimtutor is b0rken in UTF-8 locale

Expand Messages
  • Bram Moolenaar
    ... I checked the existing Russian tutor files, and they are exactly the same when converted to utf-8. Thus we can use the utf-8 file as the master and
    Message 1 of 5 , Sep 1, 2006
    • 0 Attachment
      Alexey Froloff wrote:

      > Quick solution: generate tutor.ru.utf-8 from tutor.ru (KOI8-R).
      > This will work right now.
      >
      > Better solution: keep tutor.ru.utf-8, generate .cp1251 and .koi8
      > From it and detect all encodings in tutor.vim. vimtutor will
      > fall back to english in "unsupported" locales (ru_RU.ISO8859-5)
      > for example.

      I checked the existing Russian tutor files, and they are exactly the
      same when converted to utf-8. Thus we can use the utf-8 file as the
      master and generate the others from it.

      I'll include your change to tutor.vim.

      > Attached patch for quick solution. Better solution can wait till
      > 7.1. When, by the way?

      No idea when there will be a 7.1 version. I still have lots of fixes in
      the todo list.

      --
      The greatest lies of all time:
      (1) The check is in the mail.
      (2) We have a really challenging assignment for you.
      (3) I love you.
      (4) All bugs have been fixed.
      (5) This won't hurt a bit.
      (6) Honey, I just need to debug this program and be home in 5 minutes.
      (7) I have just sent you an e-mail about that.
      (8) Of course I'll respect you in the morning.
      (9) I'm from the government, and I'm here to help you.

      /// Bram Moolenaar -- Bram@... -- http://www.Moolenaar.net \\\
      /// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
      \\\ download, build and distribute -- http://www.A-A-P.org ///
      \\\ help me help AIDS victims -- http://ICCF-Holland.org ///
    • Alexey I. Froloff
      ... In this case only tutor.ru.utf-8 shall be kept in source tree. I guess it can t be done right now since patch will be to big. New patch attached, should
      Message 2 of 5 , Sep 1, 2006
      • 0 Attachment
        * Bram Moolenaar <Bram@> [060902 00:28]:
        > > Better solution: keep tutor.ru.utf-8, generate .cp1251 and .koi8
        > > From it and detect all encodings in tutor.vim. vimtutor will
        > > fall back to english in "unsupported" locales (ru_RU.ISO8859-5)
        > > for example.
        > I checked the existing Russian tutor files, and they are exactly the
        > same when converted to utf-8. Thus we can use the utf-8 file as the
        > master and generate the others from it.
        In this case only tutor.ru.utf-8 shall be kept in source tree. I
        guess it can't be done right now since patch will be to big.

        New patch attached, should be included in next release.

        --
        Regards,
        Sir Raorn.
      • Bram Moolenaar
        ... Thanks. I notice you rename tutor.ru to tutor.ru.koi8. Is there anything against keeping the old name? Just to avoid a big diff that doesn t change
        Message 3 of 5 , Sep 2, 2006
        • 0 Attachment
          Alexey Froloff wrote:

          > * Bram Moolenaar <Bram@> [060902 00:28]:
          > > > Better solution: keep tutor.ru.utf-8, generate .cp1251 and .koi8
          > > > From it and detect all encodings in tutor.vim. vimtutor will
          > > > fall back to english in "unsupported" locales (ru_RU.ISO8859-5)
          > > > for example.
          > > I checked the existing Russian tutor files, and they are exactly the
          > > same when converted to utf-8. Thus we can use the utf-8 file as the
          > > master and generate the others from it.
          > In this case only tutor.ru.utf-8 shall be kept in source tree. I
          > guess it can't be done right now since patch will be to big.
          >
          > New patch attached, should be included in next release.

          Thanks. I notice you rename tutor.ru to tutor.ru.koi8. Is there
          anything against keeping the old name? Just to avoid a big diff that
          doesn't change much.

          --
          DINGO: Wicked wicked Zoot ... she is a bad person and she must pay the
          penalty. And here in Castle Anthrax, we have but one punishment
          ... you must tie her down on a bed ... and spank her. Come!
          GIRLS: A spanking! A spanking!
          "Monty Python and the Holy Grail" PYTHON (MONTY) PICTURES LTD

          /// Bram Moolenaar -- Bram@... -- http://www.Moolenaar.net \\\
          /// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
          \\\ download, build and distribute -- http://www.A-A-P.org ///
          \\\ help me help AIDS victims -- http://ICCF-Holland.org ///
        • Alexey I. Froloff
          ... It s because tutor.ru is default file. Now there s no such thing like default russian encoding . I think it s better check if current locale is
          Message 4 of 5 , Sep 2, 2006
          • 0 Attachment
            * Bram Moolenaar <Bram@> [060902 16:23]:
            > Thanks. I notice you rename tutor.ru to tutor.ru.koi8. Is there
            > anything against keeping the old name?
            It's because "tutor.ru" is "default" file. Now there's no such
            thing like "default russian encoding". I think it's better check
            if current locale is supported and fall back to english if not.
            Maybe I'm a little paranoid ;-)

            > Just to avoid a big diff that doesn't change much.
            Well, first version will work now without changing much. Second
            version was supposed to be included in next "tarballed" version.

            --
            Regards,
            Sir Raorn.
          Your message has been successfully submitted and would be delivered to recipients shortly.