Re: [PATCH] SELinux support for vim7
- On Tue, 22 Nov 2005 21:44:24 +0100
Bram Moolenaar <Bram@...> wrote:
> Another solution would be to use the POSIX access-control mechanismThat part of it came verbatim from the Red Hat patch; I haven't
> interface (ACL) for this. Why add a new API? The code only appears
> to copy some info from one file to another...
changed it at all since it seemed to work. I'll see about converting it
to use that interface though.
>OK, looks like I need to brush up on my autoconf-fu and see about
> Anyway, some remarks about the patch:
> - The configure check doesn't actually check if the include file and
> the library are available. Should have a check for that, otherwise
> building fails. And then default to include the selinux feature
> when it's available. Thus it's included when possible, but you can
> disable it when you don't want it.
>That sounds reasonable, though I'd worry about expanding those
> - The code can be put in the mch_get_acl() and mch_set_acl()
> functions, so that it's transparent for most of the code. Then it
> will also work for vim_rename() (renaming/copying a file). And any
> future places that copy a file in some way.
functions too far beyond what the name suggests. As I said above, I'll
look at converting it.