Loading ...
Sorry, an error occurred while loading the content.

Re: Vim 6.4 tests on Win32

Expand Messages
  • Ilya Bobir
    ... +++ Make_dos.mak 2005-10-23 03:30:14.926897600 +0300 @@ -59,7 +65,7 @@ $(VIMPROG) -u dos.vim -U NONE --noplugin -s dotest.in $*.in diff test.out $*.ok
    Message 1 of 13 , Oct 23, 2005
    • 0 Attachment
      A. J. Mechelynck wrote:

      >Илья wrote:
      >
      >
      >
      >/C after a command interpreter name, in all versions of Dos and Windows,
      >means: what follows is a command to be executed, and after that the
      >command interpreter should terminate. No need to disambiguate.
      >
      >Best regards,
      >Tony.
      >
      Then I think here is a patch:

      --- Make_dos.mak.orig 2005-10-23 03:30:08.507667200 +0300
      +++ Make_dos.mak 2005-10-23 03:30:14.926897600 +0300
      @@ -59,7 +65,7 @@
      $(VIMPROG) -u dos.vim -U NONE --noplugin -s dotest.in $*.in
      diff test.out $*.ok
      -del $*.out
      - rename test.out $*.out
      + $(COMSPEC) /C rename test.out $*.out
      -del X*
      -del test.ok
      -del viminfo
    • Bram Moolenaar
      ... Makes sense. I ll include this. Thanks! -- I wish there was a knob on the TV to turn up the intelligence. There s a knob called brightness , but it
      Message 2 of 13 , Nov 22, 2005
      • 0 Attachment
        Ilya Bobir wrote:

        > I have test51 failed because file that should be filled with test output
        > (test.out) been created in on of the previous tests, already exists.
        > :redir > test.out fails and later diff fails, comparing previous test
        > output with current test etalon. Here is a patch to fix this problem.
        >
        > --- testdir/test51.in.orig 2005-10-22 18:49:17.897904000 +0300
        > +++ testdir/test51.in 2005-10-22 18:49:27.241339200 +0300
        > @@ -10,7 +10,7 @@
        > :hi NewGroup term=bold cterm=italic ctermfg=DarkBlue ctermbg=Grey gui=
        > guifg=#00ff00 guibg=Cyan
        > :hi Group2 term= cterm=
        > :hi Group3 term=underline cterm=bold
        > -:redir >test.out
        > +:redir! >test.out
        > :hi NewGroup
        > :hi Group2
        > :hi Group3

        Makes sense. I'll include this. Thanks!

        --
        I wish there was a knob on the TV to turn up the intelligence.
        There's a knob called "brightness", but it doesn't seem to work.

        /// Bram Moolenaar -- Bram@... -- http://www.Moolenaar.net \\\
        /// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
        \\\ download, build and distribute -- http://www.A-A-P.org ///
        \\\ help me help AIDS victims -- http://www.ICCF.nl ///
      • Bram Moolenaar
        ... Hmm, no rename command? On other systems cmd may be missing, thus this isn t a real solution. I rather call this a problem in your setup than a
        Message 3 of 13 , Nov 22, 2005
        • 0 Attachment
          Ilya Bobir wrote:

          > It appeared that the problem is not in test52 itself, but in
          > Make_dos.mak. There is command rename test.out $*.out there. And this
          > command does not work for me. It just doesn't rename files as expected,
          > so some other tests also fail. I made it working with this patch:
          >
          > --- testdir\Make_dos.mak.orig Sat Oct 22 23:22:44 2005
          > +++ testdir\Make_dos.mak Sat Oct 22 23:22:52 2005
          > @@ -59,7 +59,7 @@
          > $(VIMPROG) -u dos.vim -U NONE --noplugin -s dotest.in $*.in
          > diff test.out $*.ok
          > -del $*.out
          > - rename test.out $*.out
          > + cmd /c rename test.out $*.out
          > -del X*
          > -del test.ok
          > -del viminfo

          Hmm, no "rename" command? On other systems "cmd" may be missing, thus
          this isn't a real solution.

          I rather call this a problem in your setup than a problem in Vim...

          --
          hundred-and-one symptoms of being an internet addict:
          141. You'd rather go to http://www.weather.com/ than look out your window.

          /// Bram Moolenaar -- Bram@... -- http://www.Moolenaar.net \\\
          /// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
          \\\ download, build and distribute -- http://www.A-A-P.org ///
          \\\ help me help AIDS victims -- http://www.ICCF.nl ///
        • A. J. Mechelynck
          ... The shell is indeed not always called cmd (on real Dos, and on Win9x, it is usually command ). To circumvent that, use (in Make parlance): $(COMSPEC)
          Message 4 of 13 , Nov 22, 2005
          • 0 Attachment
            Bram Moolenaar wrote:
            > Ilya Bobir wrote:
            >
            >> It appeared that the problem is not in test52 itself, but in
            >> Make_dos.mak. There is command rename test.out $*.out there. And this
            >> command does not work for me. It just doesn't rename files as expected,
            >> so some other tests also fail. I made it working with this patch:
            >>
            >> --- testdir\Make_dos.mak.orig Sat Oct 22 23:22:44 2005
            >> +++ testdir\Make_dos.mak Sat Oct 22 23:22:52 2005
            >> @@ -59,7 +59,7 @@
            >> $(VIMPROG) -u dos.vim -U NONE --noplugin -s dotest.in $*.in
            >> diff test.out $*.ok
            >> -del $*.out
            >> - rename test.out $*.out
            >> + cmd /c rename test.out $*.out
            >> -del X*
            >> -del test.ok
            >> -del viminfo
            >
            > Hmm, no "rename" command? On other systems "cmd" may be missing, thus
            > this isn't a real solution.
            >
            > I rather call this a problem in your setup than a problem in Vim...
            >

            The shell is indeed not always called "cmd" (on "real" Dos, and on
            Win9x, it is usually "command"). To circumvent that, use (in Make parlance):

            $(COMSPEC) /C ren test.out $*.out

            ("ren" or "rename" is internal to the shell on Dos-like systems).

            Best regards,
            Tony.
          • Ilya Bobir
            ... I have default setup of Windows XP. I think there is no rename command on other Windows systems. COMSPEC environment variable should specify command
            Message 5 of 13 , Nov 22, 2005
            • 0 Attachment
              Bram Moolenaar wrote:

              >Ilya Bobir wrote:
              >
              >
              >
              >>It appeared that the problem is not in test52 itself, but in
              >>Make_dos.mak. There is command rename test.out $*.out there. And this
              >>command does not work for me. It just doesn't rename files as expected,
              >>so some other tests also fail. I made it working with this patch:
              >>
              >>--- testdir\Make_dos.mak.orig Sat Oct 22 23:22:44 2005
              >>+++ testdir\Make_dos.mak Sat Oct 22 23:22:52 2005
              >>@@ -59,7 +59,7 @@
              >> $(VIMPROG) -u dos.vim -U NONE --noplugin -s dotest.in $*.in
              >> diff test.out $*.ok
              >> -del $*.out
              >>- rename test.out $*.out
              >>+ cmd /c rename test.out $*.out
              >> -del X*
              >> -del test.ok
              >> -del viminfo
              >>
              >>
              >
              >Hmm, no "rename" command? On other systems "cmd" may be missing, thus
              >this isn't a real solution.
              >
              >I rather call this a problem in your setup than a problem in Vim...
              >
              >
              >
              I have default setup of Windows XP. I think there is no rename command
              on other Windows systems.
              COMSPEC environment variable should specify command interpreter, so
              calling dedicated rename is, probably, only just faster than calling shell.
              Also the patch is like this:

              --- Make_dos.mak.orig 2005-10-23 03:30:08.507667200 +0300
              +++ Make_dos.mak 2005-10-23 03:30:14.926897600 +0300
              @@ -59,7 +65,7 @@
              $(VIMPROG) -u dos.vim -U NONE --noplugin -s dotest.in $*.in
              diff test.out $*.ok
              -del $*.out
              - rename test.out $*.out
              + $(COMSPEC) /C rename test.out $*.out
              -del X*
              -del test.ok
              -del viminfo
            • Craig Barkhouse
              ... Ilya, RENAME (and its synonym REN) has been an internal command in *all* MS operating systems, going back to DOS. Moreover, how is it that DEL works for
              Message 6 of 13 , Nov 22, 2005
              • 0 Attachment
                Ilya Bobir wrote:
                > I have default setup of Windows XP. I think there is no rename command
                > on other Windows systems.
                > COMSPEC environment variable should specify command interpreter, so
                > calling dedicated rename is, probably, only just faster than calling
                > shell.
                > Also the patch is like this:
                >
                > --- Make_dos.mak.orig 2005-10-23 03:30:08.507667200 +0300
                > +++ Make_dos.mak 2005-10-23 03:30:14.926897600 +0300
                > @@ -59,7 +65,7 @@
                > $(VIMPROG) -u dos.vim -U NONE --noplugin -s dotest.in $*.in
                > diff test.out $*.ok
                > -del $*.out
                > - rename test.out $*.out
                > + $(COMSPEC) /C rename test.out $*.out
                > -del X*
                > -del test.ok
                > -del viminfo

                Ilya, RENAME (and its synonym REN) has been an internal command in *all* MS
                operating systems, going back to DOS.

                Moreover, how is it that DEL works for you if RENAME doesn't? DEL (and its
                synonym ERASE) is also an internal command. If we can answer that, then
                maybe we can figure out what's going on. There has to be something out of
                the ordinary.

                Incidentally, what is the value of your COMSPEC environment variable? I
                know you said that you have a default setup of Windows XP, but...
              • Bram Moolenaar
                ... I still have no clue why it works fine for me and not for you. I use this Makefile with several versions of make/nmake/gmake. Can t $COMSPEC be set to a
                Message 7 of 13 , Nov 23, 2005
                • 0 Attachment
                  Ilya Bobir wrote:

                  > >>It appeared that the problem is not in test52 itself, but in
                  > >>Make_dos.mak. There is command rename test.out $*.out there. And this
                  > >>command does not work for me. It just doesn't rename files as expected,
                  > >>so some other tests also fail. I made it working with this patch:
                  > >>
                  > >>--- testdir\Make_dos.mak.orig Sat Oct 22 23:22:44 2005
                  > >>+++ testdir\Make_dos.mak Sat Oct 22 23:22:52 2005
                  > >>@@ -59,7 +59,7 @@
                  > >> $(VIMPROG) -u dos.vim -U NONE --noplugin -s dotest.in $*.in
                  > >> diff test.out $*.ok
                  > >> -del $*.out
                  > >>- rename test.out $*.out
                  > >>+ cmd /c rename test.out $*.out
                  > >> -del X*
                  > >> -del test.ok
                  > >> -del viminfo
                  > >>
                  > >>
                  > >
                  > >Hmm, no "rename" command? On other systems "cmd" may be missing, thus
                  > >this isn't a real solution.
                  > >
                  > >I rather call this a problem in your setup than a problem in Vim...
                  > >
                  > >
                  > I have default setup of Windows XP. I think there is no rename command
                  > on other Windows systems.
                  > COMSPEC environment variable should specify command interpreter, so
                  > calling dedicated rename is, probably, only just faster than calling shell.
                  > Also the patch is like this:
                  >
                  > --- Make_dos.mak.orig 2005-10-23 03:30:08.507667200 +0300
                  > +++ Make_dos.mak 2005-10-23 03:30:14.926897600 +0300
                  > @@ -59,7 +65,7 @@
                  > $(VIMPROG) -u dos.vim -U NONE --noplugin -s dotest.in $*.in
                  > diff test.out $*.ok
                  > -del $*.out
                  > - rename test.out $*.out
                  > + $(COMSPEC) /C rename test.out $*.out
                  > -del X*
                  > -del test.ok
                  > -del viminfo

                  I still have no clue why it works fine for me and not for you. I use
                  this Makefile with several versions of make/nmake/gmake.

                  Can't $COMSPEC be set to a Unix-like shell? Then "rename" would not
                  work. Perhaps a Unix-like shell is being used already. Do you have
                  $SHELL set in the environment?

                  --
                  hundred-and-one symptoms of being an internet addict:
                  154. You fondle your mouse.

                  /// Bram Moolenaar -- Bram@... -- http://www.Moolenaar.net \\\
                  /// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
                  \\\ download, build and distribute -- http://www.A-A-P.org ///
                  \\\ help me help AIDS victims -- http://www.ICCF.nl ///
                Your message has been successfully submitted and would be delivered to recipients shortly.