RE: patch 6.2.489
- Robert Webb wrote:
> > A partial solution may be to generate the session file in a slightlyNow that you tested it, yes.
> > different way. I guess the main problem is when all the files are
> > already open somewhere else. Trying to load the first file before
> > creating all the windows and quitting when that first file can't be
> > loaded, something like that.
> > I had a look at the code in makeopens(), but it's not that simple...
> > I made an attempt, see the patch below. I'm not sure this is without
> > problems, changing the sequence of commands in a session script is
> > tricky.
> Thanks for the patch. It works for me. Can it become official?
> > > Finally, a minor point. The order of buttons is:Looks OK, but it changes a translated string. I'll keep it for later, I
> > > Open Read-Only, Edit anyway, Recover, Quit, Abort, Delete it
> > >
> > > I think it would make more sense to put them in this order:
> > > Open Read-Only, Edit anyway, Recover, Delete it, Quit, Abort
> > Well, the "Delete it" alternative is optional. Moving it means the
> > returned number depends on the "Delete it" being present or not, makes
> > the code more complicated. I don't think it's worth changing.
> I see what you mean in the code. It's not too hard to fix though, so
> I've attached a patch to do it. I can't test the case where the
> "Delete it" button doesn't appear, which happens inside:
> # if defined(UNIX) || defined(__EMX__) || defined(VMS)
> But it should work. I searched the docs and couldn't find reference to
> these button labels, so presumably no patch required there :-)
find it more important to have the translations than the ordering for
> Probably my first patch in more than five years! :-)Welcome back! :-)
From "know your smileys":
:-& Eating spaghetti
/// Bram Moolenaar -- Bram@... -- http://www.Moolenaar.net \\\
/// Sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\ Project leader for A-A-P -- http://www.A-A-P.org ///
\\\ Buy at Amazon and help AIDS victims -- http://ICCF.nl/click1.html ///