Loading ...
Sorry, an error occurred while loading the content.

patch 6.2.428

Expand Messages
  • Zvi Har'El
    Hi, In my solaris 2.6 and 2.8 systems, vim with 6.2.248 does not compile, with the error gui_gtk_x11.c: In function `key_press_event : gui_gtk_x11.c:1101:
    Message 1 of 3 , Apr 2 6:33 AM
    • 0 Attachment
      Hi,

      In my solaris 2.6 and 2.8 systems, vim with 6.2.248 does not compile, with the
      error

      gui_gtk_x11.c: In function `key_press_event':
      gui_gtk_x11.c:1101: `xim_changed_while_preediting' undeclared (first use in this function)
      gui_gtk_x11.c:1101: (Each undeclared identifier is reported only once
      gui_gtk_x11.c:1101: for each function it appears in.)
      make[1]: *** [objects/gui_gtk_x11.o] Error 1

      The problem is with a patch chunk

      ***************
      *** 1090,1095 ****
      --- 1095,1106 ----
      if (len == 0) /* Unrecognized key */
      return TRUE;

      + #if defined(FEAT_XIM) && defined(FEAT_GUI_GTK) && !defined(HAVE_GTK2)
      + /* cancel or type backspace. for GTK2, im_commit_cb() do same */
      + preedit_start_col = MAXCOL;
      + xim_changed_while_preediting = TRUE;
      + #endif
      +
      /* Special keys (and a few others) may have modifiers. Also when using a
      * double-byte encoding (can't set the 8th bit). */
      if (len == -3 || key_sym == GDK_space || key_sym == GDK_Tab

      Aparatly, the symbol xim_changed_while_preediting is not defined, which means
      there is somthing wrong with the conditional compilation. I am compiline vim
      with the CONF_OPT_FEAT=--with-features=big parameter. I looked in
      auto/config.h, and it had FEAT_XIM defined and HAVE_GTK2 undefined.
      FEAT_GUI_GTK is somehow added on the command line, as I see from the printout
      of vim --version for the previous version I compiled:


      VIM - Vi IMproved 6.2 (2003 Jun 1, compiled Apr 1 2004 19:58:03)
      Included patches: 1-426
      Compiled by rl@...
      Big version with GTK GUI. Features included (+) or not (-):
      +arabic +autocmd +balloon_eval +browse ++builtin_terms +byte_offset +cindent
      +clientserver +clipboard +cmdline_compl +cmdline_hist +cmdline_info +comments
      +cryptv +cscope +dialog_con_gui +diff +digraphs +dnd -ebcdic +emacs_tags +eval
      +ex_extra +extra_search +farsi +file_in_path +find_in_path +folding -footer
      +fork() +gettext -hangul_input +iconv +insert_expand +jumplist +keymap +langmap
      +libcall +linebreak +lispindent +listcmds +localmap +menu +mksession
      +modify_fname +mouse +mouseshape +mouse_dec -mouse_gpm -mouse_jsbterm
      +mouse_netterm +mouse_xterm +multi_byte +multi_lang +netbeans_intg -osfiletype
      +path_extra -perl +postscript +printer -python +quickfix +rightleft -ruby
      +scrollbind +signs +smartindent -sniff +statusline -sun_workshop +syntax
      +tag_binary +tag_old_static -tag_any_white -tcl +terminfo +termresponse
      +textobjects +title +toolbar +user_commands +vertsplit +virtualedit +visual
      +visualextra +viminfo +vreplace +wildignore +wildmenu +windows +writebackup
      +X11 +xfontset +xim +xsmp_interact +xterm_clipboard -xterm_save
      system vimrc file: "$VIM/vimrc"
      user vimrc file: "$HOME/.vimrc"
      user exrc file: "$HOME/.exrc"
      system gvimrc file: "$VIM/gvimrc"
      user gvimrc file: "$HOME/.gvimrc"
      system menu file: "$VIMRUNTIME/menu.vim"
      fall-back for $VIM: "/usr/local/share/vim"
      Compilation: gcc -c -I. -Iproto -DHAVE_CONFIG_H -DFEAT_GUI_GTK -I/usr/local/include/gtk-1.2 -I/usr/local/include/glib-1.2 -I/usr/local/lib/glib/include -I/usr/openwin/include -O2 -fno-strength-reduce -Wall -I/usr/openwin/include
      Linking: gcc -L/usr/openwin/lib -R/usr/openwin/lib -o vim -L/usr/local/lib -L/usr/openwin/lib -R/usr/openwin/lib -lgtk -lgdk -lgmodule -lglib -ldl -lXext -lm -lXt -lX11 -lSM -lICE -ltermlib -lnsl -lsocket -liconv -ldl

      I also have a solaris 2.9, however in it I didn't have any trouble:

      VIM - Vi IMproved 6.2 (2003 Jun 1, compiled Apr 2 2004 15:30:06)
      Included patches: 1-429
      Compiled by rl@newleeor
      Big version with X11-Motif GUI. Features included (+) or not (-):
      +arabic +autocmd +balloon_eval +browse ++builtin_terms +byte_offset +cindent
      +clientserver +clipboard +cmdline_compl +cmdline_hist +cmdline_info +comments
      +cryptv +cscope +dialog_con_gui +diff +digraphs -dnd -ebcdic +emacs_tags +eval
      +ex_extra +extra_search +farsi +file_in_path +find_in_path +folding -footer
      +fork() +gettext -hangul_input +iconv +insert_expand +jumplist +keymap +langmap
      +libcall +linebreak +lispindent +listcmds +localmap +menu +mksession
      +modify_fname +mouse +mouseshape +mouse_dec -mouse_gpm -mouse_jsbterm
      +mouse_netterm +mouse_xterm +multi_byte +multi_lang +netbeans_intg -osfiletype
      +path_extra -perl +postscript +printer -python +quickfix +rightleft -ruby
      +scrollbind +signs +smartindent -sniff +statusline -sun_workshop +syntax
      +tag_binary +tag_old_static -tag_any_white -tcl +terminfo +termresponse
      +textobjects +title +toolbar +user_commands +vertsplit +virtualedit +visual
      +visualextra +viminfo +vreplace +wildignore +wildmenu +windows +writebackup
      +X11 +xfontset +xim +xsmp_interact +xterm_clipboard -xterm_save
      system vimrc file: "$VIM/vimrc"
      user vimrc file: "$HOME/.vimrc"
      user exrc file: "$HOME/.exrc"
      system gvimrc file: "$VIM/gvimrc"
      user gvimrc file: "$HOME/.gvimrc"
      system menu file: "$VIMRUNTIME/menu.vim"
      fall-back for $VIM: "/usr/local/share/vim"
      Compilation: gcc -c -I. -Iproto -DHAVE_CONFIG_H -DFEAT_GUI_MOTIF -I/usr/dt/include -O2 -fno-strength-reduce -Wall -I/usr/openwin/include
      Linking: gcc -L/usr/dt/lib -R /usr/dt/lib -L/usr/openwin/lib -R/usr/openwin/lib -o vim -lXmu -lXext -lXm -lXpm -lXt -lX11 -lSM -lICE -ltermlib -lnsl -lsocket -ldl


      You see here it decided to use the X11-Motif gui. I also didn't have any
      trouble with my RedHat 9 system:

      ~$ vim --version
      VIM - Vi IMproved 6.2 (2003 Jun 1, compiled Apr 2 2004 15:25:20)
      Included patches: 1-429
      Compiled by rl@bambi
      Big version with GTK2 GUI. Features included (+) or not (-):
      +arabic +autocmd +balloon_eval +browse ++builtin_terms +byte_offset +cindent
      +clientserver +clipboard +cmdline_compl +cmdline_hist +cmdline_info +comments
      +cryptv +cscope +dialog_con_gui +diff +digraphs +dnd -ebcdic +emacs_tags +eval
      +ex_extra +extra_search +farsi +file_in_path +find_in_path +folding -footer
      +fork() +gettext -hangul_input +iconv +insert_expand +jumplist +keymap +langmap
      +libcall +linebreak +lispindent +listcmds +localmap +menu +mksession
      +modify_fname +mouse +mouseshape +mouse_dec +mouse_gpm -mouse_jsbterm
      +mouse_netterm +mouse_xterm +multi_byte +multi_lang +netbeans_intg -osfiletype
      +path_extra -perl +postscript +printer -python +quickfix +rightleft -ruby
      +scrollbind +signs +smartindent -sniff +statusline -sun_workshop +syntax
      +tag_binary +tag_old_static -tag_any_white -tcl +terminfo +termresponse
      +textobjects +title +toolbar +user_commands +vertsplit +virtualedit +visual
      +visualextra +viminfo +vreplace +wildignore +wildmenu +windows +writebackup
      +X11 -xfontset +xim +xsmp_interact +xterm_clipboard -xterm_save
      system vimrc file: "$VIM/vimrc"
      user vimrc file: "$HOME/.vimrc"
      user exrc file: "$HOME/.exrc"
      system gvimrc file: "$VIM/gvimrc"
      user gvimrc file: "$HOME/.gvimrc"
      system menu file: "$VIMRUNTIME/menu.vim"
      fall-back for $VIM: "/usr/local/share/vim"
      Compilation: gcc -c -I. -Iproto -DHAVE_CONFIG_H -DFEAT_GUI_GTK -I/usr/include/g
      tk-2.0 -I/usr/lib/gtk-2.0/include -I/usr/include/atk-1.0 -I/usr/include/pango-1.
      0 -I/usr/X11R6/include -I/usr/include/freetype2 -I/usr/include/glib-2.0 -I/usr/l
      ib/glib-2.0/include -O2 -fno-strength-reduce -Wall -I/usr/X11R6/include

      Linking: gcc -L/usr/X11R6/lib -L/usr/local/lib -o vim -Wl,--export-dynamic -
      lgtk-x11-2.0 -lgdk-x11-2.0 -latk-1.0 -lgdk_pixbuf-2.0 -lm -lpangoxft-1.0 -lpango
      x-1.0 -lpango-1.0 -lgobject-2.0 -lgmodule-2.0 -ldl -lglib-2.0 -lXt -lncurses -
      lgpm -ldl



      Can you tell me what is missing from my GTK on solaris?


      --
      Dr. Zvi Har'El mailto:rl@... Department of Mathematics
      tel:+972-54-227607 icq:179294841 Technion - Israel Institute of Technology
      fax:+972-4-8293388 http://www.math.technion.ac.il/~rl/ Haifa 32000, ISRAEL
      "If you can't say somethin' nice, don't say nothin' at all." -- Thumper (1942)
      Friday, 11 Nisan 5764, 2 April 2004, 4:11PM
    • Bram Moolenaar
      ... Right, this chunk doesn t belong in this patch. Delete that chunk from the patch or, if you already applied it, use the patch below to undo. Dave, please
      Message 2 of 3 , Apr 2 7:29 AM
      • 0 Attachment
        Zvi Har'El wrote:

        > In my solaris 2.6 and 2.8 systems, vim with 6.2.248 does not compile, with the
        > error
        >
        > gui_gtk_x11.c: In function `key_press_event':
        > gui_gtk_x11.c:1101: `xim_changed_while_preediting' undeclared (first use in this function)
        > gui_gtk_x11.c:1101: (Each undeclared identifier is reported only once
        > gui_gtk_x11.c:1101: for each function it appears in.)
        > make[1]: *** [objects/gui_gtk_x11.o] Error 1
        >
        > The problem is with a patch chunk

        Right, this chunk doesn't belong in this patch. Delete that chunk from
        the patch or, if you already applied it, use the patch below to undo.

        Dave, please don't include that chunk in CVS.

        Sorry!


        *** src/gui_gtk_x11.c~ Fri Apr 2 12:52:16 2004
        --- src/gui_gtk_x11.c Fri Apr 2 17:25:30 2004
        ***************
        *** 1095,1106 ****
        if (len == 0) /* Unrecognized key */
        return TRUE;

        - #if defined(FEAT_XIM) && defined(FEAT_GUI_GTK) && !defined(HAVE_GTK2)
        - /* cancel or type backspace. for GTK2, im_commit_cb() do same */
        - preedit_start_col = MAXCOL;
        - xim_changed_while_preediting = TRUE;
        - #endif
        -
        /* Special keys (and a few others) may have modifiers. Also when using a
        * double-byte encoding (can't set the 8th bit). */
        if (len == -3 || key_sym == GDK_space || key_sym == GDK_Tab
        --- 1095,1100 ----

        --
        hundred-and-one symptoms of being an internet addict:
        245. You use Real Audio to listen to a radio station from a distant
        city rather than turn on your stereo system.

        /// Bram Moolenaar -- Bram@... -- http://www.Moolenaar.net \\\
        /// Sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
        \\\ Project leader for A-A-P -- http://www.A-A-P.org ///
        \\\ Buy at Amazon and help AIDS victims -- http://ICCF.nl/click1.html ///
      • Zvi Har'El
        Dear Bram, Thanks for the prompe answer and fix. It worked! Best, Zvi. ... -- Dr. Zvi Har El mailto:rl@math.technion.ac.il Department of Mathematics
        Message 3 of 3 , Apr 2 7:39 AM
        • 0 Attachment
          Dear Bram,

          Thanks for the prompe answer and fix. It worked!

          Best,

          Zvi.

          On Fri, 02 Apr 2004 17:29:31 +0200, Bram Moolenaar wrote about "Re: patch 6.2.428":
          >
          > Zvi Har'El wrote:
          >
          > > In my solaris 2.6 and 2.8 systems, vim with 6.2.248 does not compile, with the
          > > error
          > >
          > > gui_gtk_x11.c: In function `key_press_event':
          > > gui_gtk_x11.c:1101: `xim_changed_while_preediting' undeclared (first use in this function)
          > > gui_gtk_x11.c:1101: (Each undeclared identifier is reported only once
          > > gui_gtk_x11.c:1101: for each function it appears in.)
          > > make[1]: *** [objects/gui_gtk_x11.o] Error 1
          > >
          > > The problem is with a patch chunk
          >
          > Right, this chunk doesn't belong in this patch. Delete that chunk from
          > the patch or, if you already applied it, use the patch below to undo.
          >
          > Dave, please don't include that chunk in CVS.
          >
          > Sorry!
          >
          >
          > *** src/gui_gtk_x11.c~ Fri Apr 2 12:52:16 2004
          > --- src/gui_gtk_x11.c Fri Apr 2 17:25:30 2004
          > ***************
          > *** 1095,1106 ****
          > if (len == 0) /* Unrecognized key */
          > return TRUE;
          >
          > - #if defined(FEAT_XIM) && defined(FEAT_GUI_GTK) && !defined(HAVE_GTK2)
          > - /* cancel or type backspace. for GTK2, im_commit_cb() do same */
          > - preedit_start_col = MAXCOL;
          > - xim_changed_while_preediting = TRUE;
          > - #endif
          > -
          > /* Special keys (and a few others) may have modifiers. Also when using a
          > * double-byte encoding (can't set the 8th bit). */
          > if (len == -3 || key_sym == GDK_space || key_sym == GDK_Tab
          > --- 1095,1100 ----
          >
          > --
          > hundred-and-one symptoms of being an internet addict:
          > 245. You use Real Audio to listen to a radio station from a distant
          > city rather than turn on your stereo system.
          >
          > /// Bram Moolenaar -- Bram@... -- http://www.Moolenaar.net \\\
          > /// Sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
          > \\\ Project leader for A-A-P -- http://www.A-A-P.org ///
          > \\\ Buy at Amazon and help AIDS victims -- http://ICCF.nl/click1.html ///

          --
          Dr. Zvi Har'El mailto:rl@... Department of Mathematics
          tel:+972-54-227607 icq:179294841 Technion - Israel Institute of Technology
          fax:+972-4-8293388 http://www.math.technion.ac.il/~rl/ Haifa 32000, ISRAEL
          "If you can't say somethin' nice, don't say nothin' at all." -- Thumper (1942)
          Friday, 11 Nisan 5764, 2 April 2004, 5:38PM
        Your message has been successfully submitted and would be delivered to recipients shortly.