Re: Patch - Win32 GVIM (SW_INVALIDATE)
- Michael Wookey wrote:
> I've tidied up this patch based upon the feedback received so far andIt looks like this doesn't take care of another program opening a popup
> obtained some benchmarks. The "region check" only occurs in the
> following cases:
> - after the window is resized
> - after the window is moved
> - after the window obtains focus
> These handle the cases where there may be an "always on top" window
> overlapping gvim as the gvim window may have been resized (but now
> under another window), or moved (and may be offscreen/under another
> window). The calculation is always done when gvim gets focus incase
> there may be other "on top" windows obscuring the main gvim window.
window (splash window) without a focus change. This may happen when Vim
is busy with a slow script, or another program is popping up a window
without obtaining focus.
Is the gain in speed for avoiding the check for overlaps enough to
justify adding these tricks? It's very bad to add code that may have
obscure problems that happen in rare situations.
hundred-and-one symptoms of being an internet addict:
88. Every single time you press the 'Get mail' button...it does get new mail.
/// Bram Moolenaar -- Bram@... -- http://www.Moolenaar.net \\\
/// Creator of Vim - Vi IMproved -- http://www.Vim.org \\\
\\\ Project leader for A-A-P -- http://www.A-A-P.org ///
\\\ Help AIDS victims, buy here: http://ICCF-Holland.org/click1.html ///
- Bram Moolenaar wrote:
> Also check what happens if part of the Vim window extends to below theHelmut's patch works correctly with overlapping windows. It is simply slow. When
> screen and then scroll up the text (with commands, scrollbar or mouse
> scroll wheel).
gvim is obscured by the task bar, it will leave "text trails" while scrolling,
but redraw correctly when scrolling stops.