Loading ...
Sorry, an error occurred while loading the content.

Re: os_mswin.c with Patch 6.1.421 does not compile from Make_w16.mak

Expand Messages
  • Bram Moolenaar
    ... [...] In other words: Passing an int pointer to a function that expects a long_u pointer. I ll include the fix. Thanks! ... Using int is fine, so long
    Message 1 of 4 , Apr 4, 2003
      Walter Briscoe wrote:

      > >> In Vim 6.1.435, I am doing some work on transferring functionality to
      > >> gui_w48.c from gui_w16.c and gui_w32.c I tried running Make_w16.mak so I
      > >> could test gui_w16.c. I was surprised to get the following diagnostics:
      > >
      > >Yeah, an #ifdef FEAT_MBYTE was missing. Vince made a patch for it, I'll
      > >send it out asap.
      > I found another problem with Patch 6.1.421. I am sorry I missed it
      > yesterday. I applied the #ifdef FEAT_MBYTE change and got the following:
      > Warning .\os_mswin.c 1171: Suspicious pointer conversion in function
      > clip_mch_set_selection

      In other words: Passing an int pointer to a function that expects a
      long_u pointer. I'll include the fix. Thanks!

      > Of course, many years ago, I was told to avoid int in most
      > circumstances. I guess we are stuck with it in Vim :-)

      Using "int" is fine, so long as you take into account it can be anything
      from 16 to 64 bit.

      ARTHUR: Be quiet!
      DENNIS: Well you can't expect to wield supreme executive power just 'cause
      some watery tart threw a sword at you!
      ARTHUR: Shut up!
      DENNIS: I mean, if I went around sayin' I was an empereror just because some
      moistened bint had lobbed a scimitar at me they'd put me away!
      The Quest for the Holy Grail (Monty Python)

      /// Bram Moolenaar -- Bram@... -- http://www.Moolenaar.net \\\
      /// Creator of Vim - Vi IMproved -- http://www.Vim.org \\\
      \\\ Project leader for A-A-P -- http://www.A-A-P.org ///
      \\\ Help AIDS victims, buy at Amazon -- http://ICCF.nl/click1.html ///
    Your message has been successfully submitted and would be delivered to recipients shortly.