Re: Vim GTK+ 2 patches
- View SourceHey Marcelo,
On Die, 2003-03-04 at 11:23, Marcelo E. Magallon wrote:
> Hi Daniel,
> I sent a mail to vim-dev regarding this, but it's not in the archives,
> so I guess it didn't show up. I'm not subscribed to vim-dev, and it
> seems mail from non-subscribers are silently dropped.
Oh yes. I found it out the hard way as well :-)
> Attached are following patches:
> skip checks for GTK2 if configuring without a GUI, one-liner.
Ah, silly oversight. Thanks.
> horrible hack to get vim to compile if compiling without a GUI.
> There's probably a much better way to do this. The problem is
> mbyte.proto needs GdkKeyEvent.
Thanks again. I put this into src/proto.h where the other "horrible
hacks" are. (It seems to be the canonical Vim way to do this, 'cuz the
proto files are supposed to be autogenerated.)
> A vim compile *with* a GTK+ 2 GUI will complain more or less
> continously because it tries to change the window title using GTK+
> calls if t_ts is not set. It's extremely annoying. Maybe the check
> has to be moved upwards in the function call stack, but to me it
> seemed natural to place it here.
Whoa, that's gross. Thanks for reporting this -- I'd never have
noticed. I had to unset 't_ts' and redirect stderr to a file to make
the error messages visible :)
I put the check into os_unix.c (mch_settitle) and reenabled
set_x11_title() which can apparently be used in the terminal as well.
I had disabled it entirely if compiling for GTK+ but that was apparently
a mistake. Thanks for making me fix this!
Here's the new patch with all of your fixes included:
> Greetings and thanks for the great work,
Greetings and much thanks for the fixups,