Loading ...
Sorry, an error occurred while loading the content.

71191Re: [PATCH] (3/3) _vim_runtimepath_ special directory and some small stuff

Expand Messages
  • Bram Moolenaar
    Jun 13, 2013
    • 0 Attachment
      Jun Takimoto wrote:

      > On 2013/06/12, at 21:41, Bram Moolenaar <Bram@...> wrote:
      > > Thanks for the updates. Unfortunately, now both test 86 and 87 fail for
      > > me.
      > (snip)
      > > -2,xx
      > > -before
      > > -after
      >
      > I'm getting the same error (python2.7.3 and python 3.2.3).
      >
      > It seems the tests are failing when they try to 'import module'.
      > The module 'module' is in testdir/python{2,3}/module.py, which
      > in turn imports a module named 'before_1'.
      >
      > Where is this module 'before_1' ?

      Solved in patch 7.3.1183.

      > In addition, if I configure --with-python3interp=dynamic,
      > test87 core dumps.
      > This core dump can be fixed by the following patch:
      >
      >
      > diff -r 8a49630c8a5f src/if_python3.c
      > --- a/src/if_python3.c Wed Jun 12 22:41:37 2013 +0200
      > +++ b/src/if_python3.c Thu Jun 13 12:25:31 2013 +0900
      > @@ -488,7 +488,7 @@
      > {"PyEval_InitThreads", (PYTHON_PROC*)&py3_PyEval_InitThreads},
      > {"PyEval_RestoreThread", (PYTHON_PROC*)&py3_PyEval_RestoreThread},
      > {"PyEval_SaveThread", (PYTHON_PROC*)&py3_PyEval_SaveThread},
      > - {"PyArg_Parse", (PYTHON_PROC*)&py3_PyArg_Parse},
      > + {"_PyArg_Parse_SizeT", (PYTHON_PROC*)&py3_PyArg_Parse},
      > {"Py_IsInitialized", (PYTHON_PROC*)&py3_Py_IsInitialized},
      > {"_PyObject_NextNotImplemented", (PYTHON_PROC*)&py3__PyObject_NextNotImplemented},
      > {"_Py_NoneStruct", (PYTHON_PROC*)&py3__Py_NoneStruct},

      Thanks, I'll include that.

      > Note:
      > Since PY_SSIZE_T_CLEAN is unconditionally defined in if_python3.c
      > (and I think it is correct), the following part in if_python3.c
      > (line 428) may be simplified to always use ssize_t-clean version.
      >
      > # ifndef PY_SSIZE_T_CLEAN
      > {"PyArg_ParseTuple", (PYTHON_PROC*)&py3_PyArg_ParseTuple},
      > {"Py_BuildValue", (PYTHON_PROC*)&py3_Py_BuildValue},
      > # else
      > {"_PyArg_ParseTuple_SizeT", (PYTHON_PROC*)&py3_PyArg_ParseTuple},
      > {"_Py_BuildValue_SizeT", (PYTHON_PROC*)&py3_Py_BuildValue},
      > # endif

      Yes, for Python 3 PY_SSIZE_T_CLEAN should always be defined.

      --
      hundred-and-one symptoms of being an internet addict:
      187. You promise yourself that you'll only stay online for another
      15 minutes...at least once every hour.

      /// Bram Moolenaar -- Bram@... -- http://www.Moolenaar.net \\\
      /// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
      \\\ an exciting new programming language -- http://www.Zimbu.org ///
      \\\ help me help AIDS victims -- http://ICCF-Holland.org ///

      --
      --
      You received this message from the "vim_dev" maillist.
      Do not top-post! Type your reply below the text you are replying to.
      For more information, visit http://www.vim.org/maillist.php

      ---
      You received this message because you are subscribed to the Google Groups "vim_dev" group.
      To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscribe@....
      For more options, visit https://groups.google.com/groups/opt_out.
    • Show all 26 messages in this topic