69820Re: modeless-selection distorts all characters in gVim
- May 19, 2013On Sunday, May 5, 2013 4:31:03 PM UTC-5, Bram Moolenaar wrote:
> Yukihiro Nakadaira wrote:I finally got a chance to try applying the patch and it seems to work as advertised. I have no idea whether it has unintended side effects. I'll run with it for a while to see if I notice any. But I don't usually use modeless selection for anything so I doubt I'd see anything in my normal use.
> > It seems that the current invert drawing method (dst = fg XOR bg XOR dst)
> > is not good for anti-aliased font. I think that using GDK_INVERT is
> > good for it.
> > diff -r 9e3cdd762964 src/gui_gtk_x11.c
> > --- a/src/gui_gtk_x11.c Sat May 04 04:40:15 2013 +0200
> > +++ b/src/gui_gtk_x11.c Sun May 05 16:23:33 2013 +0900
> > @@ -5271,13 +5271,9 @@
> > if (gui.drawarea->window == NULL)
> > return;
> > - values.foreground.pixel = gui.norm_pixel ^ gui.back_pixel;
> > - values.background.pixel = gui.norm_pixel ^ gui.back_pixel;
> > - values.function = GDK_XOR;
> > + values.function = GDK_INVERT;
> > invert_gc = gdk_gc_new_with_values(gui.drawarea->window,
> > &values,
> > - GDK_GC_FOREGROUND |
> > - GDK_GC_BACKGROUND |
> > GDK_GC_FUNCTION);
> > gdk_gc_set_exposures(invert_gc, gui.visibility !=
> > GDK_VISIBILITY_UNOBSCURED);
> Thanks for making a patch.
> Can some users try this out and give feedback?
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php
You received this message because you are subscribed to the Google Groups "vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscribe@....
For more options, visit https://groups.google.com/groups/opt_out.
- << Previous post in topic