Loading ...
Sorry, an error occurred while loading the content.

69799Re: Patch 7.3.970

Expand Messages
  • Tony Mechelynck
    May 19, 2013
    • 0 Attachment
      On 19/05/13 22:08, Bram Moolenaar wrote:
      > Tony Mechelynck wtote:
      >> On 19/05/13 19:44, Bram Moolenaar wrote:
      >>> I wrote:
      >>>> Patch 7.3.970
      >>> All the tests I could do with the new engine pass. However, it is
      >>> noticeable slower than the old engine. If this bothers you, set the
      >>> 'regexpengine' option to one.
      >>> If you spot a mistake in regexp pattern matching, please send a
      >>> reproducible example, so that we can add it to the tests.
      >> Compiling on linux_x86_64:
      > Can you try changing EMSG2() to EMSGN()?
      >> In file included from /usr/include/string.h:642:0,
      >> from os_unix.h:522,
      >> from vim.h:268,
      >> from regexp.c:47:
      >> In function ‘strcpy’,
      >> inlined from ‘nfa_recognize_char_class.constprop.24’ at
      >> regexp_nfa.c:379:5:
      >> /usr/include/bits/string3.h:105:3: warning: call to
      >> __builtin___strcpy_chk will always overflow destination buffer [enabled
      >> by default]
      > Yep, buffer should be 10 characters.
      >> The above is with "tiny" features but "huge" features give me the same
      >> (with a much longer gcc command line).

      No messages and no crash with the attached patch. -- Thanks Bram.

      Best regards,
      Computers will not be perfected until they can compute how much more
      than the estimate the job will cost.

      You received this message from the "vim_dev" maillist.
      Do not top-post! Type your reply below the text you are replying to.
      For more information, visit http://www.vim.org/maillist.php

      You received this message because you are subscribed to the Google Groups "vim_dev" group.
      To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscribe@....
      For more options, visit https://groups.google.com/groups/opt_out.
    • Show all 25 messages in this topic