Loading ...
Sorry, an error occurred while loading the content.

69790Re: Patch 7.3.970

Expand Messages
  • Bram Moolenaar
    May 19, 2013
    • 0 Attachment
      Tony Mechelynck wtote:

      > On 19/05/13 19:44, Bram Moolenaar wrote:
      > >
      > > I wrote:
      > >
      > >> Patch 7.3.970
      > >
      > > All the tests I could do with the new engine pass. However, it is
      > > noticeable slower than the old engine. If this bothers you, set the
      > > 'regexpengine' option to one.
      > >
      > > If you spot a mistake in regexp pattern matching, please send a
      > > reproducible example, so that we can add it to the tests.
      > >
      >
      > Compiling on linux_x86_64:
      >
      > gcc -c -I. -Iproto -DHAVE_CONFIG_H -I/usr/local/include -O2
      > -fno-strength-reduce -Wall -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=1
      > -o objects/regexp.o regexp.c
      > In file included from regexp.c:7749:0:
      > regexp_nfa.c: In function ‘nfa_regatom’:
      > regexp_nfa.c:762:6: warning: cast to pointer from integer of different
      > size [-Wint-to-pointer-cast]
      > regexp_nfa.c:773:6: warning: cast to pointer from integer of different
      > size [-Wint-to-pointer-cast]
      > regexp_nfa.c:819:7: warning: cast to pointer from integer of different
      > size [-Wint-to-pointer-cast]
      > regexp_nfa.c: In function ‘nfa_regpiece’:
      > regexp_nfa.c:1366:7: warning: cast to pointer from integer of different
      > size [-Wint-to-pointer-cast]

      Can you try changing EMSG2() to EMSGN()?

      > In file included from /usr/include/string.h:642:0,
      > from os_unix.h:522,
      > from vim.h:268,
      > from regexp.c:47:
      > In function ‘strcpy’,
      > inlined from ‘nfa_recognize_char_class.constprop.24’ at
      > regexp_nfa.c:379:5:
      > /usr/include/bits/string3.h:105:3: warning: call to
      > __builtin___strcpy_chk will always overflow destination buffer [enabled
      > by default]

      Yep, buffer should be 10 characters.

      > The above is with "tiny" features but "huge" features give me the same
      > (with a much longer gcc command line).

      --
      The Law, in its majestic equality, forbids the rich, as well as the
      poor, to sleep under the bridges, to beg in the streets, and to steal
      bread. -- Anatole France

      /// Bram Moolenaar -- Bram@... -- http://www.Moolenaar.net \\\
      /// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
      \\\ an exciting new programming language -- http://www.Zimbu.org ///
      \\\ help me help AIDS victims -- http://ICCF-Holland.org ///

      --
      --
      You received this message from the "vim_dev" maillist.
      Do not top-post! Type your reply below the text you are replying to.
      For more information, visit http://www.vim.org/maillist.php

      ---
      You received this message because you are subscribed to the Google Groups "vim_dev" group.
      To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscribe@....
      For more options, visit https://groups.google.com/groups/opt_out.
    • Show all 25 messages in this topic