Loading ...
Sorry, an error occurred while loading the content.

69714Re: [PATCH] Move more data to if_py_both.h

Expand Messages
  • Ken Takata
    May 18, 2013
    • 0 Attachment
      Hi Bram,

      2013/05/18 Sat 21:07:52 UTC+9 Bram Moolenaar wrote:
      > Xavier de Gaye wrote:
      >
      > > On Fri, May 17, 2013 at 11:56 PM, ZyX wrote:
      > > > These patches make all variants of invoking python use the same
      > > > DoPyCommand function (renamed from DoPy3Command and DoPythonCommand)
      > > > and moved actual implementation to if_py_both. Also made new py*do
      > > > commands use this and use other existing functions (like
      > > > GetBufferLine in place of pyline nonsense (it did not convert
      > > > newlines to nulls)).
      > >
      > >
      > > Would not it be better to have this code in an if_py_both.c source
      > > file instead of the if_py_both.h header file. It seems that
      > > if_py_both.h and dosinst.h are the only files in the vim source code
      > > that are actually source files instead of header files.
      >
      > The new regexp code adds a regexp_nfa.c file that is included in
      > regexp.c. It's a bit inconsistent. Not sure if I should call it
      > regexp_nfa.h instead.

      There is another example: gui_w48.c.
      The file is included in gui_w16.c and gui_w32.c.

      Thanks,
      Ken Takata

      --
      --
      You received this message from the "vim_dev" maillist.
      Do not top-post! Type your reply below the text you are replying to.
      For more information, visit http://www.vim.org/maillist.php

      ---
      You received this message because you are subscribed to the Google Groups "vim_dev" group.
      To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscribe@....
      For more options, visit https://groups.google.com/groups/opt_out.
    • Show all 5 messages in this topic