Loading ...
Sorry, an error occurred while loading the content.

66733Re: [patch] implement undo in :s_flags

Expand Messages
  • Bram Moolenaar
    Oct 9, 2012
      Christian Brabandt wrote:

      > On Sun, September 30, 2012 14:42, Bram Moolenaar wrote:
      > >> attached patch implements undo when doing :s/.../.../gc
      > >
      > > Yeah, this is useful. But also tricky, if the undo is done wrong then
      > > the text may get messed up. Can you think of situations where somethin=
      > g
      > > could go wrong? And it would be nice to have tests for that.
      > >
      >
      > Updated patch also works for undo in vi-compatible way and includes a
      > test. The testing part was harder than expected, because vim doesn't
      > sync undo, when reading from a script, so I explicitly sync undo
      > when using :s/.../.../c and reading from a script.
      >
      > There is one limitation so: Vim only stores up to 256 places for where
      > to start searching after an undo. If you have replaced more, Vim won't
      > start at the correct column afterwards. I thought about using a garray_T
      > for storing the column, but wasn't successful.

      Thanks. I'll have a look at it later.

      --
      (letter from Mark to Mike, about the film's probable certificate)
      For an 'A' we would have to: Lose as many shits as possible; Take Jesus
      Christ out, if possible; Loose "I fart in your general direction"; Lose
      "the oral sex"; Lose "oh, fuck off"; Lose "We make castanets out of your
      testicles"
      "Monty Python and the Holy Grail" PYTHON (MONTY) PICTURES LTD

      /// Bram Moolenaar -- Bram@... -- http://www.Moolenaar.net \\\
      /// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
      \\\ an exciting new programming language -- http://www.Zimbu.org ///
      \\\ help me help AIDS victims -- http://ICCF-Holland.org ///

      --
      You received this message from the "vim_dev" maillist.
      Do not top-post! Type your reply below the text you are replying to.
      For more information, visit http://www.vim.org/maillist.php
    • Show all 7 messages in this topic