Loading ...
Sorry, an error occurred while loading the content.

65745Re: [PATCH] Fix segfault in home_replace() when $HOME is unset

Expand Messages
  • Chris Webb
    Jul 6, 2012
    • 0 Attachment
      Bram Moolenaar <Bram@...> writes:

      >
      > Chris Webb wrote:
      >
      > > home_replace() calls vim_strchr() on the result of mch_getenv("HOME")
      > > without checking for a NULL value. If $HOME is unset, this causes a segfault
      > > reproducible with 'env -i src/vim /etc/passwd'. (Introduced in v7-3-559.)
      > >
      > > Fix by guarding vim_strstr(homedir_env, ...) with homedir_env != NULL.
      >
      > Thanks, I'll include it right away.

      Thanks! Not a bug people are likely to hit other than once in a blue moon. I
      only saw it because I was using env -i a bit too enthusiastically in a
      chroot and was baffled by my editor segfaulting. :)

      Cheers,

      Chris.

      --
      You received this message from the "vim_dev" maillist.
      Do not top-post! Type your reply below the text you are replying to.
      For more information, visit http://www.vim.org/maillist.php
    • Show all 3 messages in this topic