Loading ...
Sorry, an error occurred while loading the content.

33279Re: vim with gtk2, the find dialog's buttons are disabled..

Expand Messages
  • David Necas (Yeti)
    Jul 9, 2003
    • 0 Attachment
      On Wed, Jul 09, 2003 at 07:47:54PM +0200, Aschwin Marsman wrote:
      > On Mon, 7 Jul 2003, Jeremy Messenger wrote:
      >
      > > On Mon, 7 Jul 2003 06:47:31 +0200 (CEST), Aschwin Marsman
      > > <a.marsman@...> wrote:
      > >
      > > > On Sun, 6 Jul 2003, Jeremy Messenger wrote:
      > > >
      > > >> On Sun, 06 Jul 2003 17:28:04 -0500, Jeremy Messenger <mezz7@...>
      > > >> wrote:
      > > >>
      > > >> > I haven't update VIM with GTK2 (6.1.xxx with Daniel's patch) for a
      > > >> quiet > while until today by use FreeBSD's vim port. It's 6.2.014
      > > >> version.
      > > >>
      > > >> Oops, I mean it's 6.2.14 version..
      > > >>
      > > >> > However, the find and find/replace dialogs' buttons has been disabled
      > > >> > (grey). But, I still can use it by press the enter to search and can't
      > > >> > use those buttons thought.
      > > >
      > > > Which GTK version are you using?
      > >
      > > Lastest version, it's GTK 2.2.2..
      >
      > I have 2.0.2 (RH7.3), but I can't use it because it gives a lot of problems, e.g.
      > with fonts. It's of no help if I try to reproduce this, hope somebody else will.
      > Daniel Elstner, which did most of the work for GTK2, might be able to help, but
      > I haven't seen him on this list for a while.

      OK, here's a fix (at the end), at least of what I was able
      to reproduce. Tested on 6.2.0.

      *BUT* it fixes it by bringing back the Most Evil Hack
      entry_changed_cb(), carefully #ifdef-ed out from the Gtk+2
      code paths. It however took care of making the buttons
      sensitive when the entry was nonempty -- among other things.
      So if Daniel is listening and really doesn't like it so much,
      he should come up with some nicer fix now ;-)

      Regards,

      Yeti


      --
      DPM 5.7.2: Do not use tab characters. Their effect is not predictable.



      --- vim62.orig/src/gui_gtk.c 2003-07-09 20:35:51.000000000 +0200
      +++ vim62/src/gui_gtk.c 2003-07-09 20:34:42.000000000 +0200
      @@ -166,9 +166,7 @@
      #endif /* HAVE_GTK2 */

      static void entry_activate_cb(GtkWidget *widget, gpointer data);
      -#ifndef HAVE_GTK2 /* crack alert! */
      static void entry_changed_cb(GtkWidget *entry, GtkWidget *dialog);
      -#endif
      static void find_direction_cb(GtkWidget *widget, gpointer data);
      static void find_replace_cb(GtkWidget *widget, gpointer data);
      static void wword_match_cb(GtkWidget *widget, gpointer data);
      @@ -2472,10 +2470,8 @@
      sensitive = (entry_text != NULL && entry_text[0] != NUL);
      if (entry_text != NULL)
      gtk_entry_set_text(GTK_ENTRY(frdp->what), (char *)entry_text);
      -#ifndef HAVE_GTK2
      gtk_signal_connect(GTK_OBJECT(frdp->what), "changed",
      GTK_SIGNAL_FUNC(entry_changed_cb), frdp->dialog);
      -#endif
      gtk_signal_connect_after(GTK_OBJECT(frdp->what), "key_press_event",
      GTK_SIGNAL_FUNC(find_key_press_event),
      (gpointer) frdp);
      @@ -2879,7 +2875,6 @@
      * particularly evil incarnation of braindeadness, whatever; I'd much rather
      * see it extinguished from this planet. Thanks for listening. Sorry.
      */
      -#ifndef HAVE_GTK2
      static void
      entry_changed_cb(GtkWidget * entry, GtkWidget * dialog)
      {
      @@ -2920,7 +2915,6 @@
      }
      }
      }
      -#endif

      /*
      * ":helpfind"
    • Show all 10 messages in this topic