Loading ...
Sorry, an error occurred while loading the content.

Re: Omnicomplete shows strange behavior when preview window is enabled

Expand Messages
  • Christian Brabandt
    ... Ben, Benjamin, can you check, whether this patch fixes the problem for you? diff -r ba8835947b8b src/screen.c ... +++ b/src/screen.c Tue Feb 12
    Message 1 of 21 , Feb 12, 2013
    • 0 Attachment
      On Fr, 08 Feb 2013, Ben Fritz wrote:

      > On Friday, February 8, 2013 9:37:18 PM UTC-6, Ben Fritz wrote:
      > > On Fri, Feb 8, 2013 at 9:32 PM, Benjamin Fritz <fritzophrenic@...> wrote:
      > >
      > > > The attached vimrc.vim file (when used as the .vimrc, with no
      > >
      > > > non-standard plugins), can reproduce the issue on the attached test.c
      > >
      > > > file with the attached tags file.
      > >

      Ben, Benjamin,
      can you check, whether this patch fixes the problem for you?

      diff -r ba8835947b8b src/screen.c
      --- a/src/screen.c Wed Feb 06 19:58:43 2013 +0100
      +++ b/src/screen.c Tue Feb 12 22:28:06 2013 +0100
      @@ -545,6 +545,10 @@
      }
      #endif
      }
      +#ifdef FEAT_INS_EXPAND
      + if (pum_visible()) /* win_update() might have overwritten the popup menu */
      + pum_redraw();
      +#endif
      #if defined(FEAT_SEARCH_EXTRA)
      end_search_hl();
      #endif

      Bram, I think, this patch fixes an issue, that the completion menu is
      not correctly displayed when the preview window is used (and the windows
      are scrolled). It might be possible, that it also fixes those issues
      from the todo list:

      ,----
      | popup completion menu closes quickly when there is a fold in the buffer. (Jan
      | Christoph Ebersbach, 2011 Jul 3)
      `----

      ,----
      | Completion menu disappears when using 'cursorcolumn'. (Sven-Hendrik Haase,
      | 2011 May 23)
      `----

      But I am not sure, as reproducing the issue seems quite complicated (see
      the long thread on vim_use about how to reproduce it). Do you have more
      infos how to reproduce those issues?

      regards,
      Christian

      --
      --
      You received this message from the "vim_use" maillist.
      Do not top-post! Type your reply below the text you are replying to.
      For more information, visit http://www.vim.org/maillist.php

      ---
      You received this message because you are subscribed to the Google Groups "vim_use" group.
      To unsubscribe from this group and stop receiving emails from it, send an email to vim_use+unsubscribe@....
      For more options, visit https://groups.google.com/groups/opt_out.
    • Benjamin Fritz
      ... Yes, this patch works, at least for my toy test case! Thanks! I don t run self-compiled Vim at work on Windows (at least not yet). But it certainly acts
      Message 2 of 21 , Feb 12, 2013
      • 0 Attachment
        On Tue, Feb 12, 2013 at 3:37 PM, Christian Brabandt <cblists@...> wrote:
        >
        > On Fr, 08 Feb 2013, Ben Fritz wrote:
        >
        >> On Friday, February 8, 2013 9:37:18 PM UTC-6, Ben Fritz wrote:
        >> > On Fri, Feb 8, 2013 at 9:32 PM, Benjamin Fritz <fritzophrenic@...> wrote:
        >> >
        >> > > The attached vimrc.vim file (when used as the .vimrc, with no
        >> >
        >> > > non-standard plugins), can reproduce the issue on the attached test.c
        >> >
        >> > > file with the attached tags file.
        >> >
        >
        > Ben, Benjamin,
        > can you check, whether this patch fixes the problem for you?
        >
        > diff -r ba8835947b8b src/screen.c
        > --- a/src/screen.c Wed Feb 06 19:58:43 2013 +0100
        > +++ b/src/screen.c Tue Feb 12 22:28:06 2013 +0100
        > @@ -545,6 +545,10 @@
        > }
        > #endif
        > }
        > +#ifdef FEAT_INS_EXPAND
        > + if (pum_visible()) /* win_update() might have overwritten the popup menu */
        > + pum_redraw();
        > +#endif
        > #if defined(FEAT_SEARCH_EXTRA)
        > end_search_hl();
        > #endif
        >

        Yes, this patch works, at least for my toy test case! Thanks!

        I don't run self-compiled Vim at work on Windows (at least not yet).
        But it certainly acts like the same issue I've reproduced with my toy
        example. I did get the toy example by paring down my own Vim config
        after all.

        > Bram, I think, this patch fixes an issue, that the completion menu is
        > not correctly displayed when the preview window is used (and the windows
        > are scrolled). It might be possible, that it also fixes those issues
        > from the todo list:
        >
        > ,----
        > | popup completion menu closes quickly when there is a fold in the buffer. (Jan
        > | Christoph Ebersbach, 2011 Jul 3)
        > `----
        >

        I'm pretty sure it will fix this issue, since that's what I thought
        was affecting me.

        > ,----
        > | Completion menu disappears when using 'cursorcolumn'. (Sven-Hendrik Haase,
        > | 2011 May 23)
        > `----
        >

        This one I've never seen first-hand.

        > But I am not sure, as reproducing the issue seems quite complicated (see
        > the long thread on vim_use about how to reproduce it). Do you have more
        > infos how to reproduce those issues?
        >
        > regards,
        > Christian

        --
        --
        You received this message from the "vim_use" maillist.
        Do not top-post! Type your reply below the text you are replying to.
        For more information, visit http://www.vim.org/maillist.php

        ---
        You received this message because you are subscribed to the Google Groups "vim_use" group.
        To unsubscribe from this group and stop receiving emails from it, send an email to vim_use+unsubscribe@....
        For more options, visit https://groups.google.com/groups/opt_out.
      • Bram Moolenaar
        ... It s a bit of a brute force solution but I suppose it should be OK. ... Not much. I ll remove those remarks and await someone reporting a problem again,
        Message 3 of 21 , Feb 13, 2013
        • 0 Attachment
          Christian Brabandt wrote:

          > On Fr, 08 Feb 2013, Ben Fritz wrote:
          >
          > > On Friday, February 8, 2013 9:37:18 PM UTC-6, Ben Fritz wrote:
          > > > On Fri, Feb 8, 2013 at 9:32 PM, Benjamin Fritz <fritzophrenic@...> wrote:
          > > >
          > > > > The attached vimrc.vim file (when used as the .vimrc, with no
          > > >
          > > > > non-standard plugins), can reproduce the issue on the attached test.c
          > > >
          > > > > file with the attached tags file.
          > > >
          >
          > Ben, Benjamin,
          > can you check, whether this patch fixes the problem for you?
          >
          > diff -r ba8835947b8b src/screen.c
          > --- a/src/screen.c Wed Feb 06 19:58:43 2013 +0100
          > +++ b/src/screen.c Tue Feb 12 22:28:06 2013 +0100
          > @@ -545,6 +545,10 @@
          > }
          > #endif
          > }
          > +#ifdef FEAT_INS_EXPAND
          > + if (pum_visible()) /* win_update() might have overwritten the popup menu */
          > + pum_redraw();
          > +#endif
          > #if defined(FEAT_SEARCH_EXTRA)
          > end_search_hl();
          > #endif
          >
          > Bram, I think, this patch fixes an issue, that the completion menu is
          > not correctly displayed when the preview window is used (and the windows
          > are scrolled). It might be possible, that it also fixes those issues
          > from the todo list:

          It's a bit of a brute force solution but I suppose it should be OK.

          > ,----
          > | popup completion menu closes quickly when there is a fold in the buffer. (Jan
          > | Christoph Ebersbach, 2011 Jul 3)
          > `----
          >
          > ,----
          > | Completion menu disappears when using 'cursorcolumn'. (Sven-Hendrik Haase,
          > | 2011 May 23)
          > `----
          >
          > But I am not sure, as reproducing the issue seems quite complicated (see
          > the long thread on vim_use about how to reproduce it). Do you have more
          > infos how to reproduce those issues?

          Not much. I'll remove those remarks and await someone reporting a
          problem again, if there still is a problem.

          --
          Dogs must have a permit signed by the mayor in order to congregate in groups
          of three or more on private property.
          [real standing law in Oklahoma, United States of America]

          /// Bram Moolenaar -- Bram@... -- http://www.Moolenaar.net \\\
          /// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
          \\\ an exciting new programming language -- http://www.Zimbu.org ///
          \\\ help me help AIDS victims -- http://ICCF-Holland.org ///

          --
          --
          You received this message from the "vim_use" maillist.
          Do not top-post! Type your reply below the text you are replying to.
          For more information, visit http://www.vim.org/maillist.php

          ---
          You received this message because you are subscribed to the Google Groups "vim_use" group.
          To unsubscribe from this group and stop receiving emails from it, send an email to vim_use+unsubscribe@....
          For more options, visit https://groups.google.com/groups/opt_out.
        Your message has been successfully submitted and would be delivered to recipients shortly.