Loading ...
Sorry, an error occurred while loading the content.
 

Re: enc_codepage patch

Expand Messages
  • Bram Moolenaar
    ... Looks good. Although I spot a few potential problems in mb_init(). I ll go through it, add a few other related things and post a modified patch. -- A
    Message 1 of 2 , Apr 6, 2003
      Glenn Mail wrote:

      > Primarily, this patch adds enc_codepage, which is set to the codepage
      > specified in p_enc if it's a codepage; it's like enc_dbcs except it's
      > set for all codepages, not just DBCS ones.
      >
      > This obsoletes is_funky_dbcs; do "GetACP() != enc_codepage".
      >
      > enc_to_ucs2 and ucs2_to_enc use enc_codepage.
      >
      > gui_mch_draw_string does, too, so we do the correct conversion for all
      > other codepages (is_funky_dbcs was only being set for DBCS).
      >
      > Also, handle IME string conversion directly (MultiByteToWideChar and
      > ucs2_to_enc); don't use string_convert. This obsoletes ime_conv,
      > ime_conv_cp, CONV_DBCS_TO_UCS2 and probably CONV_UCS2_TO_DBCS.
      > (Sorry, I'd split this out, but then I'd have to test both patches
      > again, and I'm not sure when I'd get to it--this code has been sitting
      > around too long already.)

      Looks good. Although I spot a few potential problems in mb_init().
      I'll go through it, add a few other related things and post a modified
      patch.

      --
      A hamburger walks into a bar, and the bartender says: "I'm sorry,
      but we don't serve food here."

      /// Bram Moolenaar -- Bram@... -- http://www.Moolenaar.net \\\
      /// Creator of Vim - Vi IMproved -- http://www.Vim.org \\\
      \\\ Project leader for A-A-P -- http://www.A-A-P.org ///
      \\\ Help AIDS victims, buy at Amazon -- http://ICCF.nl/click1.html ///
    Your message has been successfully submitted and would be delivered to recipients shortly.