Re: what locale?
- On Fre, 2003-03-21 at 21:09, Bram Moolenaar wrote:
> >Yes -- I said "iconv-specific" struct members.
> > Patch attached. I renamed enc_default() to enc_locale(), made it return
> > an allocated string, and moved the code to set p_enc into src/option.c.
> That looks good.
> > Also I generalized convert_setup() a bit so that the caller is no longer
> > required to explicitely initialize the iconv-specific struct members.
> That doesn't appear to work properly, because vcp->vc_type is not always
> That can be fixed and then setting vcp->vc_fd doesn'tThat's what I did in f_strftime().
> need to be set before calling convert_setup().
> You forgot to free the result of convert_setup().Actually I didn't... but I did indeed forget to vim_free(enc) :-)
> I have fixed these issues and I'll send out a patch after a few tests.Cool.
> > I reckon that might cause problems at least on Win32. I don't thoughSure, though actually strftime() returns the length. But I also think
> > know if strftime() on Windows will ever use UCS-2, UTF-16 or UCS-4.
> I don't think that strftime() would work with UCS-2, since a string
> may contain NUL bytes.
it's unlikely that strftime() was ever meant to work with UCS-2 or