Re: windows and unicode filenames, etc.
- On Mon, Aug 05, 2002 at 03:50:46PM -0400, Glenn Maynard wrote:
> > Isn't it easier to ignore enc_dbcs where the code needs to be used forEh. I'll just add enc_codepage.
> > both encodings?
> Perhaps there should be a single function, win_get_penc_codepage(),
> which does all of that parsing and returns the codepage (or -1 if it's
> not a codepage)?
> Also, the is_funky_dbcs code in the win32 renderer should use this, too,
> since it needs to do the same thing. (Render with Unicode conversion if
> win_get_penc_codepage() != GetACP(); then is_funky_dbcs can probably go
> away, too, since nothing else uses it.)
- On Mon, Aug 05, 2002 at 10:17:17PM +0200, Bram Moolenaar wrote:
> I think it so far only worked for text in the system codepage. WhenRight. That's what I'm doing, with a fallback for 9x.
> setting 'encoding' to something else I would guess we don't convert,
> thus you end up with nonsense. Converting the title to Unicode should
> work (if the wide version of the function is available, might not be
> true on Win 9x).
> Ah, you are running into the problem that enc_dbcs is both used as aWe have the same idea. I'll do this.
> flag that DBCS encoding is being used and the number of the codepage
> used for 'encoding'. We could separate the two to avoid confusion.
> Introduce enc_codepage perhaps?
> > Also, the is_funky_dbcs code in the win32 renderer should use this, too,I think it's just returning a system-wide constant, but I'll run a quick
> > since it needs to do the same thing. (Render with Unicode conversion if
> > win_get_penc_codepage() != GetACP(); then is_funky_dbcs can probably go
> > away, too, since nothing else uses it.)
> If GetACP() is really fast, then is_funky_dbcs becomes obsolete.
> Otherwise, I thought you were planning to rename it anyway.
speed check anyway.