673Re: windows and unicode filenames, etc.
- Aug 5 12:09 PMGlenn Maynard wrote:
> Just a quick update on other fixes:I thought it did work for some DBCS encodings. I did include patches
> Editing files with Unicode in the filename that don't fit in the ANSI
> codepage doesn't work. Fixed, except for the browser, and except for
> renaming (since I don't really want to go near win32's mch_rename, but
> it does need fixing.)
for this in the past.
> The IME didn't work when encoding=ucs2 (or other utf-8-but-notYou still need to do the conversions, right?
> encodings.) Fixed: use ucs2_to_penc. This also does away with
> CONV_UCS2_TO_DBCS and CONV_DBCS_TO_UCS2 completely.
> Treat all Windows codepages as DBCS, since there's no difference betweenThis has a big drawback: for DBCS codes finding the start of a character
> DBCS and SBCS in Windows (SBCS is just DBCS with no lead-bytes). We
> talked about this, and I've hit more problems due to enc_dbcs not being
> set when encoding is set to an SBCS CP.
is complicated and slow. Don't want to use the same code for single
byte encodings. There are quite a few other places where DBCS is
handled much slower.
Isn't it easier to ignore enc_dbcs where the code needs to be used for
> Non-ASCII in the titlebar is problematic. I know the problem and the fix,That sounds good, but we should look very carefully for any problems
> but I havn't done this yet.
> I've added getacp() for Windows, to get the active codepage; this allows
> people to use the enc=utf-8;fencs=ucs-bom,utf-8,cp####,latin1;fenc=cp####
> setup without having to hardcode their codepage (which most people
> probably don't know.) This setup seems to have the desired effect:
> utf-8 internally, current codepage as a higher-priority option for files
> than the ambiguous latin1, and the current codepage as the default flie
with backwards incompatibilities.
> I'll probably revert removing the broken Korean stuff and just comment outStill didn't find someone who can tell when the code is really needed?
> the call for now; I doubt it's needed, but it's not important.
> I won't throw these patches at you yet. Instead, I'll probably be compilingGood, I prefer including tested patches!
> these, describing the patches and the problems they fix better, and making
> binaries available to make them more accessible and try to get some testing
> done. Due to the scope of these changes, I suspect you'll want to wait a
> while on this.
hundred-and-one symptoms of being an internet addict:
108. While reading a magazine, you look for the Zoom icon for a better
look at a photograph.
/// Bram Moolenaar -- Bram@... -- http://www.moolenaar.net \\\
/// Creator of Vim -- http://vim.sf.net -- ftp://ftp.vim.org/pub/vim \\\
\\\ Project leader for A-A-P -- http://www.a-a-p.org ///
\\\ Lord Of The Rings helps Uganda - http://iccf-holland.org/lotr.html ///
- << Previous post in topic Next post in topic >>