Loading ...
Sorry, an error occurred while loading the content.
 

linking problems with patch 6.1.156

Expand Messages
  • Benji Fisher
    I compiled a new version of vim today for Mac OSX (Carbon). It failed with /usr/bin/ld: Undefined symbols: _GetACP make: *** [Vim.x_unix] Error 1 so I grepped
    Message 1 of 8 , Sep 13, 2002
      I compiled a new version of vim today for Mac OSX (Carbon). It
      failed with

      /usr/bin/ld: Undefined symbols:
      _GetACP
      make: *** [Vim.x_unix] Error 1

      so I grepped src/*.c for "ACP", then grepped patches/6.1.1?? for
      "mbyte.c" and decided that patch 6.1.156 is the culprit. I reversed
      this patch (and hand-edited version.c for the patch number...is there a
      better way) and it compiled (and linked) fine. Not much testing yet,
      but I will get to it.

      I hope someone can take it from here. If there is any information
      I can give that will help, let me know.

      --Benji Fisher
    • Bram Moolenaar
      ... GetACP() is a MS-Windows function. I checked and it s only used inside #ifdefs for MS-Windows. Perhaps the patch was applied incorrectly? -- FIRST
      Message 2 of 8 , Sep 14, 2002
        Benji Fisher wrote:

        > I compiled a new version of vim today for Mac OSX (Carbon). It
        > failed with
        >
        > /usr/bin/ld: Undefined symbols:
        > _GetACP
        > make: *** [Vim.x_unix] Error 1
        >
        > so I grepped src/*.c for "ACP", then grepped patches/6.1.1?? for
        > "mbyte.c" and decided that patch 6.1.156 is the culprit. I reversed
        > this patch (and hand-edited version.c for the patch number...is there a
        > better way) and it compiled (and linked) fine. Not much testing yet,
        > but I will get to it.
        >
        > I hope someone can take it from here. If there is any information
        > I can give that will help, let me know.

        GetACP() is a MS-Windows function. I checked and it's only used inside
        #ifdefs for MS-Windows. Perhaps the patch was applied incorrectly?

        --
        FIRST SOLDIER: So they wouldn't be able to bring a coconut back anyway.
        SECOND SOLDIER: Wait a minute! Suppose two swallows carried it together?
        FIRST SOLDIER: No, they'd have to have it on a line.
        "Monty Python and the Holy Grail" PYTHON (MONTY) PICTURES LTD

        /// Bram Moolenaar -- Bram@... -- http://www.moolenaar.net \\\
        /// Creator of Vim - Vi IMproved -- http://www.vim.org \\\
        \\\ Project leader for A-A-P -- http://www.a-a-p.org ///
        \\\ Lord Of The Rings helps Uganda - http://iccf-holland.org/lotr.html ///
      • MURAOKA Taro
        ... I have used this patch for this problems. I hope this would be some help. ... MURAOKA Taro diff -ur src.orig/mbyte.c src/mbyte.c ...
        Message 3 of 8 , Sep 14, 2002
          Bram Moolenaar wrote:
          > GetACP() is a MS-Windows function. I checked and it's only used inside
          > #ifdefs for MS-Windows. Perhaps the patch was applied incorrectly?

          I have used this patch for this problems.
          I hope this would be some help.
          ----
          MURAOKA Taro <koron@...>


          diff -ur src.orig/mbyte.c src/mbyte.c
          --- src.orig/mbyte.c 2002-08-19 20:14:00.000000000 +0900
          +++ src/mbyte.c 2002-08-31 11:57:57.000000000 +0900
          @@ -576,7 +577,7 @@
          if (enc_utf8 && !option_was_set((char_u *)"fencs"))
          set_string_option_direct((char_u *)"fencs", -1,
          (char_u *)"ucs-bom,utf-8,latin1", OPT_FREE);
          -#ifdef FEAT_MBYTE_IME
          +#if defined(WIN3264) && defined (FEAT_MBYTE_IME)
          # ifdef USE_ICONV
          ime_conv.vc_fd = (iconv_t)-1;
          ime_conv_cp.vc_fd = (iconv_t)-1;
        • Bram Moolenaar
          ... How did FEAT_MBYTE_IME get defined? That should only happen for MS-Windows. -- ARTHUR: ... and I am your king .... OLD WOMAN: Ooooh! I didn t know we
          Message 4 of 8 , Sep 14, 2002
            Muraoka Taro wrote:

            > Bram Moolenaar wrote:
            > > GetACP() is a MS-Windows function. I checked and it's only used inside
            > > #ifdefs for MS-Windows. Perhaps the patch was applied incorrectly?
            >
            > I have used this patch for this problems.
            > I hope this would be some help.
            > ----
            > MURAOKA Taro <koron@...>
            >
            >
            > diff -ur src.orig/mbyte.c src/mbyte.c
            > --- src.orig/mbyte.c 2002-08-19 20:14:00.000000000 +0900
            > +++ src/mbyte.c 2002-08-31 11:57:57.000000000 +0900
            > @@ -576,7 +577,7 @@
            > if (enc_utf8 && !option_was_set((char_u *)"fencs"))
            > set_string_option_direct((char_u *)"fencs", -1,
            > (char_u *)"ucs-bom,utf-8,latin1", OPT_FREE);
            > -#ifdef FEAT_MBYTE_IME
            > +#if defined(WIN3264) && defined (FEAT_MBYTE_IME)
            > # ifdef USE_ICONV
            > ime_conv.vc_fd = (iconv_t)-1;
            > ime_conv_cp.vc_fd = (iconv_t)-1;

            How did FEAT_MBYTE_IME get defined? That should only happen for
            MS-Windows.

            --
            ARTHUR: ... and I am your king ....
            OLD WOMAN: Ooooh! I didn't know we had a king. I thought we were an
            autonomous collective ...
            "Monty Python and the Holy Grail" PYTHON (MONTY) PICTURES LTD

            /// Bram Moolenaar -- Bram@... -- http://www.moolenaar.net \\\
            /// Creator of Vim - Vi IMproved -- http://www.vim.org \\\
            \\\ Project leader for A-A-P -- http://www.a-a-p.org ///
            \\\ Lord Of The Rings helps Uganda - http://iccf-holland.org/lotr.html ///
          • MURAOKA Taro
            ... Ah, it may be defined in Make_osx.mak that I had sended before. In that patches, I had implemented input method control and use FEAT_MBYTE_IME for that.
            Message 5 of 8 , Sep 14, 2002
              > How did FEAT_MBYTE_IME get defined? That should only happen for
              > MS-Windows.

              Ah, it may be defined in Make_osx.mak that I had sended before.
              In that patches, I had implemented input method control
              and use FEAT_MBYTE_IME for that.
              ----
              MURAOKA Taro <koron@...>
            • Benji Fisher
              ... [patch snipped] Thank you. I will test it. ... I am not sure exactly where FEAT_MBYTE_IME gets defined, but I think it comes from patch 6.1.076. That
              Message 6 of 8 , Sep 14, 2002
                Bram Moolenaar wrote:
                >
                > Muraoka Taro wrote:
                >
                > > I have used this patch for this problems.
                > > I hope this would be some help.
                > >
                > > diff -ur src.orig/mbyte.c src/mbyte.c
                > > --- src.orig/mbyte.c 2002-08-19 20:14:00.000000000 +0900
                > > +++ src/mbyte.c 2002-08-31 11:57:57.000000000 +0900
                [patch snipped]

                Thank you. I will test it.

                > How did FEAT_MBYTE_IME get defined? That should only happen for
                > MS-Windows.

                I am not sure exactly where FEAT_MBYTE_IME gets defined, but I think it
                comes from patch 6.1.076. That patch (along with some other effects) added
                Muraoka Taro's IME support to the OSX version of vim. Give me a day or two, and
                I will recommend a few patches for OSX. (I will recommend some for inclusion
                and some for further study/testing.)

                --Benji Fisher
              • Bram Moolenaar
                ... Good. It is about time we include all the patches, so that we have a common version to do further work on. -- DENNIS: You can t expect to wield supreme
                Message 7 of 8 , Sep 15, 2002
                  Benji Fisher wrote:

                  > > How did FEAT_MBYTE_IME get defined? That should only happen for
                  > > MS-Windows.
                  >
                  > I am not sure exactly where FEAT_MBYTE_IME gets defined, but I think it
                  > comes from patch 6.1.076. That patch (along with some other effects)
                  > added Muraoka Taro's IME support to the OSX version of vim. Give me a
                  > day or two, and I will recommend a few patches for OSX. (I will
                  > recommend some for inclusion and some for further study/testing.)

                  Good. It is about time we include all the patches, so that we have a
                  common version to do further work on.

                  --
                  DENNIS: You can't expect to wield supreme executive power just 'cause some
                  watery tart threw a sword at you!
                  "Monty Python and the Holy Grail" PYTHON (MONTY) PICTURES LTD

                  /// Bram Moolenaar -- Bram@... -- http://www.moolenaar.net \\\
                  /// Creator of Vim - Vi IMproved -- http://www.vim.org \\\
                  \\\ Project leader for A-A-P -- http://www.a-a-p.org ///
                  \\\ Lord Of The Rings helps Uganda - http://iccf-holland.org/lotr.html ///
                • Bram Moolenaar
                  ... I see. Perhaps it s better to do this in feature.h, so that this is all in one place. At least it should be mentioned there that this is also used for
                  Message 8 of 8 , Sep 15, 2002
                    Muraoka Taro wrote:

                    > > How did FEAT_MBYTE_IME get defined? That should only happen for
                    > > MS-Windows.
                    >
                    > Ah, it may be defined in Make_osx.mak that I had sended before.
                    > In that patches, I had implemented input method control
                    > and use FEAT_MBYTE_IME for that.

                    I see. Perhaps it's better to do this in feature.h, so that this is all
                    in one place. At least it should be mentioned there that this is also
                    used for the Mac.

                    --
                    ARTHUR: Now stand aside worthy adversary.
                    BLACK KNIGHT: (Glancing at his shoulder) 'Tis but a scratch.
                    ARTHUR: A scratch? Your arm's off.
                    "Monty Python and the Holy Grail" PYTHON (MONTY) PICTURES LTD

                    /// Bram Moolenaar -- Bram@... -- http://www.moolenaar.net \\\
                    /// Creator of Vim - Vi IMproved -- http://www.vim.org \\\
                    \\\ Project leader for A-A-P -- http://www.a-a-p.org ///
                    \\\ Lord Of The Rings helps Uganda - http://iccf-holland.org/lotr.html ///
                  Your message has been successfully submitted and would be delivered to recipients shortly.