Loading ...
Sorry, an error occurred while loading the content.

Re: fuoptions

Expand Messages
  • björn
    ... I just applied that patch, so Git is most probably not wanting to apply the same patch twice. Just do a new pull&build and you ll get the fuopt
    Message 1 of 14 , Mar 18, 2008
    • 0 Attachment
      On 18/03/2008, dv1445@... <dv1445@...> wrote:
      >
      > Thus spake Nico Weber [03/17/08 @ 21.58.48 +0100]:
      >
      > > > Sending the 'fuopt' along with the enter/leave fullscreen message was
      > > > the approach I was mulling over myself. I never thought it through
      > > > entirely, but if that way is possible then I think it would be great.
      > >
      > > The attached patch does this. I only use asynchronous communication;
      > > if one of the asynchronous messages gets dropped, strange things will
      > > probably happen. I don't know how to do this in a better way. The
      > > flickering is no longer visible as far as I can tell.
      > >
      > > Tell me if this needs more polishing (the enterFullscreen/
      > > leaveFullscreen functions in MMFullscreenWindow are becoming a bit
      > > long for example).
      >
      >
      > I tried applying this patch with git-am as Björn recently instructed, and got error messages. The attempted git-am was on a fresh git clone from five minutes ago. Here's what I got:
      >
      > Applying scaffolding needed for a new option
      > .dotest/patch:49: trailing whitespace.
      > XXX: Think about how 'fullscreen' and 'transparency' should interact.
      > .dotest/patch:72: trailing whitespace.
      > Examples:
      > error: patch failed: runtime/doc/gui_mac.txt:124
      > error: runtime/doc/gui_mac.txt: patch does not apply
      > error: patch failed: runtime/doc/options.txt:3068
      > error: runtime/doc/options.txt: patch does not apply
      > error: patch failed: runtime/doc/quickref.txt:708
      > error: runtime/doc/quickref.txt: patch does not apply
      > error: patch failed: runtime/doc/tags:246
      > error: runtime/doc/tags: patch does not apply
      > error: patch failed: runtime/optwin.vim:621
      > error: runtime/optwin.vim: patch does not apply
      > error: patch failed: src/option.c:1161
      > error: src/option.c: patch does not apply
      > error: patch failed: src/option.h:470
      > error: src/option.h: patch does not apply
      > Patch failed at 0001.
      > When you have resolved this problem run "git-am --resolved".
      > If you would prefer to skip this patch, instead run "git-am --skip".
      >
      > Am I doing something wrong?

      I just applied that patch, so Git is most probably not wanting to
      apply the same patch twice. Just do a new pull&build and you'll get
      the 'fuopt' functionality.

      /Björn

      --~--~---------~--~----~------------~-------~--~----~
      You received this message from the "vim_mac" maillist.
      For more information, visit http://www.vim.org/maillist.php
      -~----------~----~----~----~------~----~------~--~---
    Your message has been successfully submitted and would be delivered to recipients shortly.