Loading ...
Sorry, an error occurred while loading the content.

Re: Display Bug in Leopard

Expand Messages
  • georgeharker@googlemail.com
    This patch diff --git a/src/MacVim/MMTextStorage.m b/src/MacVim/MMTextStorage.m index 21bb518..088497b 100644 ... +++ b/src/MacVim/MMTextStorage.m @@ -238,7
    Message 1 of 17 , Nov 4, 2007
    • 0 Attachment
      This patch

      diff --git a/src/MacVim/MMTextStorage.m b/src/MacVim/MMTextStorage.m
      index 21bb518..088497b 100644
      --- a/src/MacVim/MMTextStorage.m
      +++ b/src/MacVim/MMTextStorage.m
      @@ -238,7 +238,7 @@
      bg, NSBackgroundColorAttributeName,
      fg, NSForegroundColorAttributeName,
      sp, NSUnderlineColorAttributeName,
      - [NSNumber numberWithFloat:
      2],NSBaselineOffsetAttributeName,
      +// [NSNumber numberWithFloat:
      2],NSBaselineOffsetAttributeName,
      nil];
      } else {
      attributes = [NSDictionary dictionaryWithObjectsAndKeys:


      Disables messing with the basline. I think Leopard APIs allow you to
      set the spelling style which was supported using the same keys on
      earlier oses, but with no docs / constants defined. I'll investigate.

      Cheers

      George


      --~--~---------~--~----~------------~-------~--~----~
      You received this message from the "vim_mac" maillist.
      For more information, visit http://www.vim.org/maillist.php
      -~----------~----~----~----~------~----~------~--~---
    • nicolasweber@gmx.de
      ... The patch above fixes the display problem on Leopard. Here s the output of `:higlight` with and without the patch: http://amnoid.de/tmp/underline_now.png
      Message 2 of 17 , Nov 5, 2007
      • 0 Attachment
        > This patch
        >
        > diff --git a/src/MacVim/MMTextStorage.m b/src/MacVim/MMTextStorage.m
        > index 21bb518..088497b 100644
        > --- a/src/MacVim/MMTextStorage.m
        > +++ b/src/MacVim/MMTextStorage.m
        > @@ -238,7 +238,7 @@
        > bg, NSBackgroundColorAttributeName,
        > fg, NSForegroundColorAttributeName,
        > sp, NSUnderlineColorAttributeName,
        > - [NSNumber numberWithFloat:
        > 2],NSBaselineOffsetAttributeName,
        > +// [NSNumber numberWithFloat:
        > 2],NSBaselineOffsetAttributeName,
        > nil];
        > } else {
        > attributes = [NSDictionary dictionaryWithObjectsAndKeys:
        >
        > Disables messing with the basline. I think Leopard APIs allow you to
        > set the spelling style which was supported using the same keys on
        > earlier oses, but with no docs / constants defined. I'll investigate.

        The patch above fixes the display problem on Leopard. Here's the
        output of `:higlight` with and without the patch:

        http://amnoid.de/tmp/underline_now.png
        http://amnoid.de/tmp/underline_patched.png

        It also fixes the display problems with spell checking. I vote for
        including this patch until George is done investigating :-)

        Nico


        --~--~---------~--~----~------------~-------~--~----~
        You received this message from the "vim_mac" maillist.
        For more information, visit http://www.vim.org/maillist.php
        -~----------~----~----~----~------~----~------~--~---
      • björn
        ... Done. I ve pushed a fix that disables changing the baseline for underlined text. /Björn --~--~---------~--~----~------------~-------~--~----~ You
        Message 3 of 17 , Nov 5, 2007
        • 0 Attachment
          On 05/11/2007, nicolasweber@... <nicolasweber@...> wrote:
          >
          > > This patch
          > >
          > > diff --git a/src/MacVim/MMTextStorage.m b/src/MacVim/MMTextStorage.m
          > > index 21bb518..088497b 100644
          > > --- a/src/MacVim/MMTextStorage.m
          > > +++ b/src/MacVim/MMTextStorage.m
          > > @@ -238,7 +238,7 @@
          > > bg, NSBackgroundColorAttributeName,
          > > fg, NSForegroundColorAttributeName,
          > > sp, NSUnderlineColorAttributeName,
          > > - [NSNumber numberWithFloat:
          > > 2],NSBaselineOffsetAttributeName,
          > > +// [NSNumber numberWithFloat:
          > > 2],NSBaselineOffsetAttributeName,
          > > nil];
          > > } else {
          > > attributes = [NSDictionary dictionaryWithObjectsAndKeys:
          > >
          > > Disables messing with the basline. I think Leopard APIs allow you to
          > > set the spelling style which was supported using the same keys on
          > > earlier oses, but with no docs / constants defined. I'll investigate.
          >
          > The patch above fixes the display problem on Leopard. Here's the
          > output of `:higlight` with and without the patch:
          >
          > http://amnoid.de/tmp/underline_now.png
          > http://amnoid.de/tmp/underline_patched.png
          >
          > It also fixes the display problems with spell checking. I vote for
          > including this patch until George is done investigating :-)

          Done. I've pushed a fix that disables changing the baseline for
          underlined text.

          /Björn

          --~--~---------~--~----~------------~-------~--~----~
          You received this message from the "vim_mac" maillist.
          For more information, visit http://www.vim.org/maillist.php
          -~----------~----~----~----~------~----~------~--~---
        • George Harker
          Cool. Bizarrely under leopard, the basline offset doesn t really seem to be needed, whereas under tiger, the underline was way too tightly placed under the
          Message 4 of 17 , Nov 5, 2007
          • 0 Attachment
            Cool. Bizarrely under leopard, the basline offset doesn't really seem
            to be needed, whereas under tiger, the underline was way too tightly
            placed under the text (making it hard to see).

            Cheers

            George

            On 05/11/2007, bj�rn <bjorn.winckler@...> wrote:
            >
            > On 05/11/2007, nicolasweber@... <nicolasweber@...> wrote:
            > >
            > > > This patch
            > > >
            > > > diff --git a/src/MacVim/MMTextStorage.m b/src/MacVim/MMTextStorage.m
            > > > index 21bb518..088497b 100644
            > > > --- a/src/MacVim/MMTextStorage.m
            > > > +++ b/src/MacVim/MMTextStorage.m
            > > > @@ -238,7 +238,7 @@
            > > > bg, NSBackgroundColorAttributeName,
            > > > fg, NSForegroundColorAttributeName,
            > > > sp, NSUnderlineColorAttributeName,
            > > > - [NSNumber numberWithFloat:
            > > > 2],NSBaselineOffsetAttributeName,
            > > > +// [NSNumber numberWithFloat:
            > > > 2],NSBaselineOffsetAttributeName,
            > > > nil];
            > > > } else {
            > > > attributes = [NSDictionary dictionaryWithObjectsAndKeys:
            > > >
            > > > Disables messing with the basline. I think Leopard APIs allow you to
            > > > set the spelling style which was supported using the same keys on
            > > > earlier oses, but with no docs / constants defined. I'll investigate.
            > >
            > > The patch above fixes the display problem on Leopard. Here's the
            > > output of `:higlight` with and without the patch:
            > >
            > > http://amnoid.de/tmp/underline_now.png
            > > http://amnoid.de/tmp/underline_patched.png
            > >
            > > It also fixes the display problems with spell checking. I vote for
            > > including this patch until George is done investigating :-)
            >
            > Done. I've pushed a fix that disables changing the baseline for
            > underlined text.
            >
            > /Bj�rn
            >
            > >
            >

            --~--~---------~--~----~------------~-------~--~----~
            You received this message from the "vim_mac" maillist.
            For more information, visit http://www.vim.org/maillist.php
            -~----------~----~----~----~------~----~------~--~---
          • waha
            ... I m still seeing the same issue on unicode characters (In this case, Japanese), using the latest git clone. -- Richard Olsson
            Message 5 of 17 , Nov 7, 2007
            • 0 Attachment
              On Nov 5, 3:56 pm, "björn" <bjorn.winck...@...> wrote:
              > Done. I've pushed a fix that disables changing the baseline for
              > underlined text.

              I'm still seeing the same issue on unicode characters (In this case,
              Japanese), using the latest git clone.

              --
              Richard Olsson


              --~--~---------~--~----~------------~-------~--~----~
              You received this message from the "vim_mac" maillist.
              For more information, visit http://www.vim.org/maillist.php
              -~----------~----~----~----~------~----~------~--~---
            • björn
              ... There were (at least) two different issues here, so you ll have to be more specific about what problem you are having. You may want to pull from the Git
              Message 6 of 17 , Nov 11, 2007
              • 0 Attachment
                On 08/11/2007, waha <richard.olsson@...> wrote:
                >
                > On Nov 5, 3:56 pm, "björn" <bjorn.winck...@...> wrote:
                > > Done. I've pushed a fix that disables changing the baseline for
                > > underlined text.
                >
                > I'm still seeing the same issue on unicode characters (In this case,
                > Japanese), using the latest git clone.

                There were (at least) two different issues here, so you'll have to be
                more specific about what problem you are having.

                You may want to pull from the Git repo and try the new text renderer
                (see my previous post).


                /Björn

                --~--~---------~--~----~------------~-------~--~----~
                You received this message from the "vim_mac" maillist.
                For more information, visit http://www.vim.org/maillist.php
                -~----------~----~----~----~------~----~------~--~---
              Your message has been successfully submitted and would be delivered to recipients shortly.