Loading ...
Sorry, an error occurred while loading the content.

Re: [PATCH] implemented netbeans_intg

Expand Messages
  • Bram Moolenaar
    ... I finally had time to have a look at this patch. Most of the changes are to files not in the normal Vim distribution. And most of the changes to
    Message 1 of 8 , Jul 10, 2010
    • 0 Attachment
      Kazuki Sakamoto wrote:

      > Hi Björn,
      >
      > On Fri, Jun 26, 2009 at 12:25 AM, björn<bjorn.winckler@...> wrote:
      >
      > > That's great! I think a lot of people will appreciate this.
      >
      > Thanks! I am happy to hear that.
      >
      > > I haven't tested the code yet but the patch looks good. I only have a
      > > few (trivial) comments at the moment:
      > > 1. What happens if setNetbeansSocket: is called twice with "socket ==
      > > -1"? Same thing if called with two different values for "socket"? (I
      > > guess the way it is set up this will never happen but it doesn't hurt
      > > to be a bit paranoid and make this more robust by freeing all
      > > structures and setting them to nil before CFSocketCreate...() and
      > > making sure you don't call CFRelease() twice on the same structure.)
      >
      > Ok, I have made sure it.
      >
      > > 2. Check whitespace in feature.h/netbeans.c -- you should use "set et"
      > > in the core Vim source code files (at the moment there are spaces in
      > > some places where there should be tabs).
      > > Sorry, that was meant to read "set noet".
      >
      > understand. I have fixed about whitespace as other lines.
      >
      >
      > By the way, we might need to implement `+balloon_eval' as well.
      > src/gui_beval.c

      I finally had time to have a look at this patch. Most of the changes
      are to files not in the normal Vim distribution. And most of the
      changes to src/netbeans.c are rejected, other changes interfere.

      Thus I won't include this now. If you would like Vim 7.3 to include
      some of these changes, please send a new patch.

      --
      TALL KNIGHT OF NI: Ni!
      "Monty Python and the Holy Grail" PYTHON (MONTY) PICTURES LTD

      /// Bram Moolenaar -- Bram@... -- http://www.Moolenaar.net \\\
      /// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
      \\\ download, build and distribute -- http://www.A-A-P.org ///
      \\\ help me help AIDS victims -- http://ICCF-Holland.org ///

      --
      You received this message from the "vim_mac" maillist.
      Do not top-post! Type your reply below the text you are replying to.
      For more information, visit http://www.vim.org/maillist.php
    Your message has been successfully submitted and would be delivered to recipients shortly.