Loading ...
Sorry, an error occurred while loading the content.
 

[PATCH] Set up the title of main menu with boldface

Expand Messages
  • Kazuki Sakamoto
    Hi, I ve made a patch for boldfaced title MacVim in the main menu. How about it? NSMenuItem setAttributedTitle: with boldface font was created from [NSMenu
    Message 1 of 8 , Feb 16, 2010
      Hi,

      I've made a patch for boldfaced title "MacVim" in the main menu. How about it?

      NSMenuItem setAttributedTitle: with boldface font was created from [NSMenu font]
      http://developer.apple.com/mac/library/DOCUMENTATION/Cocoa/Reference/ApplicationKit/Classes/NSMenuItem_Class/Reference/Reference.html#jumpTo_29

      sakamoto

      --
      You received this message from the "vim_mac" maillist.
      For more information, visit http://www.vim.org/maillist.php
    • björn
      ... Hi Sakamoto, I do not get the point of your patch: the MacVim menu should automatically be boldfaced (at least it is for me). Are you doing something to
      Message 2 of 8 , Feb 17, 2010
        On 17 February 2010 02:30, Kazuki Sakamoto wrote:
        > Hi,
        >
        > I've made a patch for boldfaced title "MacVim" in the main menu. How about it?
        >
        > NSMenuItem setAttributedTitle: with boldface font was created from [NSMenu font]
        > http://developer.apple.com/mac/library/DOCUMENTATION/Cocoa/Reference/ApplicationKit/Classes/NSMenuItem_Class/Reference/Reference.html#jumpTo_29

        Hi Sakamoto,

        I do not get the point of your patch: the "MacVim" menu should
        automatically be boldfaced (at least it is for me). Are you doing
        something to provide custom menus that cause the "MacVim" menu not to
        be boldfaced perhaps?

        Björn

        --
        You received this message from the "vim_mac" maillist.
        For more information, visit http://www.vim.org/maillist.php
      • Kazuki Sakamoto
        Hi Björn, ... Hmm, let me check. I have tested snapshot 51 on Leopard and Snow Leopard. Leopard + MacVim snapshot 51: title is not boldfaced (attached) Snow
        Message 3 of 8 , Feb 17, 2010
          Hi Björn,

          On Wed, Feb 17, 2010 at 8:23 PM, björn <bjorn.winckler@...> wrote:
          > I do not get the point of your patch: the "MacVim" menu should
          > automatically be boldfaced (at least it is for me).

          Hmm, let me check.
          I have tested snapshot 51 on Leopard and Snow Leopard.

          Leopard + MacVim snapshot 51: title is not boldfaced (attached)

          Snow Leopard + MacVim snapshot 51: title is boldfaced


          Ok, I will update my Leopard mac to Snow Leopard :-)

          sakamoto

          --
          You received this message from the "vim_mac" maillist.
          For more information, visit http://www.vim.org/maillist.php
        • björn
          ... Hmmm...it should still work on Leopard. Does anybody else have non-bold MacVim menu title on Leopard? I don t really want to apply your patch, I d
          Message 4 of 8 , Feb 18, 2010
            On 18 February 2010 01:25, Kazuki Sakamoto wrote:
            > Hi Björn,
            >
            > On Wed, Feb 17, 2010 at 8:23 PM, björn <bjorn.winckler@...> wrote:
            >> I do not get the point of your patch: the "MacVim" menu should
            >> automatically be boldfaced (at least it is for me).
            >
            > Hmm, let me check.
            > I have tested snapshot 51 on Leopard and Snow Leopard.
            >
            > Leopard + MacVim snapshot 51: title is not boldfaced (attached)
            >
            > Snow Leopard + MacVim snapshot 51: title is boldfaced

            Hmmm...it should still work on Leopard. Does anybody else have
            non-bold "MacVim" menu title on Leopard?

            I don't really want to apply your patch, I'd rather know why the
            problem appears. Any clue as to what causes the problem? (I don't
            have access to Leopard anymore so I can't really debug this.)

            Björn

            --
            You received this message from the "vim_mac" maillist.
            For more information, visit http://www.vim.org/maillist.php
          • Cássio Marques
            I m using Leopard here and it s boldfaced. ... -- Cássio Marques Blog: http://cassiomarques.wordpress.com If you re writing code and you re not testing it,
            Message 5 of 8 , Feb 18, 2010
              I'm using Leopard here and it's boldfaced.

              On Thu, Feb 18, 2010 at 2:19 PM, björn <bjorn.winckler@...> wrote:
              On 18 February 2010 01:25, Kazuki Sakamoto wrote:
              > Hi Björn,
              >
              > On Wed, Feb 17, 2010 at 8:23 PM, björn <bjorn.winckler@...> wrote:
              >> I do not get the point of your patch: the "MacVim" menu should
              >> automatically be boldfaced (at least it is for me).
              >
              > Hmm, let me check.
              > I have tested snapshot 51 on Leopard and Snow Leopard.
              >
              > Leopard + MacVim snapshot 51: title is not boldfaced (attached)
              >
              > Snow Leopard + MacVim snapshot 51: title is boldfaced

              Hmmm...it should still work on Leopard.  Does anybody else have
              non-bold "MacVim" menu title on Leopard?

              I don't really want to apply your patch, I'd rather know why the
              problem appears.  Any clue as to what causes the problem?  (I don't
              have access to Leopard anymore so I can't really debug this.)

              Björn

              --
              You received this message from the "vim_mac" maillist.
              For more information, visit http://www.vim.org/maillist.php



              --
              Cássio Marques

              Blog: http://cassiomarques.wordpress.com

              If you're writing code and you're not testing it, the code is wrong. I don't care if it does the right thing, and people need to understand this. If it works by accident, you're still wrong.
              Bryan Liles - Ruby Hoedown 2008

              --
              You received this message from the "vim_mac" maillist.
              For more information, visit http://www.vim.org/maillist.php
            • Niklas Lindström
              Hi, ... I ve had non-bold MacVim in the menu for quite some time (but haven t really thought about it until now). I m running Leopard 10.5.8. I have some
              Message 6 of 8 , Feb 20, 2010
                Hi,

                On Thu, Feb 18, 2010 at 5:19 PM, björn <bjorn.winckler@...> wrote:
                > Hmmm...it should still work on Leopard.  Does anybody else have
                > non-bold "MacVim" menu title on Leopard?

                I've had non-bold MacVim in the menu for quite some time (but haven't
                really thought about it until now). I'm running Leopard 10.5.8.

                I have some custom menus added, but I performed the tests below both
                with my .vimrc, .gvimrc and .vim in place and moved out of the way.

                I pulled and built the latest, and downloaded both snapshot 51 and
                MacVim-7.2-stable-1.2, then tried them all. Only the stable build has
                the a bold-faced MacVim menu all the time, the rest behave like:

                - When I open a new vim window, it goes to a regular "un-bold" (which
                is of course what happens at startup)
                - When MacVim is running but no windows are open, the MacVim menu is/goes bold

                So it seems in recent builds on Leopard, the MacVim menu won't stay
                bold-faced when even the regular vim menus are added.

                Best regards,
                Niklas

                --
                You received this message from the "vim_mac" maillist.
                For more information, visit http://www.vim.org/maillist.php
              • Kazuki Sakamoto
                Hi Björn, ... I have noticed that my patch doesn t work on Leopard (NSMenu font method is for OS X 10.6 or later). Please ignore it. Sorry for the mess.
                Message 7 of 8 , Feb 21, 2010
                  Hi Björn,

                  On Fri, Feb 19, 2010 at 1:19 AM, björn <bjorn.winckler@...> wrote:
                  > I don't really want to apply your patch, I'd rather know why the
                  > problem appears.  Any clue as to what causes the problem?  (I don't
                  > have access to Leopard anymore so I can't really debug this.)

                  I have noticed that my patch doesn't work on Leopard
                  (NSMenu font method is for OS X 10.6 or later). Please ignore it.
                  Sorry for the mess.

                  sakamoto

                  --
                  You received this message from the "vim_mac" maillist.
                  For more information, visit http://www.vim.org/maillist.php
                • björn
                  ... Ok. I guess this isn t a critical issue, but it would be nice to know why the menu item is no longer bold. If you care to do a git-bisect to find out
                  Message 8 of 8 , Feb 23, 2010
                    On 22 February 2010 02:45, Kazuki Sakamoto wrote:
                    > Hi Björn,
                    >
                    > On Fri, Feb 19, 2010 at 1:19 AM, björn <bjorn.winckler@...> wrote:
                    >> I don't really want to apply your patch, I'd rather know why the
                    >> problem appears.  Any clue as to what causes the problem?  (I don't
                    >> have access to Leopard anymore so I can't really debug this.)
                    >
                    > I have noticed that my patch doesn't work on Leopard
                    > (NSMenu font method is for OS X 10.6 or later). Please ignore it.
                    > Sorry for the mess.

                    Ok.

                    I guess this isn't a critical issue, but it would be nice to know why
                    the menu item is no longer bold. If you care to do a git-bisect to
                    find out which commit introduced this bug I'd be curious to know the
                    answer (but by all means don't waste too much time on this).

                    Björn

                    --
                    You received this message from the "vim_mac" maillist.
                    For more information, visit http://www.vim.org/maillist.php
                  Your message has been successfully submitted and would be delivered to recipients shortly.